Code Review for 7145537

Prepared by:never on Tue Feb 14 12:24:15 PST 2012
Workspace:/net/smite.us.oracle.com/export/ws/tdump
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot
Summary of changes: 61 lines changed: 19 ins; 14 del; 28 mod; 9604 unchg
Patch of changes: 7145537.patch
Author comments:
7145537: minor tweaks to LogEvents
Reviewed-by:

A few minor fixes and corrections to the LogEvents output. Add the
compile id and osr flag to the nmethod logging. Switch all the times
to the seconds since JVM start and print in standard %.3f format.
Override PrintHeapAtGCExtended when logging the heap. Move
Events::print to the cpp to ease invoking it from the debugger. I
also restored the extern "C" events() function to use when the
debugger is being difficult about invoking C++ methods. I also
expanded the logging of implicit exceptions to record more cases. I
considered removing the generate implicit exception logging since
that's not as rare as the others. Tested with crashing the JVM.

Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileBroker.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/gcLocker.hpp

3 lines changed: 0 ins; 3 del; 0 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/gcLocker.cpp

8 lines changed: 0 ins; 2 del; 6 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/universe.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/universe.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 1647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/collectedHeap.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 528 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

5 lines changed: 5 ins; 0 del; 0 mod; 2955 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/debug.cpp

5 lines changed: 4 ins; 0 del; 1 mod; 917 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/events.hpp

25 lines changed: 5 ins; 9 del; 11 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/events.cpp

4 lines changed: 4 ins; 0 del; 0 mod; 103 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never-dev).