Code Review for open

Prepared by:never on Thu Nov 1 16:50:53 PDT 2018
Workspace:/Users/tkrodrig/ws/jdk-jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:52374
Summary of changes: 570 lines changed: 443 ins; 65 del; 62 mod; 11341 unchg
Changeset: open.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

10 lines changed: 8 ins; 2 del; 0 mod; 1354 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/jvmciCodeInstaller.hpp

4 lines changed: 4 ins; 0 del; 0 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

8 lines changed: 8 ins; 0 del; 0 mod; 1585 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/BytecodePosition.java

7 lines changed: 6 ins; 0 del; 1 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotJVMCIBackendFactory.java

5 lines changed: 0 ins; 0 del; 5 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/AArch64HotSpotRegisterConfig.java

2 lines changed: 0 ins; 1 del; 1 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotJVMCIBackendFactory.java

5 lines changed: 0 ins; 0 del; 5 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/AMD64HotSpotVMConfig.java

4 lines changed: 3 ins; 0 del; 1 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/SPARCHotSpotJVMCIBackendFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java

9 lines changed: 0 ins; 1 del; 8 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/EventProvider.java

2 lines changed: 0 ins; 0 del; 2 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotCodeCacheProvider.java

4 lines changed: 0 ins; 0 del; 4 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPool.java

3 lines changed: 2 ins; 0 del; 1 mod; 800 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantPoolObject.java

2 lines changed: 0 ins; 0 del; 2 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java

1 line changed: 0 ins; 0 del; 1 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotJVMCIRuntime.java

42 lines changed: 0 ins; 36 del; 6 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodData.java

3 lines changed: 1 ins; 0 del; 2 mod; 867 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMethodDataAccessor.java

2 lines changed: 0 ins; 0 del; 2 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotObjectConstant.java

3 lines changed: 3 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotProfilingInfo.java

2 lines changed: 0 ins; 0 del; 2 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaFieldImpl.java

3 lines changed: 0 ins; 2 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethod.java

2 lines changed: 1 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java

37 lines changed: 18 ins; 18 del; 1 mod; 799 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedObjectType.java

10 lines changed: 7 ins; 2 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedPrimitiveType.java

1 line changed: 0 ins; 0 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotSpeculationLog.java

2 lines changed: 1 ins; 1 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigAccess.java

8 lines changed: 4 ins; 0 del; 4 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotVMConfigStore.java

54 lines changed: 52 ins; 0 del; 2 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/Assumptions.java

1 line changed: 0 ins; 0 del; 1 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ConstantPool.java

2 lines changed: 0 ins; 0 del; 2 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/LocalVariableTable.java

2 lines changed: 0 ins; 0 del; 2 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/ModifiersProvider.java

4 lines changed: 2 ins; 2 del; 0 mod; 145 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.aarch64/src/jdk/vm/ci/aarch64/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.amd64/src/jdk/vm/ci/amd64/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/site/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.code/src/jdk/vm/ci/code/stack/package-info.java

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.common/src/jdk/vm/ci/common/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.aarch64/src/jdk/vm/ci/hotspot/aarch64/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.amd64/src/jdk/vm/ci/hotspot/amd64/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot.sparc/src/jdk/vm/ci/hotspot/sparc/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.runtime/src/jdk/vm/ci/runtime/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.services/src/jdk/vm/ci/services/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.sparc/src/jdk/vm/ci/sparc/package-info.java

27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/tkrodrig/ws/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).