* For an in-depth explanation of invalidation events and how they differ from * change events, see the documentation of {@code ObservableValue}. --- old/modules/javafx.base/src/main/java/javafx/beans/WeakInvalidationListener.java 2018-07-31 08:50:15.122220500 +0300 +++ new/modules/javafx.base/src/main/java/javafx/beans/WeakInvalidationListener.java 2018-07-31 08:50:14.840077000 +0300 @@ -29,18 +29,18 @@ import javafx.beans.NamedArg; /** - * A {@code WeakInvalidationListener} can be used, if an {@link Observable} + * A {@code WeakInvalidationListener} can be used if an {@link Observable} * should only maintain a weak reference to the listener. This helps to avoid - * memory leaks, that can occur if observers are not unregistered from observed + * memory leaks that can occur if observers are not unregistered from observed * objects after use. *
- * {@code WeakInvalidationListener} are created by passing in the original + * A {@code WeakInvalidationListener} is created by passing in the original * {@link InvalidationListener}. The {@code WeakInvalidationListener} should * then be registered to listen for changes of the observed object. *
- * Note: You have to keep a reference to the {@code InvalidationListener}, that - * was passed in as long as it is in use, otherwise it will be garbage collected - * to soon. + * Note: You have to keep a reference to the {@code InvalidationListener} that + * was passed in as long as it is in use, otherwise it can be garbage collected + * too soon. * * @see InvalidationListener * @see Observable --- old/modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java 2018-07-31 08:50:17.256853100 +0300 +++ new/modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java 2018-07-31 08:50:16.991795100 +0300 @@ -44,8 +44,8 @@ *
* An {@code ObservableValue} generates two types of events: change events and * invalidation events. A change event indicates that the value has changed. An - * invalidation event is generated, if the current value is not valid anymore. - * This distinction becomes important, if the {@code ObservableValue} supports + * invalidation event is generated if the current value is not valid anymore. + * This distinction becomes important if the {@code ObservableValue} supports * lazy evaluation, because for a lazily evaluated value one does not know if an * invalid value really has changed until it is recomputed. For this reason, * generating change events requires eager evaluation while invalidation events @@ -108,7 +108,7 @@ void addListener(ChangeListener listener); /** - * Removes the given listener from the list of listeners, that are notified + * Removes the given listener from the list of listeners that are notified * whenever the value of the {@code ObservableValue} changes. *
* If the given listener has not been previously registered (i.e. it was --- old/modules/javafx.graphics/src/main/java/javafx/scene/Node.java 2018-07-31 08:50:19.399822900 +0300 +++ new/modules/javafx.graphics/src/main/java/javafx/scene/Node.java 2018-07-31 08:50:19.128816200 +0300 @@ -1861,7 +1861,7 @@ * intersecting with the bounds of this node, else picking is computed * by intersecting with the geometric shape of this node. * - * @defaultValue false + * @defaultValue false, true for {@code Region} */ private BooleanProperty pickOnBounds; --- old/modules/javafx.graphics/src/main/java/javafx/scene/canvas/GraphicsContext.java 2018-07-31 08:50:21.872794900 +0300 +++ new/modules/javafx.graphics/src/main/java/javafx/scene/canvas/GraphicsContext.java 2018-07-31 08:50:21.607795800 +0300 @@ -706,7 +706,7 @@ } buf.putByte(NGCanvas.PATHEND); // Transform needs to be updated for rendering attributes even though - // we have already trasnformed the points as we sent them. + // we have already transformed the points as we sent them. updateTransform(); buf.putByte(command); // Now that we have changed the PG layer path, we need to mark our path dirty. @@ -793,7 +793,7 @@ private void reset() { GrowableDataBuffer buf = getBuffer(); // Only reset if we have a significant amount of data to omit, - // this prevents a common occurence of "setFill(bg); fillRect();" + // this prevents a common occurrence of "setFill(bg); fillRect();" // at the start of a session from invoking a reset. // But, do a reset anyway if the rendering layer has been falling // behind because that lets the synchronization step throw out the @@ -2609,7 +2609,7 @@ /** * Draws an image into the given destination rectangle of the canvas. The - * Image is scaled to fit into the destination rectagnle. + * Image is scaled to fit into the destination rectangle. * A {@code null} image value or an image still in progress will be ignored. *
* This method will be affected by any of the --- old/modules/javafx.graphics/src/main/java/javafx/scene/image/PixelFormat.java 2018-07-31 08:50:24.195854200 +0300 +++ new/modules/javafx.graphics/src/main/java/javafx/scene/image/PixelFormat.java 2018-07-31 08:50:23.918793500 +0300 @@ -209,7 +209,7 @@ *
* Pixels in this format can be decoded using the following sample code: *
{@code
- * int pixel = array[rowstart + x] & 0xff;
+ * int pixel = array[rowstart + x] & 0xff;
* int argb = colors[pixel];
*
* int alpha = ((argb >> 24) & 0xff);
@@ -237,7 +237,7 @@
*
* Pixels in this format can be decoded using the following sample code:
*
{@code
- * int pixel = array[rowstart + x] & 0xff;
+ * int pixel = array[rowstart + x] & 0xff;
* int argb = colors[pixel];
*
* int alpha = ((argb >> 24) & 0xff);
--- old/modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderStroke.java 2018-07-31 08:50:26.370931800 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/layout/BorderStroke.java 2018-07-31 08:50:26.094795000 +0300
@@ -70,7 +70,7 @@
* Defines the fill of top side of this border.
*
* @return the fill of top side of this border
- * @defaultValue black
+ * @defaultValue Color.BLACK
*/
public final Paint getTopStroke() { return topStroke; }
final Paint topStroke;
@@ -79,31 +79,31 @@
// we use inherit. But first I'd like a performance analysis.
/**
- * Defines the fill of right side of this border. If {@code null} then the
+ * Defines the fill of right side of this border. If {@code null}, then the
* topFill is used.
*
* @return the fill of right side of this border
- * @defaultValue null = same as topFill
+ * @defaultValue null (same as topFill)
*/
public final Paint getRightStroke() { return rightStroke; }
final Paint rightStroke;
/**
- * Defines the fill of bottom side of this border. If {@code null} then the
+ * Defines the fill of bottom side of this border. If {@code null}, then the
* topFill is used.
*
* @return the fill of bottom side of this border
- * @defaultValue null = same as topFill
+ * @defaultValue null (same as topFill)
*/
public final Paint getBottomStroke() { return bottomStroke; }
final Paint bottomStroke;
/**
- * Defines the fill of left side of this border. If {@code null} then the
+ * Defines the fill of left side of this border. If {@code null}, then the
* rightFill is used.
*
* @return the fill of left side of this border
- * @defaultValue null = same sa rightFill
+ * @defaultValue null (same as rightFill)
*/
public final Paint getLeftStroke() { return leftStroke; }
final Paint leftStroke;
@@ -112,39 +112,39 @@
* Defines the style of top side of this border.
*
* @return the style of top side of this border
- * @defaultValue none
+ * @defaultValue BorderStrokeStyle.NONE
*/
public final BorderStrokeStyle getTopStyle() { return topStyle; }
final BorderStrokeStyle topStyle;
/**
- * Defines the style of right side of this border. If {@code null} then
+ * Defines the style of right side of this border. If {@code null}, then
* topStyle is used;
*
* @return the style of right side of this border
- * @defaultValue null = same as topStyle
+ * @defaultValue null (same as topStyle)
*/
public final BorderStrokeStyle getRightStyle() { return rightStyle; }
final BorderStrokeStyle rightStyle;
/**
- * Defines the style of bottom side of this border. If {@code null} then
+ * Defines the style of bottom side of this border. If {@code null}, then
* topStyle is used; Use BorderStyle.NONE to set the border to
* have no border style.
*
* @return the style of bottom side of this border
- * @defaultValue null = same as topStyle
+ * @defaultValue null (same as topStyle)
*/
public final BorderStrokeStyle getBottomStyle() { return bottomStyle; }
final BorderStrokeStyle bottomStyle;
/**
- * Defines the style of left side of this border. If {@code null} then
+ * Defines the style of left side of this border. If {@code null}, then
* rightStyle is used. Use BorderStyle.NONE to set the border to
* have no border style.
*
* @return the style of left side of this border
- * @defaultValue null = same as rightStyle
+ * @defaultValue null (same as rightStyle)
*/
public final BorderStrokeStyle getLeftStyle() { return leftStyle; }
final BorderStrokeStyle leftStyle;
@@ -181,9 +181,9 @@
private final CornerRadii radii;
/**
- * An uniform stroke has all (top, bottom, left, right) strokes of
- * same color, width and style
- * @return true if border stroke is uniform as defined above
+ * Checks if the stroke of this region is uniform. A uniform stroke has all its side
+ * strokes (top, bottom, left, right) of same color, width and style.
+ * @return true if border stroke is uniform
*/
public final boolean isStrokeUniform() { return strokeUniform; }
private final boolean strokeUniform;
@@ -196,10 +196,10 @@
/**
* Creates a new BorderStroke.
*
- * @param stroke The stroke to use for all sides. If null, we default to Color.BLACK.
- * @param style The style to use for all sides. If null, we default to BorderStrokeStyle.NONE
- * @param radii The radii to use. If null, we default to CornerRadii.EMPTY
- * @param widths The widths to use. If null, we default to DEFAULT_WIDTHS
+ * @param stroke The stroke to use for all sides. If null, defaults to Color.BLACK.
+ * @param style The style to use for all sides. If null, defaults to BorderStrokeStyle.NONE.
+ * @param radii The radii to use. If null, defaults to CornerRadii.EMPTY.
+ * @param widths The widths to use. If null, defaults to DEFAULT_WIDTHS.
*/
public BorderStroke(@NamedArg("stroke") Paint stroke, @NamedArg("style") BorderStrokeStyle style, @NamedArg("radii") CornerRadii radii, @NamedArg("widths") BorderWidths widths) {
// TODO: Note that we default to THIN, not to MEDIUM as the CSS spec says. So it will be
@@ -238,11 +238,12 @@
/**
* Creates a new BorderStroke.
*
- * @param stroke The stroke to use for all sides. If null, we default to Color.BLACK.
- * @param style The style to use for all sides. If null, we default to BorderStrokeStyle.NONE
- * @param radii The radii to use. If null, we default to CornerRadii.EMPTY
- * @param widths The widths to use. If null, we default to DEFAULT_WIDTHS
+ * @param stroke The stroke to use for all sides. If null, defaults to Color.BLACK.
+ * @param style The style to use for all sides. If null, defaults to BorderStrokeStyle.NONE.
+ * @param radii The radii to use. If null, defaults to CornerRadii.EMPTY.
+ * @param widths The widths to use. If null, defaults to DEFAULT_WIDTHS.
* @param insets The insets indicating where to draw the border relative to the region edges.
+ * If null, defaults to Insets.EMPTY.
*/
public BorderStroke(@NamedArg("stroke") Paint stroke, @NamedArg("style") BorderStrokeStyle style, @NamedArg("radii") CornerRadii radii, @NamedArg("widths") BorderWidths widths, @NamedArg("insets") Insets insets) {
this(stroke, stroke, stroke, stroke, style, style, style, style, radii, widths, insets);
@@ -251,17 +252,18 @@
/**
* Create a new BorderStroke, specifying all construction parameters.
*
- * @param topStroke The fill to use on the top. If null, defaults to BLACK.
- * @param rightStroke The fill to use on the right. If null, defaults to the same value as topStroke
- * @param bottomStroke The fill to use on the bottom. If null, defaults to the same value as bottomStroke
- * @param leftStroke The fill to use on the left. If null, defaults to the same value as rightStroke
- * @param topStyle The style to use on the top. If null, defaults to BorderStrokeStyle.NONE
- * @param rightStyle The style to use on the right. If null, defaults to the same value as topStyle
- * @param bottomStyle The style to use on the bottom. If null, defaults to the same value as topStyle
- * @param leftStyle The style to use on the left. If null, defaults to the same value as rightStyle
- * @param radii The radii. If null, we default to square corners by using CornerRadii.EMPTY
- * @param widths The thickness of each side. If null, we default to DEFAULT_WIDTHS.
- * @param insets The insets indicating where to draw the border relative to the region edges.
+ * @param topStroke The fill to use on the top. If null, defaults to Color.BLACK.
+ * @param rightStroke The fill to use on the right. If null, defaults to the same value as topStroke.
+ * @param bottomStroke The fill to use on the bottom. If null, defaults to the same value as topStroke.
+ * @param leftStroke The fill to use on the left. If null, defaults to the same value as rightStroke.
+ * @param topStyle The style to use on the top. If null, defaults to BorderStrokeStyle.NONE.
+ * @param rightStyle The style to use on the right. If null, defaults to the same value as topStyle.
+ * @param bottomStyle The style to use on the bottom. If null, defaults to the same value as topStyle.
+ * @param leftStyle The style to use on the left. If null, defaults to the same value as rightStyle.
+ * @param radii The radii. If null, defaults to square corners by using CornerRadii.EMPTY.
+ * @param widths The thickness of each side. If null, defaults to DEFAULT_WIDTHS.
+ * @param insets The insets indicating where to draw the border relative to the region edges.
+ * If null, defaults to Insets.EMPTY.
*/
public BorderStroke(
@NamedArg("topStroke") Paint topStroke, @NamedArg("rightStroke") Paint rightStroke, @NamedArg("bottomStroke") Paint bottomStroke, @NamedArg("leftStroke") Paint leftStroke,
--- old/modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java 2018-07-31 08:50:28.523792400 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java 2018-07-31 08:50:28.253800000 +0300
@@ -114,12 +114,10 @@
* By default a Region appears as a Rectangle. A BackgroundFill radii might cause the Rectangle to appear rounded.
* This affects not only making the visuals look like a rounded rectangle, but it also causes the picking behavior
* of the Region to act like a rounded rectangle, such that locations outside the corner radii are ignored. A
- * Region can be made to use any shape, however, by specifing the {@code shape} property. If a shape is specified,
+ * Region can be made to use any shape, however, by specifying the {@code shape} property. If a shape is specified,
* then all BackgroundFills, BackgroundImages, and BorderStrokes will be applied to the shape. BorderImages are
* not used for Regions which have a shape specified.
*
- * A Region with a shape
- *
* Although the layout bounds of a Region are not influenced by any Border or Background, the content area
* insets and the picking area of the Region are. The {@code insets} of the Region define the distance
* between the edge of the layout bounds and the edge of the content area. For example, if the Region
@@ -571,7 +569,7 @@
};
{
- // To initialize the class helper at the begining each constructor of this class
+ // To initialize the class helper at the beginning each constructor of this class
RegionHelper.initHelper(this);
}
--- old/modules/javafx.graphics/src/main/java/javafx/scene/paint/Color.java 2018-07-31 08:50:30.805794200 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/paint/Color.java 2018-07-31 08:50:30.540794500 +0300
@@ -715,7 +715,7 @@
* @param hueShift the hue shift
* @param saturationFactor the saturation factor
* @param brightnessFactor the brightness factor
- * @param opacityFactor the brightness factor
+ * @param opacityFactor the opacity factor
* @return a {@code Color} based based on this {@code Color} with hue,
* saturation, brightness and opacity values altered.
*/
--- old/modules/javafx.graphics/src/main/java/javafx/scene/shape/Mesh.java 2018-07-31 08:50:33.186059700 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/shape/Mesh.java 2018-07-31 08:50:32.919022300 +0300
@@ -67,6 +67,9 @@
});
}
+ /**
+ * A constructor that is called by any {@code Mesh} implementation.
+ */
protected Mesh() {
if (!Platform.isSupported(ConditionalFeature.SCENE3D)) {
String logname = Mesh.class.getName();
--- old/modules/javafx.graphics/src/main/java/javafx/scene/transform/Rotate.java 2018-07-31 08:50:35.352021400 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/transform/Rotate.java 2018-07-31 08:50:35.087022400 +0300
@@ -44,14 +44,12 @@
* intermediate origin is restored to the coordinates of the original
* anchor point (S3).
*
- * For example, the matrix representing the returned transform of
- * new Rotate (theta, x, y, z) around the Z-axis
- *
- * is :
+ * The matrix representing the rotation transformation around an axis {@code (x,y,z)}
+ * by an angle {@code t} is as follows:
*
- * [ cos(theta) -sin(theta) 0 x-x*cos+y*sin ]
- * [ sin(theta) cos(theta) 0 y-x*sin-y*cos ]
- * [ 0 0 1 z ]
+ * [ cos(t) -sin(t) 0 x-x*cos(t)+y*sin(t) ]
+ * [ sin(t) cos(t) 0 y-x*sin(t)-y*cos(t) ]
+ * [ 0 0 1 z ]
*
*
* For example, to rotate a text 30 degrees around the Z-axis at
--- old/modules/javafx.graphics/src/main/java/javafx/scene/transform/Scale.java 2018-07-31 08:50:37.545061600 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/transform/Scale.java 2018-07-31 08:50:37.274023100 +0300
@@ -37,11 +37,12 @@
/**
* This class represents an {@code Affine} object that scales coordinates
* by the specified factors. The matrix representing the scaling transformation
- * is as follows:
+ * around a pivot point {@code (pivotX, pivotY, pivotZ)} with scaling factors
+ * {@code x}, {@code y} and {@code z} is as follows:
*
- * [ x 0 0 (1-x)*pivotX ]
- * [ 0 y 0 (1-y)*pivotY ]
- * [ 0 0 z (1-z)*pivotZ ]
+ * [ x 0 0 (1-x)*pivotX ]
+ * [ 0 y 0 (1-y)*pivotY ]
+ * [ 0 0 z (1-z)*pivotZ ]
*
* @since JavaFX 2.0
*/
--- old/modules/javafx.graphics/src/main/java/javafx/scene/transform/Shear.java 2018-07-31 08:50:39.741400400 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/transform/Shear.java 2018-07-31 08:50:39.474367300 +0300
@@ -36,12 +36,13 @@
/**
* This class represents an {@code Affine} object that shears coordinates
- * by the specified multipliers. The matrix representing the shearing
- * transformation is as follows:
+ * by the specified multipliers. The matrix representing the shearing transformation
+ * around a pivot point {@code (pivotX, pivotY)} with multiplication factors {@code x}
+ * and {@code y} is as follows:
*
- * [ 1 x 0 -x*pivotY ]
- * [ y 1 0 -y*pivotX ]
- * [ 0 0 1 0 ]
+ * [ 1 x 0 -x*pivotY ]
+ * [ y 1 0 -y*pivotX ]
+ * [ 0 0 1 0 ]
*
*
*
--- old/modules/javafx.graphics/src/main/java/javafx/scene/transform/Translate.java 2018-07-31 08:50:41.911557500 +0300
+++ new/modules/javafx.graphics/src/main/java/javafx/scene/transform/Translate.java 2018-07-31 08:50:41.647555200 +0300
@@ -37,11 +37,11 @@
/**
* This class represents an {@code Affine} object that translates coordinates
* by the specified factors. The matrix representing the translating
- * transformation is as follows:
+ * transformation by distances {@code x}, {@code y} and {@code z} is as follows:
*
- * [ 1 0 0 x ]
- * [ 0 1 0 y ]
- * [ 0 0 1 z ]
+ * [ 1 0 0 x ]
+ * [ 0 1 0 y ]
+ * [ 0 0 1 z ]
*
* @since JavaFX 2.0
*/