--- old/src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java 2016-04-13 14:14:45.341571376 +0000 +++ new/src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java 2016-04-13 14:14:45.036542874 +0000 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -3519,9 +3519,7 @@ return false; } String gmtText = "GMT"; // TODO: get localized version of 'GMT' - if (gmtText != null) { - buf.append(gmtText); - } + buf.append(gmtText); int totalSecs = Math.toIntExact(offsetSecs); if (totalSecs != 0) { int absHours = Math.abs((totalSecs / 3600) % 100); // anything larger than 99 silently dropped @@ -3565,14 +3563,12 @@ @Override public int parse(DateTimeParseContext context, CharSequence text, int position) { int pos = position; - int end = pos + text.length(); + int end = text.length(); String gmtText = "GMT"; // TODO: get localized version of 'GMT' - if (gmtText != null) { - if (!context.subSequenceEquals(text, pos, gmtText, 0, gmtText.length())) { + if (!context.subSequenceEquals(text, pos, gmtText, 0, gmtText.length())) { return ~position; } - pos += gmtText.length(); - } + pos += gmtText.length(); // parse normal plus/minus offset int negative = 0; if (pos == end) { --- /dev/null 2016-03-15 05:02:07.856000000 +0000 +++ new/test/java/time/tck/java/time/format/TCKLocalizedOffsetIdPrinterParser.java 2016-04-13 14:14:45.960629222 +0000 @@ -0,0 +1,53 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +package tck.java.time.format; + +import java.time.ZoneOffset; +import java.time.ZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.util.Locale; + +import org.testng.annotations.DataProvider; +import org.testng.annotations.Test; + +/** + * Test localized behavior of formatter. + */ +@Test +public class TCKLocalizedOffsetIdPrinterParser { + @DataProvider(name = "localized_offset_pattern") + Object[][] data_print_localized_offset() { + return new Object[][]{ + {"yyyy-MM-dd'T'HH:mm:ss.S O"}, + {"yyyy-MM-dd'T'HH:mm:ss.S OOOO"}, + }; + } + + @Test(dataProvider = "localized_offset_pattern") + public void test_localized_offset_parse(String pattern) { + DateTimeFormatter formatter = DateTimeFormatter.ofPattern(pattern) + .withLocale(Locale.ENGLISH); + String date = formatter.format(ZonedDateTime.now(ZoneOffset.UTC)); + formatter.parse(date) ; + } +}