Code Review for open

Prepared by:pliden on Wed Apr 11 11:33:07 CEST 2018
Workspace:/home/pliden/openjdk/repos/jdk/hs/open
Compare against version:-2
Summary of changes: 542 lines changed: 246 ins; 168 del; 128 mod; 92801 unchg
Patch of changes: open.patch
Bug id: JDK-8201318 : Introduce GCThreadLocalData to abstract GC-specific data belonging to a thread
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/c1_Runtime1_aarch64.cpp

12 lines changed: 1 ins; 6 del; 5 mod; 1260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp

11 lines changed: 1 ins; 5 del; 5 mod; 5825 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/c1_Runtime1_arm.cpp

11 lines changed: 1 ins; 5 del; 5 mod; 1196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/macroAssembler_arm.cpp

11 lines changed: 1 ins; 5 del; 5 mod; 3254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/c1_Runtime1_ppc.cpp

16 lines changed: 1 ins; 10 del; 5 mod; 1001 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp

3 lines changed: 1 ins; 0 del; 2 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/macroAssembler_ppc.cpp

9 lines changed: 1 ins; 0 del; 8 mod; 5361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/c1_Runtime1_s390.cpp

14 lines changed: 1 ins; 8 del; 5 mod; 1060 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp

4 lines changed: 1 ins; 2 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/macroAssembler_s390.cpp

6 lines changed: 1 ins; 0 del; 5 mod; 7466 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/sparc/c1_Runtime1_sparc.cpp

16 lines changed: 1 ins; 10 del; 5 mod; 1052 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp

6 lines changed: 1 ins; 2 del; 3 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

25 lines changed: 1 ins; 16 del; 8 mod; 5039 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/c1_Runtime1_x86.cpp

11 lines changed: 1 ins; 5 del; 5 mod; 1740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp

4 lines changed: 1 ins; 2 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

11 lines changed: 1 ins; 5 del; 5 mod; 11271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

5 lines changed: 1 ins; 3 del; 1 mod; 3785 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/dirtyCardQueue.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BarrierSet.cpp

23 lines changed: 11 ins; 3 del; 9 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1BarrierSet.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 5169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 2952 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/satbMarkQueue.cpp

8 lines changed: 1 ins; 0 del; 7 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/vmStructs_g1.hpp

4 lines changed: 0 ins; 3 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/barrierSet.cpp

12 lines changed: 11 ins; 0 del; 1 mod; 27 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/barrierSet.hpp

7 lines changed: 3 ins; 2 del; 2 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

1 line changed: 0 ins; 0 del; 1 mod; 634 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVM.hpp

1 line changed: 0 ins; 0 del; 1 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciRuntime.cpp

9 lines changed: 7 ins; 0 del; 2 mod; 894 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/vmStructs_jvmci.cpp

16 lines changed: 6 ins; 9 del; 1 mod; 986 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

4 lines changed: 3 ins; 0 del; 1 mod; 4644 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

7 lines changed: 3 ins; 2 del; 2 mod; 3532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

13 lines changed: 3 ins; 5 del; 5 mod; 4527 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

5 lines changed: 3 ins; 1 del; 1 mod; 2798 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

5 lines changed: 3 ins; 0 del; 2 mod; 3149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

30 lines changed: 17 ins; 11 del; 2 mod; 4984 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

42 lines changed: 17 ins; 25 del; 0 mod; 2194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

1 line changed: 0 ins; 0 del; 1 mod; 3193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java

28 lines changed: 0 ins; 23 del; 5 mod; 813 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java

5 lines changed: 0 ins; 0 del; 5 mod; 1020 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1ThreadLocalData.hpp

94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/gcThreadLocalData.hpp

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/pliden/openjdk/tools/webrev/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).