Code Review for open

Prepared by:pliden on Mon May 18 23:08:39 CEST 2020
Workspace:/home/pliden/openjdk/repos/jdk/open
Compare against version:-2
Summary of changes: 1496 lines changed: 735 ins; 334 del; 427 mod; 6847 unchg
Patch of changes: open.patch
Bug id: JDK-8245208 : ZGC: Don't hold the ZPageAllocator lock while committing/uncommitting memory
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.cpp

10 lines changed: 3 ins; 0 del; 7 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.cpp

28 lines changed: 3 ins; 0 del; 25 mod; 695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.hpp

16 lines changed: 0 ins; 0 del; 16 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zMapper_windows.cpp

6 lines changed: 3 ins; 0 del; 3 mod; 251 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zMapper_windows.hpp

1 line changed: 0 ins; 0 del; 1 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.cpp

11 lines changed: 8 ins; 0 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/vmStructs_z.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zAllocationFlags.hpp

24 lines changed: 11 ins; 0 del; 13 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zDirector.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zFuture.hpp

2 lines changed: 0 ins; 1 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zFuture.inline.hpp

6 lines changed: 0 ins; 5 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.cpp

8 lines changed: 4 ins; 0 del; 4 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.hpp

3 lines changed: 1 ins; 0 del; 2 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMemory.cpp

12 lines changed: 11 ins; 0 del; 1 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMemory.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.cpp

21 lines changed: 20 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.hpp

8 lines changed: 3 ins; 4 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.inline.hpp

17 lines changed: 4 ins; 11 del; 2 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.cpp

613 lines changed: 233 ins; 180 del; 200 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.hpp

38 lines changed: 10 ins; 6 del; 22 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageCache.cpp

116 lines changed: 99 ins; 13 del; 4 mod; 248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageCache.hpp

20 lines changed: 2 ins; 15 del; 3 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.cpp

334 lines changed: 222 ins; 48 del; 64 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.hpp

33 lines changed: 19 ins; 4 del; 10 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.inline.hpp

16 lines changed: 10 ins; 0 del; 6 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zUncommitter.cpp

8 lines changed: 4 ins; 2 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zVirtualMemory.cpp

6 lines changed: 1 ins; 1 del; 4 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zVirtualMemory.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/metadata/metadata.xml

6 lines changed: 2 ins; 4 del; 0 mod; 1331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/z/test_zForwarding.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp

73 lines changed: 60 ins; 0 del; 13 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/z/TestUncommit.java

6 lines changed: 0 ins; 5 del; 1 mod; 128 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/z/zPageCache.inline.hpp

35 lines changed: 0 ins; 35 del; 0 mod; 0 unchg

This code review page was prepared using /home/pliden/openjdk/tools/webrev/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).