Code Review for open

Prepared by:pliden on Thu Mar 14 00:02:36 CET 2019
Workspace:/home/pliden/openjdk/repos/jdk/open
Compare against version:zverifyviews
Summary of changes: 1646 lines changed: 598 ins; 728 del; 320 mod; 5845 unchg
Patch of changes: open.patch
Bug id: zgc/zpage_life_cycle
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/vmStructs_z.hpp

13 lines changed: 4 ins; 3 del; 6 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zBarrier.cpp

17 lines changed: 0 ins; 14 del; 3 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zDebug.gdb

5 lines changed: 0 ins; 0 del; 5 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zDriver.cpp

22 lines changed: 0 ins; 18 del; 4 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zDriver.hpp

2 lines changed: 0 ins; 2 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwardingTable.cpp

57 lines changed: 4 ins; 40 del; 13 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwardingTable.hpp

23 lines changed: 1 ins; 16 del; 6 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwardingTable.inline.hpp

79 lines changed: 0 ins; 75 del; 4 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zGranuleMap.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zGranuleMap.inline.hpp

22 lines changed: 22 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.cpp

90 lines changed: 17 ins; 52 del; 21 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.hpp

11 lines changed: 2 ins; 6 del; 3 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.inline.hpp

43 lines changed: 35 ins; 4 del; 4 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMark.cpp

3 lines changed: 0 ins; 0 del; 3 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMark.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodData.cpp

18 lines changed: 1 ins; 11 del; 6 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodData.hpp

11 lines changed: 5 ins; 4 del; 2 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodTable.cpp

17 lines changed: 1 ins; 9 del; 7 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zNMethodTable.hpp

7 lines changed: 2 ins; 0 del; 5 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.cpp

111 lines changed: 0 ins; 107 del; 4 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.hpp

25 lines changed: 2 ins; 22 del; 1 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.inline.hpp

58 lines changed: 6 ins; 49 del; 3 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.cpp

36 lines changed: 13 ins; 18 del; 5 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.hpp

9 lines changed: 4 ins; 2 del; 3 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageCache.cpp

5 lines changed: 0 ins; 4 del; 1 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageTable.cpp

54 lines changed: 1 ins; 43 del; 10 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageTable.hpp

13 lines changed: 1 ins; 8 del; 4 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageTable.inline.hpp

13 lines changed: 0 ins; 7 del; 6 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocate.cpp

88 lines changed: 78 ins; 0 del; 10 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocate.hpp

8 lines changed: 7 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSet.cpp

27 lines changed: 11 ins; 0 del; 16 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSet.hpp

8 lines changed: 2 ins; 0 del; 6 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSet.inline.hpp

8 lines changed: 0 ins; 0 del; 8 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSetSelector.cpp

12 lines changed: 0 ins; 0 del; 12 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRelocationSetSelector.hpp

15 lines changed: 0 ins; 0 del; 15 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHeap.java

1 line changed: 0 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList-zgc.txt

12 lines changed: 11 ins; 0 del; 1 mod; 29 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/z/zAttachedArray.hpp

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/z/zAttachedArray.inline.hpp

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwarding.cpp (was src/hotspot/share/gc/z/zForwardingTable.cpp)

46 lines changed: 12 ins; 15 del; 19 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwarding.hpp (was src/hotspot/share/gc/z/zForwardingTable.hpp)

51 lines changed: 28 ins; 6 del; 17 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwarding.inline.hpp (was src/hotspot/share/gc/z/zForwardingTable.inline.hpp)

85 lines changed: 56 ins; 4 del; 25 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwardingEntry.hpp (was src/hotspot/share/gc/z/zForwardingTableEntry.hpp)

14 lines changed: 0 ins; 0 del; 14 mod; 83 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/z/zSafeDelete.hpp

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/z/zSafeDelete.inline.hpp

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/z/test_zForwarding.cpp (was test/hotspot/gtest/gc/z/test_zForwardingTable.cpp)

68 lines changed: 23 ins; 1 del; 44 mod; 140 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/z/zNMethodAllocator.cpp

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/z/zNMethodAllocator.hpp

46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/z/zPageTableEntry.hpp

73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

This code review page was prepared using /home/pliden/openjdk/tools/webrev/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).