src/share/vm/gc/g1/heapRegion.cpp

Print this page

        

*** 603,614 **** st->print(" PTAMS " PTR_FORMAT " NTAMS " PTR_FORMAT, p2i(prev_top_at_mark_start()), p2i(next_top_at_mark_start())); G1OffsetTableContigSpace::print_on(st); } ! class VerifyLiveClosure: public OopClosure { ! private: G1CollectedHeap* _g1h; CardTableModRefBS* _bs; oop _containing_obj; bool _failures; int _n_failures; --- 603,614 ---- st->print(" PTAMS " PTR_FORMAT " NTAMS " PTR_FORMAT, p2i(prev_top_at_mark_start()), p2i(next_top_at_mark_start())); G1OffsetTableContigSpace::print_on(st); } ! class HeapRegionVerifyClosure : public OopClosure { ! protected: G1CollectedHeap* _g1h; CardTableModRefBS* _bs; oop _containing_obj; bool _failures; int _n_failures;
*** 615,625 **** VerifyOption _vo; public: // _vo == UsePrevMarking -> use "prev" marking information, // _vo == UseNextMarking -> use "next" marking information, // _vo == UseMarkWord -> use mark word from object header. ! VerifyLiveClosure(G1CollectedHeap* g1h, VerifyOption vo) : _g1h(g1h), _bs(barrier_set_cast<CardTableModRefBS>(g1h->barrier_set())), _containing_obj(NULL), _failures(false), _n_failures(0), _vo(vo) { } void set_containing_obj(oop obj) { --- 615,625 ---- VerifyOption _vo; public: // _vo == UsePrevMarking -> use "prev" marking information, // _vo == UseNextMarking -> use "next" marking information, // _vo == UseMarkWord -> use mark word from object header. ! HeapRegionVerifyClosure(G1CollectedHeap* g1h, VerifyOption vo) : _g1h(g1h), _bs(barrier_set_cast<CardTableModRefBS>(g1h->barrier_set())), _containing_obj(NULL), _failures(false), _n_failures(0), _vo(vo) { } void set_containing_obj(oop obj) {
*** 627,639 **** } bool failures() { return _failures; } int n_failures() { return _n_failures; } - virtual void do_oop(narrowOop* p) { do_oop_work(p); } - virtual void do_oop( oop* p) { do_oop_work(p); } - void print_object(outputStream* out, oop obj) { #ifdef PRODUCT Klass* k = obj->klass(); const char* class_name = k->external_name(); out->print_cr("class name %s", class_name); --- 627,636 ----
*** 641,699 **** obj->print_on(out); #endif // PRODUCT } template <class T> ! void do_oop_work(T* p) { ! assert(_containing_obj != NULL, "Precondition"); ! assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), ! "Precondition"); T heap_oop = oopDesc::load_heap_oop(p); if (!oopDesc::is_null(heap_oop)) { oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); bool failed = false; - if (!_g1h->is_in_closed_subset(obj) || _g1h->is_obj_dead_cond(obj, _vo)) { - MutexLockerEx x(ParGCRareEvent_lock, - Mutex::_no_safepoint_check_flag); - if (!_failures) { - gclog_or_tty->cr(); - gclog_or_tty->print_cr("----------"); - } - if (!_g1h->is_in_closed_subset(obj)) { HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); - gclog_or_tty->print_cr("Field " PTR_FORMAT - " of live obj " PTR_FORMAT " in region " - "[" PTR_FORMAT ", " PTR_FORMAT ")", - p2i(p), p2i(_containing_obj), - p2i(from->bottom()), p2i(from->end())); - print_object(gclog_or_tty, _containing_obj); - gclog_or_tty->print_cr("points to obj " PTR_FORMAT " not in the heap", - p2i(obj)); - } else { - HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); - HeapRegion* to = _g1h->heap_region_containing((HeapWord*)obj); - gclog_or_tty->print_cr("Field " PTR_FORMAT - " of live obj " PTR_FORMAT " in region " - "[" PTR_FORMAT ", " PTR_FORMAT ")", - p2i(p), p2i(_containing_obj), - p2i(from->bottom()), p2i(from->end())); - print_object(gclog_or_tty, _containing_obj); - gclog_or_tty->print_cr("points to dead obj " PTR_FORMAT " in region " - "[" PTR_FORMAT ", " PTR_FORMAT ")", - p2i(obj), p2i(to->bottom()), p2i(to->end())); - print_object(gclog_or_tty, obj); - } - gclog_or_tty->print_cr("----------"); - gclog_or_tty->flush(); - _failures = true; - failed = true; - _n_failures++; - } - - if (!_g1h->collector_state()->full_collection() || G1VerifyRSetsDuringFullGC) { - HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); HeapRegion* to = _g1h->heap_region_containing(obj); if (from != NULL && to != NULL && from != to && !to->is_pinned()) { jbyte cv_obj = *_bs->byte_for_const(_containing_obj); --- 638,654 ---- obj->print_on(out); #endif // PRODUCT } template <class T> ! void verifyRemSets(T* p) { T heap_oop = oopDesc::load_heap_oop(p); if (!oopDesc::is_null(heap_oop)) { oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); bool failed = false; HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); HeapRegion* to = _g1h->heap_region_containing(obj); if (from != NULL && to != NULL && from != to && !to->is_pinned()) { jbyte cv_obj = *_bs->byte_for_const(_containing_obj);
*** 734,746 **** --- 689,780 ---- if (!failed) _n_failures++; } } } } + }; + + class VerifyRSetClosure : public HeapRegionVerifyClosure { + + public: + VerifyRSetClosure(G1CollectedHeap* g1h, VerifyOption vo) : HeapRegionVerifyClosure(g1h, vo) { } + + virtual void do_oop(narrowOop* p) { do_oop_work(p); } + virtual void do_oop(oop* p) { do_oop_work(p); } + + template <class T> + void do_oop_work(T* p) { + assert(_containing_obj != NULL, "Precondition"); + assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), + "Precondition"); + + verifyRemSets(p); } }; + class VerifyLiveClosure : public HeapRegionVerifyClosure { + public: + VerifyLiveClosure(G1CollectedHeap* g1h, VerifyOption vo) : HeapRegionVerifyClosure(g1h, vo) { } + + virtual void do_oop(narrowOop* p) { do_oop_work(p); } + virtual void do_oop( oop* p) { do_oop_work(p); } + + template <class T> + void do_oop_work(T* p) { + assert(_containing_obj != NULL, "Precondition"); + assert(!_g1h->is_obj_dead_cond(_containing_obj, _vo), + "Precondition"); + T heap_oop = oopDesc::load_heap_oop(p); + if (!oopDesc::is_null(heap_oop)) { + oop obj = oopDesc::decode_heap_oop_not_null(heap_oop); + bool failed = false; + if (!_g1h->is_in_closed_subset(obj) || _g1h->is_obj_dead_cond(obj, _vo)) { + MutexLockerEx x(ParGCRareEvent_lock, + Mutex::_no_safepoint_check_flag); + + if (!_failures) { + gclog_or_tty->cr(); + gclog_or_tty->print_cr("----------"); + } + if (!_g1h->is_in_closed_subset(obj)) { + HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); + gclog_or_tty->print_cr("Field " PTR_FORMAT + " of live obj " PTR_FORMAT " in region " + "[" PTR_FORMAT ", " PTR_FORMAT ")", + p2i(p), p2i(_containing_obj), + p2i(from->bottom()), p2i(from->end())); + print_object(gclog_or_tty, _containing_obj); + gclog_or_tty->print_cr("points to obj " PTR_FORMAT " not in the heap", + p2i(obj)); + } else { + HeapRegion* from = _g1h->heap_region_containing((HeapWord*)p); + HeapRegion* to = _g1h->heap_region_containing((HeapWord*)obj); + gclog_or_tty->print_cr("Field " PTR_FORMAT + " of live obj " PTR_FORMAT " in region " + "[" PTR_FORMAT ", " PTR_FORMAT ")", + p2i(p), p2i(_containing_obj), + p2i(from->bottom()), p2i(from->end())); + print_object(gclog_or_tty, _containing_obj); + gclog_or_tty->print_cr("points to dead obj " PTR_FORMAT " in region " + "[" PTR_FORMAT ", " PTR_FORMAT ")", + p2i(obj), p2i(to->bottom()), p2i(to->end())); + print_object(gclog_or_tty, obj); + } + gclog_or_tty->print_cr("----------"); + gclog_or_tty->flush(); + _failures = true; + failed = true; + _n_failures++; + } + + if (!_g1h->collector_state()->full_collection() || G1VerifyRSetsDuringFullGC) { + verifyRemSets(p); + } + } + } + }; + // This really ought to be commoned up into OffsetTableContigSpace somehow. // We would need a mechanism to make that code skip dead objects. void HeapRegion::verify(VerifyOption vo, bool* failures) const {
*** 872,881 **** --- 906,950 ---- void HeapRegion::verify() const { bool dummy = false; verify(VerifyOption_G1UsePrevMarking, /* failures */ &dummy); } + void HeapRegion::verifyRSet(VerifyOption vo, + bool* failures) const { + G1CollectedHeap* g1 = G1CollectedHeap::heap(); + *failures = false; + HeapWord* p = bottom(); + HeapWord* prev_p = NULL; + VerifyRSetClosure v_rset_cl(g1, vo); + bool is_region_humongous = is_humongous(); + while (p < top()) { + oop obj = oop(p); + size_t obj_size = block_size(p); + + if (!g1->is_obj_dead_cond(obj, this, vo)) { + if (obj->is_oop()) { + v_rset_cl.set_containing_obj(obj); + obj->oop_iterate_no_header(&v_rset_cl); + if (v_rset_cl.failures()) { + *failures = true; + } + if (G1MaxVerifyFailures >= 0 && + v_rset_cl.n_failures() >= G1MaxVerifyFailures) { + return; + } + } + else { + gclog_or_tty->print_cr(PTR_FORMAT " not an oop", p2i(obj)); + *failures = true; + return; + } + } + prev_p = p; + p += obj_size; + } + } + void HeapRegion::prepare_for_compaction(CompactPoint* cp) { scan_and_forward(this, cp); } // G1OffsetTableContigSpace code; copied from space.cpp. Hope this can go