Code Review for jdk

Prepared by:prappo on Thu Jun 26 18:55:37 IST 2014
Workspace:/Users/pavelrappo/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:10194
Summary of changes: 149 lines changed: 0 ins; 1 del; 148 mod; 40558 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/imageio/plugins/gif/GIFImageReader.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 1083 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
3 lines changed: 0 ins; 0 del; 3 mod; 1828 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jmx/snmp/SnmpCounter64.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jmx/snmp/SnmpInt.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jmx/snmp/agent/SnmpMibGroup.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 519 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jmx/snmp/daemon/SnmpAdaptorServer.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
19 lines changed: 0 ins; 0 del; 19 mod; 2727 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/jndi/ldap/NamingEventNotifier.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
4 lines changed: 0 ins; 0 del; 4 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/security/auth/SolarisNumericGroupPrincipal.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/security/auth/SolarisNumericUserPrincipal.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/security/auth/UnixNumericGroupPrincipal.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/security/auth/UnixNumericUserPrincipal.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/example/debug/tty/Commands.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 2105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/hat/internal/model/JavaLazyReadObject.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/hat/internal/model/Snapshot.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 629 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
6 lines changed: 0 ins; 0 del; 6 mod; 886 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/hat/internal/server/RefsByTypeQuery.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
4 lines changed: 0 ins; 0 del; 4 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
5 lines changed: 0 ins; 0 del; 5 mod; 1437 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/awt/image/renderable/ParameterBlock.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 726 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/text/DecimalFormat.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 4189 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/management/loading/MLet.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 1337 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/management/modelmbean/RequiredModelMBean.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 3005 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 2257 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 2524 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 1656 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 1198 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 1 del; 1 mod; 567 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/jvmstat/perfdata/monitor/PerfLongMonitor.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/GcInfoCompositeData.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
4 lines changed: 0 ins; 0 del; 4 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/HotspotThread.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/MemoryNotifInfoCompositeData.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/MemoryUsageCompositeData.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
4 lines changed: 0 ins; 0 del; 4 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/ThreadInfoCompositeData.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
6 lines changed: 0 ins; 0 del; 6 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/counter/perf/LongCounterSnapshot.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/counter/perf/PerfLongCounter.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmClassLoadingImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
3 lines changed: 0 ins; 0 del; 3 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmCompilationImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmMemGCEntryImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolEntryImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
15 lines changed: 0 ins; 0 del; 15 mod; 491 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmMemoryImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
11 lines changed: 0 ins; 0 del; 11 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmRuntimeImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmThreadInstanceEntryImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
6 lines changed: 0 ins; 0 del; 6 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/management/snmp/jvminstr/JvmThreadingImpl.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
5 lines changed: 0 ins; 0 del; 5 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/nio/ch/Util.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/action/GetLongAction.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/jgss/wrapper/GSSNameElement.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/krb5/internal/KerberosTime.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/security/tools/keytool/Main.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 4236 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/tools/java/BinaryConstantPool.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/tools/tree/BitNotExpression.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/tools/tree/IncDecExpression.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
1 line changed: 0 ins; 0 del; 1 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/tools/tree/LongExpression.java

rev 10195 : 8048267: Replace uses of 'new Long()' with appropriate alternative across core classes
Reviewed-by: chegar, psandoz
Contributed-by: Otavio Santana <otaviojava@java.net>
2 lines changed: 0 ins; 0 del; 2 mod; 81 unchg

This code review page was prepared using /Users/pavelrappo/code-tools/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).