Code Review for open

Prepared by:prr on Thu Nov 30 10:47:23 PST 2017
Workspace:/home/prrace/jdk10-client/hbjdk/open
Compare against: http://hg.openjdk.java.net/jdk/client
Summary of changes: 12553 lines changed: 5413 ins; 1303 del; 5837 mod; 43609 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Awt2dLibraries.gmk

1 line changed: 0 ins; 0 del; 1 mod; 1074 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh

6 lines changed: 0 ins; 0 del; 6 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc

30 lines changed: 9 ins; 8 del; 13 mod; 457 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-json.hh

374 lines changed: 0 ins; 0 del; 374 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-text.hh

247 lines changed: 0 ins; 0 del; 247 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh

96 lines changed: 84 ins; 5 del; 7 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc

36 lines changed: 15 ins; 1 del; 20 mod; 433 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc

241 lines changed: 200 ins; 10 del; 31 mod; 1777 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h

63 lines changed: 59 ins; 0 del; 4 mod; 468 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc

487 lines changed: 448 ins; 6 del; 33 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.h

59 lines changed: 44 ins; 14 del; 1 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc

205 lines changed: 101 ins; 38 del; 66 mod; 1206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.h

1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-deprecated.h

4 lines changed: 4 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh

8 lines changed: 4 ins; 0 del; 4 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc

99 lines changed: 50 ins; 17 del; 32 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h

5 lines changed: 5 ins; 0 del; 0 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-fallback-shape.cc

7 lines changed: 6 ins; 0 del; 1 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh

2 lines changed: 2 ins; 0 del; 0 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.cc

399 lines changed: 203 ins; 55 del; 141 mod; 1502 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h

28 lines changed: 27 ins; 0 del; 1 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc

112 lines changed: 41 ins; 16 del; 55 mod; 673 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.h

7 lines changed: 6 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh

1 line changed: 0 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh

9 lines changed: 1 ins; 7 del; 1 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh

41 lines changed: 21 ins; 9 del; 11 mod; 248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh

199 lines changed: 144 ins; 29 del; 26 mod; 1012 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cbdt-table.hh

33 lines changed: 0 ins; 0 del; 33 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh

4 lines changed: 0 ins; 0 del; 4 mod; 531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc

194 lines changed: 109 ins; 44 del; 41 mod; 577 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh

5 lines changed: 0 ins; 2 del; 3 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh

33 lines changed: 11 ins; 7 del; 15 mod; 1691 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh

5 lines changed: 0 ins; 0 del; 5 mod; 454 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh

7 lines changed: 6 ins; 0 del; 1 mod; 1653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh

6 lines changed: 3 ins; 0 del; 3 mod; 1366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh

225 lines changed: 99 ins; 56 del; 70 mod; 2203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-jstf-table.hh

2 lines changed: 0 ins; 0 del; 2 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh

31 lines changed: 17 ins; 3 del; 11 mod; 607 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc

62 lines changed: 31 ins; 3 del; 28 mod; 1200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh

25 lines changed: 12 ins; 0 del; 13 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc

18 lines changed: 10 ins; 1 del; 7 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh

4 lines changed: 2 ins; 0 del; 2 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh

7 lines changed: 0 ins; 0 del; 7 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-table.hh

16 lines changed: 3 ins; 0 del; 13 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc

113 lines changed: 87 ins; 7 del; 19 mod; 598 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-default.cc

12 lines changed: 1 ins; 1 del; 10 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hangul.cc

23 lines changed: 7 ins; 1 del; 15 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc

10 lines changed: 1 ins; 1 del; 8 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh

1319 lines changed: 2 ins; 0 del; 1317 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh

6 lines changed: 1 ins; 0 del; 5 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc

47 lines changed: 2 ins; 0 del; 45 mod; 439 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc

79 lines changed: 45 ins; 1 del; 33 mod; 1786 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh

219 lines changed: 4 ins; 0 del; 215 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc

30 lines changed: 5 ins; 3 del; 22 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh

42 lines changed: 24 ins; 2 del; 16 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-thai.cc

19 lines changed: 2 ins; 1 del; 16 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc

11 lines changed: 1 ins; 1 del; 9 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh

250 lines changed: 9 ins; 0 del; 241 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh

2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc

77 lines changed: 35 ins; 0 del; 42 mod; 692 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc

35 lines changed: 3 ins; 23 del; 9 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc

4 lines changed: 3 ins; 0 del; 1 mod; 552 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc

55 lines changed: 27 ins; 11 del; 17 mod; 387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh

4 lines changed: 2 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc

122 lines changed: 76 ins; 29 del; 17 mod; 864 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc

103 lines changed: 83 ins; 13 del; 7 mod; 1004 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot.h

1 line changed: 1 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh

527 lines changed: 170 ins; 297 del; 60 mod; 667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh

427 lines changed: 192 ins; 121 del; 114 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc

54 lines changed: 17 ins; 14 del; 23 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.h

3 lines changed: 0 ins; 3 del; 0 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.cc

73 lines changed: 14 ins; 21 del; 38 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.cc

253 lines changed: 0 ins; 248 del; 5 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.h

16 lines changed: 0 ins; 16 del; 0 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh

24 lines changed: 16 ins; 0 del; 8 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.cc

3 lines changed: 0 ins; 0 del; 3 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn.cc

49 lines changed: 33 ins; 3 del; 13 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.c

46 lines changed: 13 ins; 12 del; 21 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.h

21 lines changed: 7 ins; 14 del; 0 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh

19 lines changed: 3 ins; 2 del; 14 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.cc

36 lines changed: 7 ins; 7 del; 22 mod; 534 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh

9 lines changed: 0 ins; 0 del; 9 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h

2 lines changed: 0 ins; 0 del; 2 mod; 64 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh

419 lines changed: 419 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh

389 lines changed: 389 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-macroman.hh

294 lines changed: 294 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh

276 lines changed: 276 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh

149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh

209 lines changed: 209 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh

114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.cc

159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.h

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh

144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn_db.h (was src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/unicodedata_db.h)

2221 lines changed: 72 ins; 46 del; 2103 mod; 3365 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cache-private.hh

74 lines changed: 0 ins; 74 del; 0 mod; 0 unchg

This code review page was prepared using /home/prrace/bin/webrev (vers 25.14-hg+openjdk.java.net).