Code Review for open

Prepared by:prr on Tue May 29 12:21:00 PDT 2018
Workspace:/home/prrace/jdk-hb/open
Compare against: ssh://hg.openjdk.java.net/jdk/client
Summary of changes: 9266 lines changed: 5572 ins; 1432 del; 2262 mod; 36386 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh

46 lines changed: 23 ins; 23 del; 0 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc

27 lines changed: 25 ins; 0 del; 2 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.h

4 lines changed: 3 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh

53 lines changed: 26 ins; 13 del; 14 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc

27 lines changed: 18 ins; 0 del; 9 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc

3 lines changed: 2 ins; 0 del; 1 mod; 2007 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h

37 lines changed: 31 ins; 0 del; 6 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc

4 lines changed: 1 ins; 0 del; 3 mod; 1046 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc

82 lines changed: 52 ins; 24 del; 6 mod; 1343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.h

3 lines changed: 3 ins; 0 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh

34 lines changed: 25 ins; 0 del; 9 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh

4 lines changed: 0 ins; 4 del; 0 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc

3 lines changed: 0 ins; 0 del; 3 mod; 509 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h

1 line changed: 0 ins; 1 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh

7 lines changed: 6 ins; 0 del; 1 mod; 554 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h

1 line changed: 0 ins; 0 del; 1 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc

16 lines changed: 14 ins; 0 del; 2 mod; 767 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh

97 lines changed: 92 ins; 0 del; 5 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh

124 lines changed: 64 ins; 8 del; 52 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh

321 lines changed: 261 ins; 7 del; 53 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc

458 lines changed: 1 ins; 447 del; 10 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-glyf-table.hh

394 lines changed: 372 ins; 3 del; 19 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-head-table.hh

18 lines changed: 2 ins; 2 del; 14 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hhea-table.hh

17 lines changed: 0 ins; 5 del; 12 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh

238 lines changed: 229 ins; 3 del; 6 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh

29 lines changed: 6 ins; 1 del; 22 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh

151 lines changed: 58 ins; 2 del; 91 mod; 1624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh

11 lines changed: 0 ins; 0 del; 11 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh

132 lines changed: 8 ins; 14 del; 110 mod; 1536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh

73 lines changed: 6 ins; 14 del; 53 mod; 1305 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh

136 lines changed: 6 ins; 4 del; 126 mod; 2242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh

55 lines changed: 48 ins; 0 del; 7 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc

70 lines changed: 54 ins; 0 del; 16 mod; 1243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.h

17 lines changed: 17 ins; 0 del; 0 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh

6 lines changed: 0 ins; 1 del; 5 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc

4 lines changed: 0 ins; 1 del; 3 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-maxp-table.hh

84 lines changed: 77 ins; 1 del; 6 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh

9 lines changed: 0 ins; 0 del; 9 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-table.hh

112 lines changed: 76 ins; 0 del; 36 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh

16 lines changed: 6 ins; 0 del; 10 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh

14 lines changed: 0 ins; 12 del; 2 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-win1256.hh

16 lines changed: 0 ins; 0 del; 16 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc

34 lines changed: 22 ins; 5 del; 7 mod; 692 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc

1 line changed: 0 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh

1237 lines changed: 49 ins; 296 del; 892 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh

231 lines changed: 212 ins; 1 del; 18 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc

4 lines changed: 2 ins; 2 del; 0 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc

325 lines changed: 0 ins; 295 del; 30 mod; 1539 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh

163 lines changed: 42 ins; 33 del; 88 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc

157 lines changed: 5 ins; 151 del; 1 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh

4 lines changed: 2 ins; 1 del; 1 mod; 394 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh

301 lines changed: 51 ins; 8 del; 242 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc

50 lines changed: 21 ins; 2 del; 27 mod; 740 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc

2 lines changed: 0 ins; 0 del; 2 mod; 610 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc

14 lines changed: 4 ins; 1 del; 9 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc

27 lines changed: 13 ins; 11 del; 3 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc

20 lines changed: 13 ins; 0 del; 7 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc

1 line changed: 0 ins; 0 del; 1 mod; 1093 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh

11 lines changed: 0 ins; 0 del; 11 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh

4 lines changed: 0 ins; 0 del; 4 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh

5 lines changed: 0 ins; 0 del; 5 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh

268 lines changed: 192 ins; 13 del; 63 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh

37 lines changed: 35 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh

252 lines changed: 199 ins; 14 del; 39 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc

65 lines changed: 54 ins; 9 del; 2 mod; 463 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.h

15 lines changed: 11 ins; 0 del; 4 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh

1 line changed: 0 ins; 0 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh

1 line changed: 0 ins; 0 del; 1 mod; 370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h

2 lines changed: 0 ins; 0 del; 2 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cbdt-table.hh (was src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cbdt-table.hh)

131 lines changed: 87 ins; 0 del; 44 mod; 340 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-colr-table.hh

142 lines changed: 142 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cpal-table.hh

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-base-table.hh

655 lines changed: 655 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-unicode-ranges.hh

247 lines changed: 247 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-machine.hh

294 lines changed: 294 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc

835 lines changed: 835 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh

171 lines changed: 171 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.hh

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.hh

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh

62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.h

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/prrace/bin/webrev (vers 25.14-hg+openjdk.java.net).