Code Review for jdk

Prepared by:psandoz on Mon Apr 11 18:15:22 CEST 2016
Workspace:/Users/sandoz/Projects/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:-2
Summary of changes: 1286 lines changed: 56 ins; 10 del; 1220 mod; 38824 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/Invokers.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
4 lines changed: 0 ins; 0 del; 4 mod; 698 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MemberName.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
1 line changed: 0 ins; 0 del; 1 mod; 1136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
1 line changed: 0 ins; 0 del; 1 mod; 562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/MethodHandles.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
4 lines changed: 0 ins; 3 del; 1 mod; 4749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarForm.java

rev 14086 : 8151706: Update VarHandle implementation to use @Stable arrays
Reviewed-by: mhaupt, shade, redestad
rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
5 lines changed: 0 ins; 3 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/invoke/VarHandle.java

rev 14086 : 8151706: Update VarHandle implementation to use @Stable arrays
Reviewed-by: mhaupt, shade, redestad
rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
81 lines changed: 55 ins; 0 del; 26 mod; 1334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleBaseTest.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
32 lines changed: 1 ins; 0 del; 31 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessByte.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessChar.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessDouble.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessFloat.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessInt.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 783 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessLong.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 783 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessShort.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestAccessString.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 784 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsChar.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsDouble.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsFloat.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsLong.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
20 lines changed: 0 ins; 0 del; 20 mod; 624 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessBoolean.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessByte.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessChar.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessDouble.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessFloat.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessInt.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
114 lines changed: 0 ins; 0 del; 114 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
114 lines changed: 0 ins; 0 del; 114 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessShort.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
38 lines changed: 0 ins; 0 del; 38 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessString.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
107 lines changed: 0 ins; 0 del; 107 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeBoolean.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeByte.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeChar.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeDouble.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeFloat.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeInt.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
18 lines changed: 0 ins; 0 del; 18 mod; 2057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeLong.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
18 lines changed: 0 ins; 0 del; 18 mod; 2057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeShort.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
6 lines changed: 0 ins; 0 del; 6 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestMethodTypeString.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
15 lines changed: 0 ins; 0 del; 15 mod; 1796 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/VarHandleTestReflection.java

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
4 lines changed: 0 ins; 0 del; 4 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/X-VarHandleTestAccess.java.template

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
30 lines changed: 0 ins; 2 del; 28 mod; 996 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/X-VarHandleTestByteArrayView.java.template

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
30 lines changed: 0 ins; 2 del; 28 mod; 1059 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/X-VarHandleTestMethodHandleAccess.java.template

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
126 lines changed: 0 ins; 0 del; 126 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/VarHandles/X-VarHandleTestMethodType.java.template

rev 14088 : 8151705: VarHandle.AccessMode enum names should conform to code style
Reviewed-by: mhaupt, shade, redestad
18 lines changed: 0 ins; 0 del; 18 mod; 2081 unchg

This code review page was prepared using /Users/sandoz/Projects/jdk/tools/webrev/webrev.ksh (vers 25.14-hg+openjdk.java.net).