Code Review for open

Prepared by:rehn on Wed Oct 11 15:24:26 CEST 2017
Workspace:/home/rehn/source/jdk/jdk10/vanillia-hs/open
Compare against: http://hg.openjdk.java.net/jdk10/hs
Compare against version:47412
Summary of changes: 1939 lines changed: 1646 ins; 186 del; 107 mod; 125371 unchg
Changeset: open.changeset
Bug id: JDK-8185640 : Thread-local handshakes
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/test/JtregNativeHotspot.gmk

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 2 ins; 0 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/c1_LIRAssembler_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
12 lines changed: 10 ins; 0 del; 2 mod; 3354 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/c1_LIRGenerator_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 1 ins; 0 del; 1 mod; 1436 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/interp_masm_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
21 lines changed: 20 ins; 0 del; 1 mod; 2654 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
16 lines changed: 16 ins; 0 del; 0 mod; 5154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/macroAssembler_sparc.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 2 ins; 0 del; 0 mod; 1433 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/sharedRuntime_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
20 lines changed: 15 ins; 3 del; 2 mod; 3274 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/sparc.ad

rev 47415 : Add Thread Local handshakes and thread local polling
12 lines changed: 9 ins; 0 del; 3 mod; 10943 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/sparc/templateInterpreterGenerator_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
12 lines changed: 0 ins; 6 del; 6 mod; 2017 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
37 lines changed: 27 ins; 2 del; 8 mod; 3978 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/interp_masm_x86.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
17 lines changed: 17 ins; 0 del; 0 mod; 2012 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
21 lines changed: 21 ins; 0 del; 0 mod; 11317 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
6 lines changed: 6 ins; 0 del; 0 mod; 1749 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/nativeInst_x86.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
12 lines changed: 12 ins; 0 del; 0 mod; 741 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/relocInfo_x86.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
6 lines changed: 4 ins; 0 del; 2 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
41 lines changed: 32 ins; 4 del; 5 mod; 3854 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
10 lines changed: 5 ins; 2 del; 3 mod; 1904 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateInterpreterGenerator_x86_64.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
11 lines changed: 0 ins; 8 del; 3 mod; 454 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/x86_64.ad

rev 47415 : Add Thread Local handshakes and thread local polling
61 lines changed: 53 ins; 1 del; 7 mod; 12379 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/aix/os_aix.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
69 lines changed: 0 ins; 69 del; 0 mod; 4340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/bsd/os_bsd.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
14 lines changed: 0 ins; 14 del; 0 mod; 4082 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/linux/os_linux.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
14 lines changed: 0 ins; 14 del; 0 mod; 5983 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/solaris/os_solaris.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
rev 47415 : Add Thread Local handshakes and thread local polling
27 lines changed: 0 ins; 26 del; 1 mod; 5524 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os/windows/os_windows.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
21 lines changed: 0 ins; 21 del; 0 mod; 5380 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/linux_sparc/thread_linux_sparc.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/solaris_sparc/os_solaris_sparc.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
1 line changed: 0 ins; 0 del; 1 mod; 735 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/os_cpu/solaris_sparc/thread_solaris_sparc.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/interpreter/templateInterpreter.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 1 ins; 0 del; 1 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jvmci/jvmciCodeInstaller.cpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
4 lines changed: 2 ins; 0 del; 2 mod; 1283 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/logging/logTag.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
1 line changed: 1 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/parse1.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
8 lines changed: 7 ins; 0 del; 1 mod; 2391 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/whitebox.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
36 lines changed: 36 ins; 0 del; 0 mod; 2066 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/arguments.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
14 lines changed: 14 ins; 0 del; 0 mod; 4824 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/commandLineFlagConstraintsRuntime.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
16 lines changed: 15 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/commandLineFlagConstraintsRuntime.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
4 lines changed: 3 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/globals.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
7 lines changed: 7 ins; 0 del; 0 mod; 4174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/interfaceSupport.hpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
40 lines changed: 32 ins; 4 del; 4 mod; 587 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutex.cpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 1 ins; 0 del; 1 mod; 1403 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/objectMonitor.cpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
3 lines changed: 1 ins; 0 del; 2 mod; 2449 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/safepoint.cpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
80 lines changed: 33 ins; 4 del; 43 mod; 1378 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/safepoint.hpp

rev 47413 : Introduce SafepointMechanism
13 lines changed: 9 ins; 4 del; 0 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 47413 : Introduce SafepointMechanism
rev 47414 : Move polling page allocation to SafepointMechanism initialization
rev 47415 : Add Thread Local handshakes and thread local polling
18 lines changed: 13 ins; 4 del; 1 mod; 4863 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
34 lines changed: 34 ins; 0 del; 0 mod; 2173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.inline.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
12 lines changed: 12 ins; 0 del; 0 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/timer.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
6 lines changed: 5 ins; 0 del; 1 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/timer.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
2 lines changed: 1 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_operations.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
3 lines changed: 3 ins; 0 del; 0 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/TEST.groups

rev 47415 : Add Thread Local handshakes and thread local polling
3 lines changed: 3 ins; 0 del; 0 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/lib/sun/hotspot/WhiteBox.java

rev 47415 : Add Thread Local handshakes and thread local polling
3 lines changed: 3 ins; 0 del; 0 mod; 535 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/os/aix/safepointMechanism_aix.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/handshake.cpp

rev 47415 : Add Thread Local handshakes and thread local polling
349 lines changed: 349 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/handshake.hpp

rev 47415 : Add Thread Local handshakes and thread local polling
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/safepointMechanism.cpp

rev 47414 : Move polling page allocation to SafepointMechanism initialization
rev 47415 : Add Thread Local handshakes and thread local polling
84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/safepointMechanism.hpp

rev 47413 : Introduce SafepointMechanism
rev 47414 : Move polling page allocation to SafepointMechanism initialization
rev 47415 : Add Thread Local handshakes and thread local polling
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/runtime/safepointMechanism.inline.hpp

rev 47413 : Introduce SafepointMechanism
rev 47415 : Add Thread Local handshakes and thread local polling
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkExitTest.java

rev 47415 : Add Thread Local handshakes and thread local polling
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkStackFallbackTest.java

rev 47415 : Add Thread Local handshakes and thread local polling
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkStackNativeTest.java

rev 47415 : Add Thread Local handshakes and thread local polling
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/HandshakeWalkStackTest.java

rev 47415 : Add Thread Local handshakes and thread local polling
119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/TestTrans.java

rev 47415 : Add Thread Local handshakes and thread local polling
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/handshake/libTestTrans.c

rev 47415 : Add Thread Local handshakes and thread local polling
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rehn/source/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).