Code Review for open

Prepared by:rehn on Mon May 28 15:02:37 CEST 2018
Workspace:/home/rehn/source/jdk/hashish-jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:50280
Summary of changes: 1264 lines changed: 424 ins; 402 del; 438 mod; 29051 unchg
Changeset: open.changeset
Bug id: JDK-8195097 : Make it possible to process StringTable outside safepoint
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/stringTable.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
765 lines changed: 248 ins; 170 del; 347 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/stringTable.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
147 lines changed: 45 ins; 59 del; 43 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 1 ins; 0 del; 2 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
9 lines changed: 6 ins; 0 del; 3 mod; 8114 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
5 lines changed: 3 ins; 0 del; 2 mod; 1458 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/parNewGeneration.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
11 lines changed: 3 ins; 6 del; 2 mod; 4963 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1RootProcessor.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1RootProcessor.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
16 lines changed: 9 ins; 0 del; 7 mod; 1406 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
7 lines changed: 4 ins; 0 del; 3 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/strongRootsScope.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 0 ins; 2 del; 0 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/metaspaceShared.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 2171 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
6 lines changed: 6 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
4 lines changed: 2 ins; 1 del; 1 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/oops/weakHandle.inline.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
6 lines changed: 6 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/java.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
13 lines changed: 0 ins; 13 del; 0 mod; 742 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
5 lines changed: 5 ins; 0 del; 0 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/mutexLocker.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
2 lines changed: 2 ins; 0 del; 0 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/serviceThread.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 7 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmStructs.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 0 ins; 8 del; 0 mod; 3177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/concurrentHashTable.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
3 lines changed: 3 ins; 0 del; 0 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/concurrentHashTable.inline.hpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
72 lines changed: 28 ins; 20 del; 24 mod; 1172 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
8 lines changed: 0 ins; 8 del; 0 mod; 972 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
38 lines changed: 0 ins; 38 del; 0 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/gtest/utilities/test_concurrentHashtable.cpp

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
38 lines changed: 38 ins; 0 del; 0 mod; 917 unchg

------ ------ ------ ------ Old --- ----- --- src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/StringTable.java

rev 50281 : 8195097: Make it possible to process StringTable outside safepoint
Reviewed-by:
77 lines changed: 0 ins; 77 del; 0 mod; 0 unchg

This code review page was prepared using /home/rehn/source/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).