< prev index next >
src/hotspot/share/runtime/handshake.cpp
Print this page
rev 57079 : imported patch 8234796
rev 57080 : [mq]: 8234742-v2
*** 30,40 ****
#include "runtime/interfaceSupport.inline.hpp"
#include "runtime/orderAccess.hpp"
#include "runtime/osThread.hpp"
#include "runtime/semaphore.inline.hpp"
#include "runtime/task.hpp"
- #include "runtime/timerTrace.hpp"
#include "runtime/thread.hpp"
#include "runtime/vmThread.hpp"
#include "utilities/formatBuffer.hpp"
#include "utilities/preserveException.hpp"
--- 30,39 ----
*** 84,127 ****
}
log_stream.flush();
fatal("Handshake operation timed out");
}
class VM_HandshakeOneThread: public VM_Handshake {
JavaThread* _target;
public:
VM_HandshakeOneThread(HandshakeOperation* op, JavaThread* target) :
VM_Handshake(op), _target(target) {}
void doit() {
DEBUG_ONLY(_op->check_state();)
! TraceTime timer("Finished executing single-target operation (VM_HandshakeOneThread::doit)", TRACETIME_LOG(Info, handshake));
ThreadsListHandle tlh;
if (tlh.includes(_target)) {
set_handshake(_target);
} else {
! log_trace(handshake)("JavaThread " INTPTR_FORMAT " is not alive", p2i(_target));
return;
}
log_trace(handshake)("JavaThread " INTPTR_FORMAT " signaled, begin attempt to process by VMThtread", p2i(_target));
! jlong start_time = os::elapsed_counter();
do {
! if (handshake_has_timed_out(start_time)) {
handle_timeout();
}
// We need to re-think this with SMR ThreadsList.
// There is an assumption in the code that the Threads_lock should be
// locked during certain phases.
{
MutexLocker ml(Threads_lock);
! _target->handshake_process_by_vmthread();
}
} while (!poll_for_completed_thread());
DEBUG_ONLY(_op->check_state();)
}
VMOp_Type type() const { return VMOp_HandshakeOneThread; }
bool executed() const { return _op->executed(); }
--- 83,140 ----
}
log_stream.flush();
fatal("Handshake operation timed out");
}
+ static void log_handshake_info(jlong start_time_ns, const char* name, int targets, int vmt_executed, const char* extra) {
+ if (start_time_ns != 0) {
+ jlong completion_time = os::javaTimeNanos() - start_time_ns;
+ log_info(handshake)("Handshake \"%s\", Targeted threads: %d, Executed by targeted threads: %d, Total completion time: " JLONG_FORMAT " ns%s",
+ name, targets, targets - vmt_executed, completion_time, extra);
+ }
+ }
+
class VM_HandshakeOneThread: public VM_Handshake {
JavaThread* _target;
public:
VM_HandshakeOneThread(HandshakeOperation* op, JavaThread* target) :
VM_Handshake(op), _target(target) {}
void doit() {
DEBUG_ONLY(_op->check_state();)
!
! jlong start_time_ns = 0;
! if (log_is_enabled(Info, handshake)) {
! start_time_ns = os::javaTimeNanos();
! }
ThreadsListHandle tlh;
if (tlh.includes(_target)) {
set_handshake(_target);
} else {
! log_handshake_info(start_time_ns, _op->name(), 0, 0, " (thread dead)");
return;
}
log_trace(handshake)("JavaThread " INTPTR_FORMAT " signaled, begin attempt to process by VMThtread", p2i(_target));
! jlong timeout_start_time = os::elapsed_counter();
! bool by_vm_thread = false;
do {
! if (handshake_has_timed_out(timeout_start_time)) {
handle_timeout();
}
// We need to re-think this with SMR ThreadsList.
// There is an assumption in the code that the Threads_lock should be
// locked during certain phases.
{
MutexLocker ml(Threads_lock);
! by_vm_thread = _target->handshake_process_by_vmthread();
}
} while (!poll_for_completed_thread());
DEBUG_ONLY(_op->check_state();)
+ log_handshake_info(start_time_ns, _op->name(), 1, by_vm_thread ? 1 : 0, "");
}
VMOp_Type type() const { return VMOp_HandshakeOneThread; }
bool executed() const { return _op->executed(); }
*** 131,155 ****
public:
VM_HandshakeAllThreads(HandshakeOperation* op) : VM_Handshake(op) {}
void doit() {
DEBUG_ONLY(_op->check_state();)
! TraceTime timer("Finished executing multi-target operation (VM_HandshakeAllThreads::doit)", TRACETIME_LOG(Info, handshake));
JavaThreadIteratorWithHandle jtiwh;
int number_of_threads_issued = 0;
for (JavaThread *thr = jtiwh.next(); thr != NULL; thr = jtiwh.next()) {
set_handshake(thr);
number_of_threads_issued++;
}
if (number_of_threads_issued < 1) {
! log_debug(handshake)("No threads to handshake.");
return;
}
! log_debug(handshake)("Threads signaled, begin processing blocked threads by VMThtread");
const jlong start_time = os::elapsed_counter();
int number_of_threads_completed = 0;
do {
// Check if handshake operation has timed out
if (handshake_has_timed_out(start_time)) {
--- 144,173 ----
public:
VM_HandshakeAllThreads(HandshakeOperation* op) : VM_Handshake(op) {}
void doit() {
DEBUG_ONLY(_op->check_state();)
!
! jlong start_time_ns = 0;
! if (log_is_enabled(Info, handshake)) {
! start_time_ns = os::javaTimeNanos();
! }
! int handshake_executed_by_vm_thread = 0;
JavaThreadIteratorWithHandle jtiwh;
int number_of_threads_issued = 0;
for (JavaThread *thr = jtiwh.next(); thr != NULL; thr = jtiwh.next()) {
set_handshake(thr);
number_of_threads_issued++;
}
if (number_of_threads_issued < 1) {
! log_handshake_info(start_time_ns, _op->name(), 0, 0, " (no threads)");
return;
}
! log_trace(handshake)("Threads signaled, begin processing blocked threads by VMThtread");
const jlong start_time = os::elapsed_counter();
int number_of_threads_completed = 0;
do {
// Check if handshake operation has timed out
if (handshake_has_timed_out(start_time)) {
*** 166,176 ****
jtiwh.rewind();
MutexLocker ml(Threads_lock);
for (JavaThread *thr = jtiwh.next(); thr != NULL; thr = jtiwh.next()) {
// A new thread on the ThreadsList will not have an operation,
// hence it is skipped in handshake_process_by_vmthread.
! thr->handshake_process_by_vmthread();
}
}
while (poll_for_completed_thread()) {
// Includes canceled operations by exiting threads.
--- 184,196 ----
jtiwh.rewind();
MutexLocker ml(Threads_lock);
for (JavaThread *thr = jtiwh.next(); thr != NULL; thr = jtiwh.next()) {
// A new thread on the ThreadsList will not have an operation,
// hence it is skipped in handshake_process_by_vmthread.
! if (thr->handshake_process_by_vmthread()) {
! handshake_executed_by_vm_thread++;
! }
}
}
while (poll_for_completed_thread()) {
// Includes canceled operations by exiting threads.
*** 178,187 ****
--- 198,209 ----
}
} while (number_of_threads_issued > number_of_threads_completed);
assert(number_of_threads_issued == number_of_threads_completed, "Must be the same");
DEBUG_ONLY(_op->check_state();)
+
+ log_handshake_info(start_time_ns, _op->name(), number_of_threads_issued, handshake_executed_by_vm_thread, "");
}
VMOp_Type type() const { return VMOp_HandshakeAllThreads; }
};
*** 195,205 ****
_hs_op(hs_op), _target_thread(NULL), _all_threads(true), _executed(false) {}
VM_HandshakeFallbackOperation(HandshakeOperation* hs_op, Thread* target) :
_hs_op(hs_op), _target_thread(target), _all_threads(false), _executed(false) {}
void doit() {
! log_trace(handshake)("VMThread executing VM_HandshakeFallbackOperation");
for (JavaThreadIteratorWithHandle jtiwh; JavaThread *t = jtiwh.next(); ) {
if (_all_threads || t == _target_thread) {
if (t == _target_thread) {
_executed = true;
}
--- 217,227 ----
_hs_op(hs_op), _target_thread(NULL), _all_threads(true), _executed(false) {}
VM_HandshakeFallbackOperation(HandshakeOperation* hs_op, Thread* target) :
_hs_op(hs_op), _target_thread(target), _all_threads(false), _executed(false) {}
void doit() {
! log_trace(handshake)("VMThread executing VM_HandshakeFallbackOperation, operation: %s", name());
for (JavaThreadIteratorWithHandle jtiwh; JavaThread *t = jtiwh.next(); ) {
if (_all_threads || t == _target_thread) {
if (t == _target_thread) {
_executed = true;
}
*** 211,233 ****
VMOp_Type type() const { return VMOp_HandshakeFallback; }
bool executed() const { return _executed; }
};
void HandshakeOperation::do_handshake(JavaThread* thread) {
! ResourceMark rm;
! FormatBufferResource message("Operation for thread " PTR_FORMAT ", is_vm_thread: %s",
! p2i(thread), BOOL_TO_STR(Thread::current()->is_VM_thread()));
! TraceTime timer(message, TRACETIME_LOG(Debug, handshake, task));
// Only actually execute the operation for non terminated threads.
if (!thread->is_terminated()) {
do_thread(thread);
_executed = true;
}
// Use the semaphore to inform the VM thread that we have completed the operation
_done.signal();
}
void Handshake::execute(HandshakeOperation* hs_op) {
if (ThreadLocalHandshakes) {
VM_HandshakeAllThreads handshake(hs_op);
--- 233,261 ----
VMOp_Type type() const { return VMOp_HandshakeFallback; }
bool executed() const { return _executed; }
};
void HandshakeOperation::do_handshake(JavaThread* thread) {
! jlong start_time_ns = 0;
! if (log_is_enabled(Debug, handshake, task)) {
! start_time_ns = os::javaTimeNanos();
! }
// Only actually execute the operation for non terminated threads.
if (!thread->is_terminated()) {
do_thread(thread);
_executed = true;
}
// Use the semaphore to inform the VM thread that we have completed the operation
_done.signal();
+
+ if (start_time_ns != 0) {
+ jlong completion_time = os::javaTimeNanos() - start_time_ns;
+ log_debug(handshake, task)("Operation: %s for thread " PTR_FORMAT ", is_vm_thread: %s, completed in " JLONG_FORMAT " ns",
+ name(), p2i(thread), BOOL_TO_STR(Thread::current()->is_VM_thread()), completion_time);
+ }
}
void Handshake::execute(HandshakeOperation* hs_op) {
if (ThreadLocalHandshakes) {
VM_HandshakeAllThreads handshake(hs_op);
*** 320,358 ****
}
_semaphore.signal();
return false;
}
! void HandshakeState::process_by_vmthread(JavaThread* target) {
assert(Thread::current()->is_VM_thread(), "should call from vm thread");
// Threads_lock must be held here, but that is assert()ed in
// possibly_vmthread_can_process_handshake().
if (!has_operation()) {
// JT has already cleared its handshake
! return;
}
if (!possibly_vmthread_can_process_handshake(target)) {
// JT is observed in an unsafe state, it must notice the handshake itself
! return;
}
// Claim the semaphore if there still an operation to be executed.
if (!claim_handshake_for_vmthread()) {
! return;
}
// If we own the semaphore at this point and while owning the semaphore
// can observe a safe state the thread cannot possibly continue without
// getting caught by the semaphore.
if (vmthread_can_process_handshake(target)) {
guarantee(!_semaphore.trywait(), "we should already own the semaphore");
log_trace(handshake)("Processing handshake by VMThtread");
_operation->do_handshake(target);
// Disarm after VM thread have executed the operation.
clear_handshake(target);
! // Release the thread
}
_semaphore.signal();
}
--- 348,390 ----
}
_semaphore.signal();
return false;
}
! bool HandshakeState::process_by_vmthread(JavaThread* target) {
assert(Thread::current()->is_VM_thread(), "should call from vm thread");
// Threads_lock must be held here, but that is assert()ed in
// possibly_vmthread_can_process_handshake().
if (!has_operation()) {
// JT has already cleared its handshake
! return false;
}
if (!possibly_vmthread_can_process_handshake(target)) {
// JT is observed in an unsafe state, it must notice the handshake itself
! return false;
}
// Claim the semaphore if there still an operation to be executed.
if (!claim_handshake_for_vmthread()) {
! return false;
}
// If we own the semaphore at this point and while owning the semaphore
// can observe a safe state the thread cannot possibly continue without
// getting caught by the semaphore.
+ bool executed = false;
if (vmthread_can_process_handshake(target)) {
guarantee(!_semaphore.trywait(), "we should already own the semaphore");
log_trace(handshake)("Processing handshake by VMThtread");
_operation->do_handshake(target);
// Disarm after VM thread have executed the operation.
clear_handshake(target);
! executed = true;
}
+ // Release the thread
_semaphore.signal();
+
+ return executed;
}
< prev index next >