Code Review for open

Prepared by:rehn on Thu Nov 28 15:25:57 CET 2019
Workspace:/home/rehn/source/jdk/vanilla-jdk/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:57136
Summary of changes: 101 lines changed: 52 ins; 8 del; 41 mod; 30335 unchg
Changeset: open.changeset
Bug id: JDK-8234796 : Refactor Handshake::execute to take a more complex type than ThreadClosure
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1ConcurrentMark.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 3074 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1ConcurrentMark.hpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 877 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 470 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1RemSetSummary.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 797 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psScavenge.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 860 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 1404 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/stringdedup/stringDedup.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp

rev 57138 : [mq]: 8234796-v3
2 lines changed: 2 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/workgroup.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/workgroup.hpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zCollectedHeap.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zHeap.cpp

rev 57137 : imported patch 8234796-v2
5 lines changed: 3 ins; 0 del; 2 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zHeap.hpp

rev 57138 : [mq]: 8234796-v3
2 lines changed: 2 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zMark.cpp

rev 57137 : imported patch 8234796-v2
2 lines changed: 1 ins; 0 del; 1 mod; 774 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zRootsIterator.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zRuntimeWorkers.hpp

rev 57138 : [mq]: 8234796-v3
3 lines changed: 2 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/z/zWorkers.hpp

rev 57138 : [mq]: 8234796-v3
2 lines changed: 1 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jfr/recorder/checkpoint/jfrCheckpointManager.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jfr/recorder/checkpoint/types/jfrType.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/jfr/writers/jfrJavaEventWriter.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/iterator.hpp

rev 57137 : imported patch 8234796-v2
7 lines changed: 7 ins; 0 del; 0 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvmtiEnvBase.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 1595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/whitebox.cpp

rev 57137 : imported patch 8234796-v2
2 lines changed: 0 ins; 0 del; 2 mod; 2451 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/biasedLocking.cpp

rev 57137 : imported patch 8234796-v2
4 lines changed: 2 ins; 0 del; 2 mod; 993 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/deoptimization.cpp

rev 57137 : imported patch 8234796-v2
5 lines changed: 0 ins; 0 del; 5 mod; 2517 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/handshake.cpp

rev 57137 : imported patch 8234796-v2
11 lines changed: 0 ins; 0 del; 11 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/handshake.hpp

rev 57137 : imported patch 8234796-v2
15 lines changed: 11 ins; 1 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/sweeper.cpp

rev 57137 : imported patch 8234796-v2
7 lines changed: 0 ins; 0 del; 7 mod; 854 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 5072 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 57137 : imported patch 8234796-v2
7 lines changed: 0 ins; 7 del; 0 mod; 2303 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/threadSMR.inline.hpp

rev 57138 : [mq]: 8234796-v3
1 line changed: 1 ins; 0 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vmThread.cpp

rev 57137 : imported patch 8234796-v2
5 lines changed: 1 ins; 0 del; 4 mod; 785 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/globalCounter.cpp

rev 57138 : [mq]: 8234796-v3
3 lines changed: 1 ins; 0 del; 2 mod; 70 unchg

This code review page was prepared using /home/rehn/source/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).