Code Review for jdk-hs

Prepared by:rkennke on Thu Nov 30 13:40:44 CET 2017
Workspace:/home/rkennke/src/openjdk/jdk-hs
Compare against: ssh://hg.openjdk.java.net/jdk/hs/
Compare against version:48033
Summary of changes: 1394 lines changed: 577 ins; 717 del; 100 mod; 26985 unchg
Changeset: jdk-hs.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
79 lines changed: 78 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/cmsHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
13 lines changed: 13 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
28 lines changed: 0 ins; 0 del; 28 mod; 8132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
38 lines changed: 36 ins; 0 del; 2 mod; 5368 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
14 lines changed: 14 ins; 0 del; 0 mod; 1543 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1FullCollector.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
2 lines changed: 0 ins; 0 del; 2 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1FullCollector.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
2 lines changed: 1 ins; 0 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1FullGCScope.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
2 lines changed: 0 ins; 0 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1FullGCScope.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
3 lines changed: 2 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
46 lines changed: 46 ins; 0 del; 0 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
19 lines changed: 18 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMarkSweep.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
1 line changed: 0 ins; 0 del; 1 mod; 671 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psParallelCompact.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
1 line changed: 0 ins; 0 del; 1 mod; 3184 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psScavenge.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
1 line changed: 0 ins; 0 del; 1 mod; 783 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/serialHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
51 lines changed: 50 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/serial/serialHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
14 lines changed: 13 ins; 1 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
4 lines changed: 4 ins; 0 del; 0 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/collectedHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
10 lines changed: 9 ins; 0 del; 1 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
2 lines changed: 1 ins; 0 del; 1 mod; 1158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/genCollectedHeap.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
3 lines changed: 3 ins; 0 del; 0 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generation.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
2 lines changed: 1 ins; 0 del; 1 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/generation.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
12 lines changed: 12 ins; 0 del; 0 mod; 559 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryManager.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
40 lines changed: 1 ins; 34 del; 5 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryManager.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
98 lines changed: 4 ins; 90 del; 4 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryPool.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
94 lines changed: 0 ins; 94 del; 0 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryPool.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
63 lines changed: 0 ins; 60 del; 3 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryService.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
369 lines changed: 0 ins; 346 del; 23 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/services/memoryService.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
74 lines changed: 0 ins; 68 del; 6 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1MemoryPool.cpp (was src/hotspot/share/services/g1MemoryPool.cpp) 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
4 lines changed: 1 ins; 2 del; 1 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/g1/g1MemoryPool.hpp (was src/hotspot/share/services/g1MemoryPool.hpp) 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
9 lines changed: 2 ins; 3 del; 4 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMemoryPool.cpp (was src/hotspot/share/services/psMemoryPool.cpp) 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
16 lines changed: 0 ins; 11 del; 5 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/parallel/psMemoryPool.hpp (was src/hotspot/share/services/psMemoryPool.hpp) 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
12 lines changed: 0 ins; 8 del; 4 mod; 85 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shared/genMemoryPools.cpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shared/genMemoryPools.hpp 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/gc/TestMemoryMXBeansAndPoolsPresence.java 

rev 48034 : 8191564: Refactor GC related servicability code into GC specific subclasses
Reviewed-by: ehelin, eosterlund
101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).