Code Review for jdk

Prepared by:rkennke on Tue Aug 20 17:52:22 CEST 2019
Workspace:/home/rkennke/src/openjdk/jdk8u-jdk8u-dev/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk
Compare against version:13657
Summary of changes: 313 lines changed: 110 ins; 160 del; 43 mod; 4700 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
35 lines changed: 33 ins; 1 del; 1 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
63 lines changed: 30 ins; 10 del; 23 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/util/xml/impl/Parser.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
10 lines changed: 9 ins; 0 del; 1 mod; 3366 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
11 lines changed: 9 ins; 0 del; 2 mod; 693 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
9 lines changed: 8 ins; 0 del; 1 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ResourceBundle/Control/XmlRB.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
9 lines changed: 0 ins; 8 del; 1 mod; 8 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/ResourceBundle/Control/XmlRB_ja.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
9 lines changed: 0 ins; 8 del; 1 mod; 8 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
9 lines changed: 0 ins; 8 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/spi/ResourceBundleControlProvider/providersrc/XmlRB_ja.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
9 lines changed: 0 ins; 8 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/spi/ResourceBundleControlProvider/rbcontrolprovider.jar

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
11 lines changed: 0 ins; 0 del; 11 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/util/Properties/invalidxml/IllegalElement.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/java/util/Properties/invalidxml/invalidDTD.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/java/util/Properties/Compatibility.xml

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
10 lines changed: 0 ins; 10 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- test/java/util/Properties/CompatibilityTest.java

rev 13658 : 8213325: (props) Properties.loadFromXML does not fully comply with the spec
Reviewed-by: alanb, rriggs, dfuchs, naoto
107 lines changed: 0 ins; 107 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).