Code Review for jdk-jdk

Prepared by:rkennke on Mon Apr 6 14:14:45 CEST 2020
Workspace:/home/rkennke/src/openjdk/jdk-jdk
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:58686
Summary of changes: 819 lines changed: 748 ins; 12 del; 59 mod; 16836 unchg
Changeset: jdk-jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 0 ins; 0 del; 2 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 0 ins; 0 del; 2 mod; 1076 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

rev 58687 : Shenandoah: New incremental-update mode
6 lines changed: 4 ins; 0 del; 2 mod; 1274 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

rev 58687 : Shenandoah: New incremental-update mode
6 lines changed: 0 ins; 0 del; 6 mod; 3333 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 0 ins; 0 del; 2 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahAggressiveHeuristics.cpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

rev 58687 : Shenandoah: New incremental-update mode
5 lines changed: 4 ins; 0 del; 1 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

rev 58687 : Shenandoah: New incremental-update mode
4 lines changed: 1 ins; 0 del; 3 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSetClone.inline.hpp

rev 58687 : Shenandoah: New incremental-update mode
45 lines changed: 25 ins; 6 del; 14 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

rev 58687 : Shenandoah: New incremental-update mode
35 lines changed: 10 ins; 5 del; 20 mod; 916 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 58687 : Shenandoah: New incremental-update mode
3 lines changed: 3 ins; 0 del; 0 mod; 3016 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeuristics.hpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 1 ins; 0 del; 0 mod; 379 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/compiler/c2/aarch64/TestVolatiles.java

rev 58687 : Shenandoah: New incremental-update mode
17 lines changed: 16 ins; 0 del; 1 mod; 1002 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/CriticalNativeArgs.java

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 2 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestAllocHumongousFragment.java

rev 58687 : Shenandoah: New incremental-update mode
36 lines changed: 36 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestAllocIntArrays.java

rev 58687 : Shenandoah: New incremental-update mode
40 lines changed: 40 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestAllocObjectArrays.java

rev 58687 : Shenandoah: New incremental-update mode
40 lines changed: 40 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestAllocObjects.java

rev 58687 : Shenandoah: New incremental-update mode
45 lines changed: 45 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java

rev 58687 : Shenandoah: New incremental-update mode
19 lines changed: 19 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestHeapUncommit.java

rev 58687 : Shenandoah: New incremental-update mode
20 lines changed: 20 ins; 0 del; 0 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestLotsOfCycles.java

rev 58687 : Shenandoah: New incremental-update mode
28 lines changed: 28 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestObjItrWithHeapDump.java

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 1 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestPeriodicGC.java

rev 58687 : Shenandoah: New incremental-update mode
30 lines changed: 30 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestRefprocSanity.java

rev 58687 : Shenandoah: New incremental-update mode
20 lines changed: 20 ins; 0 del; 0 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestRegionSampling.java

rev 58687 : Shenandoah: New incremental-update mode
14 lines changed: 14 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestRetainObjects.java

rev 58687 : Shenandoah: New incremental-update mode
30 lines changed: 30 ins; 0 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestSieveObjects.java

rev 58687 : Shenandoah: New incremental-update mode
30 lines changed: 30 ins; 0 del; 0 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestStringDedup.java

rev 58687 : Shenandoah: New incremental-update mode
19 lines changed: 19 ins; 0 del; 0 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestStringDedupStress.java

rev 58687 : Shenandoah: New incremental-update mode
32 lines changed: 32 ins; 0 del; 0 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestStringInternCleanup.java

rev 58687 : Shenandoah: New incremental-update mode
21 lines changed: 21 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestVerifyJCStress.java

rev 58687 : Shenandoah: New incremental-update mode
14 lines changed: 14 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestWrongArrayMember.java

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 1 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/mxbeans/TestChurnNotifications.java

rev 58687 : Shenandoah: New incremental-update mode
16 lines changed: 16 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/mxbeans/TestPauseNotifications.java

rev 58687 : Shenandoah: New incremental-update mode
15 lines changed: 15 ins; 0 del; 0 mod; 156 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/oom/TestClassLoaderLeak.java

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 1 ins; 0 del; 0 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestExplicitGC.java

rev 58687 : Shenandoah: New incremental-update mode
19 lines changed: 19 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 2 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java

rev 58687 : Shenandoah: New incremental-update mode
1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestWrongBarrierDisable.java

rev 58687 : Shenandoah: New incremental-update mode
9 lines changed: 8 ins; 1 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/CriticalNativeStress.java

rev 58687 : Shenandoah: New incremental-update mode
2 lines changed: 2 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java

rev 58687 : Shenandoah: New incremental-update mode
43 lines changed: 43 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithShenandoah.java

rev 58687 : Shenandoah: New incremental-update mode
32 lines changed: 32 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/systemgc/TestSystemGCWithShenandoah.java

rev 58687 : Shenandoah: New incremental-update mode
15 lines changed: 15 ins; 0 del; 0 mod; 48 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahIUMode.cpp

rev 58687 : Shenandoah: New incremental-update mode
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahIUMode.hpp

rev 58687 : Shenandoah: New incremental-update mode
37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).