Code Review for shenandoah-jdk11

Prepared by:rkennke on Tue Mar 3 18:09:06 CET 2020
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk11
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk11/
Compare against version:54063
Summary of changes: 262 lines changed: 167 ins; 78 del; 17 mod; 10731 unchg
Changeset: shenandoah-jdk11.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

rev 54066 : [backport] 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code
Reviewed-by: aph, shade, rkennke
rev 54067 : [backport] 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet
Reviewed-by: rkennke
16 lines changed: 16 ins; 0 del; 0 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

rev 54066 : [backport] 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code
Reviewed-by: aph, shade, rkennke
rev 54067 : [backport] 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet
Reviewed-by: rkennke
rev 54069 : [backport] 8237776: Shenandoah: Wrong result with Lucene test
Reviewed-by: rkennke, zgu, shade
36 lines changed: 36 ins; 0 del; 0 mod; 948 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp

rev 54066 : [backport] 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code
Reviewed-by: aph, shade, rkennke
rev 54067 : [backport] 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet
Reviewed-by: rkennke
11 lines changed: 6 ins; 0 del; 5 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

rev 54066 : [backport] 8233401: Shenandoah: Refactor/cleanup Shenandoah load barrier code
Reviewed-by: aph, shade, rkennke
rev 54067 : [backport] 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet
Reviewed-by: rkennke
90 lines changed: 43 ins; 39 del; 8 mod; 1002 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

rev 54067 : [backport] 8233339: Shenandoah: Centralize load barrier decisions into ShenandoahBarrierSet
Reviewed-by: rkennke
36 lines changed: 18 ins; 18 del; 0 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

rev 54070 : [backport] 8238574: Shenandoah: Assertion failure due to missing null check
Reviewed-by: shade
3 lines changed: 2 ins; 0 del; 1 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

rev 54065 : [backport] 8232747: Shenandoah: Concurrent GC should deactivate SATB before processing weak roots
Reviewed-by: shade
2 lines changed: 0 ins; 2 del; 0 mod; 966 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 54065 : [backport] 8232747: Shenandoah: Concurrent GC should deactivate SATB before processing weak roots
Reviewed-by: shade
24 lines changed: 9 ins; 14 del; 1 mod; 2974 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

rev 54065 : [backport] 8232747: Shenandoah: Concurrent GC should deactivate SATB before processing weak roots
Reviewed-by: shade
2 lines changed: 0 ins; 2 del; 0 mod; 728 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp

rev 54064 : [backport] 8230350: Shenandoah: Assertion failed when GC is cancelled by a worker thread
Reviewed-by: rkennke
rev 54071 : [backport] 8239354: Shenandoah: minor enhancements to traversal GC
Reviewed-by: rkennke
2 lines changed: 1 ins; 0 del; 1 mod; 545 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp

rev 54065 : [backport] 8232747: Shenandoah: Concurrent GC should deactivate SATB before processing weak roots
Reviewed-by: shade
3 lines changed: 1 ins; 1 del; 1 mod; 879 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

rev 54068 : [backport] 8237543: Shenandoah: More asserts around code roots
Reviewed-by: zgu
rev 54071 : [backport] 8239354: Shenandoah: minor enhancements to traversal GC
Reviewed-by: rkennke
36 lines changed: 34 ins; 2 del; 0 mod; 1094 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.hpp

rev 54068 : [backport] 8237543: Shenandoah: More asserts around code roots
Reviewed-by: zgu
1 line changed: 1 ins; 0 del; 0 mod; 73 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).