Code Review for hotspot

Prepared by:rkennke on Tue Mar 19 15:02:25 CET 2019
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk8u/hotspot
Compare against: http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot
Compare against version:11143
Summary of changes: 209 lines changed: 109 ins; 60 del; 40 mod; 12180 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahAsserts.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.hpp

rev 11147 : [backport] 8217400: Optimized build is broken by Shenandoah changes
Reviewed-by: shade
2 lines changed: 0 ins; 0 del; 2 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp

rev 11144 : [backport] Simplify Shenandoah task termination in aborted paths
rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
8 lines changed: 1 ins; 5 del; 2 mod; 998 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahControlThread.cpp

rev 11148 : [backport] 8216973: Kick up cleanup phases in the right places
Reviewed-by: shade
rev 11150 : [backport] 8217343: Shenandoah control thread should be able to run at critical priority
Reviewed-by: rkennke
38 lines changed: 25 ins; 12 del; 1 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.hpp

rev 11147 : [backport] 8217400: Optimized build is broken by Shenandoah changes
Reviewed-by: shade
3 lines changed: 0 ins; 0 del; 3 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
rev 11152 : [backport] 8219857: Shenandoah GC may initialize thread's gclab twice
Reviewed-by: rkennke
6 lines changed: 1 ins; 3 del; 2 mod; 2563 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp

rev 11147 : [backport] 8217400: Optimized build is broken by Shenandoah changes
Reviewed-by: shade
4 lines changed: 0 ins; 0 del; 4 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 631 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
3 lines changed: 0 ins; 2 del; 1 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
3 lines changed: 0 ins; 2 del; 1 mod; 832 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMetrics.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahPacer.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
rev 11154 : [backport] 8220228: Improve Shenandoah pacing histogram message
Reviewed-by: rkennke
7 lines changed: 5 ins; 1 del; 1 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahStrDedupQueue.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahStringDedup.cpp

rev 11149 : [backport] 8217319: Cleanup Shenandoah includes
Reviewed-by: shade
2 lines changed: 0 ins; 1 del; 1 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.cpp

rev 11144 : [backport] Simplify Shenandoah task termination in aborted paths
rev 11146 : [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file
Reviewed-by: shade, tschatzl
12 lines changed: 5 ins; 2 del; 5 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp

rev 11144 : [backport] Simplify Shenandoah task termination in aborted paths
rev 11146 : [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file
Reviewed-by: shade, tschatzl
20 lines changed: 4 ins; 13 del; 3 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.inline.hpp

rev 11144 : [backport] Simplify Shenandoah task termination in aborted paths
rev 11146 : [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file
Reviewed-by: shade, tschatzl
16 lines changed: 11 ins; 2 del; 3 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahUtils.cpp

rev 11153 : [backport] 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah
Reviewed-by: rkennke
4 lines changed: 2 ins; 0 del; 2 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.cpp

rev 11146 : [backport] 8217213: shenandoahTaskQueue.hpp includes .inline.hpp file
Reviewed-by: shade, tschatzl
1 line changed: 0 ins; 0 del; 1 mod; 856 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoah_globals.hpp

rev 11150 : [backport] 8217343: Shenandoah control thread should be able to run at critical priority
Reviewed-by: rkennke
3 lines changed: 3 ins; 0 del; 0 mod; 399 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.cpp

rev 11145 : [backport] Remove obsolete code snippet related to barriers on constants
14 lines changed: 0 ins; 12 del; 2 mod; 1566 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/shenandoahMemoryPool.cpp

rev 11151 : [backport] 8219524: Shenandoah misreports "committed" size in MemoryMXBean
Reviewed-by: rkennke, zgu
7 lines changed: 6 ins; 0 del; 1 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/mxbeans/TestMemoryMXBeans.java

rev 11151 : [backport] 8219524: Shenandoah misreports "committed" size in MemoryMXBean
Reviewed-by: rkennke, zgu
6 lines changed: 6 ins; 0 del; 0 mod; 64 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestCriticalControlThreadPriority.java

rev 11150 : [backport] 8217343: Shenandoah control thread should be able to run at critical priority
Reviewed-by: rkennke
40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).