Code Review for hotspot

Prepared by:rkennke on Mon Oct 2 14:10:09 CEST 2017
Workspace:/home/rkennke/src/openjdk/aarch64-port-jdk8u-shenandoah/hotspot
Compare against: ssh://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/
Compare against version:9662
Summary of changes: 5416 lines changed: 3302 ins; 1038 del; 1076 mod; 112366 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/macroAssembler_aarch64.cpp

rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
2 lines changed: 0 ins; 0 del; 2 mod; 5196 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/shenandoahBarrierSet_aarch64.cpp

rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
1 line changed: 0 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/stubGenerator_aarch64.cpp

rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
1 line changed: 0 ins; 0 del; 1 mod; 4505 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/macroAssembler_x86.cpp

rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
2 lines changed: 0 ins; 0 del; 2 mod; 8902 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/shenandoahBarrierSet_x86.cpp

rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
1 line changed: 0 ins; 0 del; 1 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/stubGenerator_x86_64.cpp

rev 9663 : [backport] Fixed C calling convention of shenandoah_wb() on Windows
rev 9686 : Correct way to fix Windows call convention issue
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
6 lines changed: 2 ins; 0 del; 4 mod; 4312 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/x86_64.ad

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
2 lines changed: 0 ins; 2 del; 0 mod; 12067 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9687 : Revert accidental G1 closure rename
0 lines changed: 0 ins; 0 del; 0 mod; 6992 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/brooksPointer.hpp

rev 9692 : [backport] BrooksPointer tracing overwhelms -Xlog:gc=trace
4 lines changed: 0 ins; 4 del; 0 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/brooksPointer.inline.hpp

rev 9692 : [backport] BrooksPointer tracing overwhelms -Xlog:gc=trace
23 lines changed: 0 ins; 20 del; 3 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9700 : [backport] Templatize and improve inlining of arraycopy and clone barriers.
32 lines changed: 9 ins; 16 del; 7 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.hpp

rev 9700 : [backport] Templatize and improve inlining of arraycopy and clone barriers.
3 lines changed: 3 ins; 0 del; 0 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
24 lines changed: 0 ins; 0 del; 24 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
10 lines changed: 0 ins; 0 del; 10 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.cpp

rev 9695 : [backport] Refactor region flags into finite state machine
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9712 : [backport] Consistent print_on and tty handling
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
20 lines changed: 17 ins; 0 del; 3 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.hpp

rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9712 : [backport] Consistent print_on and tty handling
9 lines changed: 6 ins; 1 del; 2 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.inline.hpp

rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
1 line changed: 0 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCollectorPolicy.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9673 : [backport] Underflow in adaptive free_threshold calculation
rev 9674 : [backport] Periodic GC
rev 9690 : Fixed Fixed message logging
rev 9693 : [backport] Reclaimed humongous regions should count towards immediate garbage
rev 9694 : [backport] Allocation latency tracing
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
rev 9726 : [backport] Common pause marker to capture everything before/after pause
254 lines changed: 207 ins; 15 del; 32 mod; 1217 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCollectorPolicy.hpp

rev 9669 : [backport] Rename inline guards
rev 9678 : [backport] Cleanup unused methods and statements + Trivial cleanup: removed unused field, etc.
rev 9694 : [backport] Allocation latency tracing
rev 9726 : [backport] Common pause marker to capture everything before/after pause
13 lines changed: 9 ins; 1 del; 3 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9678 : [backport] Cleanup unused methods and statements + Trivial cleanup: removed unused field, etc.
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9726 : [backport] Common pause marker to capture everything before/after pause
46 lines changed: 0 ins; 5 del; 41 mod; 980 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9712 : [backport] Consistent print_on and tty handling
11 lines changed: 0 ins; 0 del; 11 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.inline.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
14 lines changed: 0 ins; 0 del; 14 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentThread.cpp

rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9676 : [backport] After Evac verification should run consistently
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9701 : [backport] Refactor ShConcThread dispatch
rev 9708 : [backport] Assorted monitoring support fixes
rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
92 lines changed: 64 ins; 1 del; 27 mod; 372 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentThread.hpp

rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
8 lines changed: 8 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.cpp

rev 9678 : [backport] Cleanup unused methods and statements + Trivial cleanup: removed unused field, etc.
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9715 : [backport] Refactor ShenandoahFreeSet + Fast-forward over humongous regions to keep "current" non-humongous
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
174 lines changed: 70 ins; 45 del; 59 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.hpp

rev 9678 : [backport] Cleanup unused methods and statements + Trivial cleanup: removed unused field, etc.
rev 9715 : [backport] Refactor ShenandoahFreeSet + Fast-forward over humongous regions to keep "current" non-humongous
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
26 lines changed: 10 ins; 8 del; 8 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahGCTraceTime.cpp

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
1 line changed: 0 ins; 0 del; 1 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9676 : [backport] After Evac verification should run consistently
rev 9677 : [backport] Verify liveness data
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9684 : [Backport] Fixed assertion failures when printing heap region to trace output
rev 9685 : Handle Java heap initialization and expansion failures
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9693 : [backport] Reclaimed humongous regions should count towards immediate garbage
rev 9694 : [backport] Allocation latency tracing
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9696 : [backport] Cleanup "dirty" mentions
rev 9699 : [backport] Refactor ShenandoahHeapLock
rev 9705 : [backport] Refactor ShenandoahHeapRegionSet
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9708 : [backport] Assorted monitoring support fixes
rev 9711 : [backport] Update counters on slow-path more rarely
rev 9712 : [backport] Consistent print_on and tty handling
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
rev 9715 : [backport] Refactor ShenandoahFreeSet + Fast-forward over humongous regions to keep "current" non-humongous
rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
rev 9727 : Fix build error in release config.
430 lines changed: 120 ins; 164 del; 146 mod; 1826 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9685 : Handle Java heap initialization and expansion failures
rev 9693 : [backport] Reclaimed humongous regions should count towards immediate garbage
rev 9694 : [backport] Allocation latency tracing
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9696 : [backport] Cleanup "dirty" mentions
rev 9699 : [backport] Refactor ShenandoahHeapLock
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9708 : [backport] Assorted monitoring support fixes
rev 9711 : [backport] Update counters on slow-path more rarely
rev 9712 : [backport] Consistent print_on and tty handling
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
95 lines changed: 33 ins; 46 del; 16 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.inline.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9694 : [backport] Allocation latency tracing
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9712 : [backport] Consistent print_on and tty handling
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
13 lines changed: 1 ins; 5 del; 7 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9698 : [backport] Allow allocations in pinned regions
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9709 : [backport] Pinning humongous regions should be allowed
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
rev 9724 : [backport] Fix build error: switches over enums should take all enums
295 lines changed: 229 ins; 44 del; 22 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.hpp

rev 9682 : [backport] Uncommit heap regions after given delay
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9698 : [backport] Allow allocations in pinned regions
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
rev 9724 : [backport] Fix build error: switches over enums should take all enums
212 lines changed: 187 ins; 15 del; 10 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.inline.hpp

rev 9682 : [backport] Uncommit heap regions after given delay
rev 9695 : [backport] Refactor region flags into finite state machine
1 line changed: 1 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionCounters.cpp

rev 9707 : [backport] On-demand commit as heap resizing strategy
6 lines changed: 0 ins; 1 del; 5 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9696 : [backport] Cleanup "dirty" mentions
rev 9705 : [backport] Refactor ShenandoahHeapRegionSet
rev 9712 : [backport] Consistent print_on and tty handling
71 lines changed: 2 ins; 53 del; 16 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.hpp

rev 9696 : [backport] Cleanup "dirty" mentions
rev 9705 : [backport] Refactor ShenandoahHeapRegionSet
rev 9712 : [backport] Consistent print_on and tty handling
67 lines changed: 22 ins; 34 del; 11 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahLogging.hpp

rev 9669 : [backport] Rename inline guards
rev 9690 : Fixed Fixed message logging
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
29 lines changed: 24 ins; 0 del; 5 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9696 : [backport] Cleanup "dirty" mentions
rev 9699 : [backport] Refactor ShenandoahHeapLock
rev 9705 : [backport] Refactor ShenandoahHeapRegionSet
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
rev 9726 : [backport] Common pause marker to capture everything before/after pause
95 lines changed: 60 ins; 8 del; 27 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMonitoringSupport.cpp

rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9708 : [backport] Assorted monitoring support fixes
42 lines changed: 29 ins; 3 del; 10 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMonitoringSupport.hpp

rev 9708 : [backport] Assorted monitoring support fixes
5 lines changed: 1 ins; 2 del; 2 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahOopClosures.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
7 lines changed: 0 ins; 0 del; 7 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahPrinter.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9670 : [backport] Made ShenandoahPrinter debug only
11 lines changed: 4 ins; 0 del; 7 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahPrinter.hpp

rev 9670 : [backport] Made ShenandoahPrinter debug only
9 lines changed: 9 ins; 0 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
6 lines changed: 0 ins; 0 del; 6 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9669 : [backport] Rename inline guards
8 lines changed: 0 ins; 0 del; 8 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahTaskqueue.inline.hpp

rev 9669 : [backport] Rename inline guards
27 lines changed: 27 ins; 0 del; 0 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahUtils.cpp

rev 9694 : [backport] Allocation latency tracing
rev 9726 : [backport] Common pause marker to capture everything before/after pause
38 lines changed: 38 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahUtils.hpp

rev 9669 : [backport] Rename inline guards
rev 9694 : [backport] Allocation latency tracing
rev 9726 : [backport] Common pause marker to capture everything before/after pause
26 lines changed: 23 ins; 0 del; 3 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.cpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9671 : [backport] Verifier should avoid pushing on stack when walking objects past TAMS
rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9675 : [backport] Move Verifier "start" message under (gc,start)
rev 9677 : [backport] Verify liveness data
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9697 : [backport] Verifier should walk cset and humongous regions
rev 9699 : [backport] Refactor ShenandoahHeapLock
rev 9704 : [backport] Verify humongous regions liveness
rev 9705 : [backport] Refactor ShenandoahHeapRegionSet
rev 9707 : [backport] On-demand commit as heap resizing strategy
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
rev 9720 : [backport] Make sure different Verifier levels work
rev 9725 : [backport] Fix build error: verifier liveness should not be implicitly casted to size_t
183 lines changed: 111 ins; 3 del; 69 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.hpp

rev 9668 : [backport] All definitions should start with Shenandoah*
rev 9669 : [backport] Rename inline guards
rev 9677 : [backport] Verify liveness data
rev 9725 : [backport] Fix build error: verifier liveness should not be implicitly casted to size_t
33 lines changed: 17 ins; 0 del; 16 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahWorkGroup.hpp

rev 9669 : [backport] Rename inline guards
1 line changed: 0 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoah_globals.hpp

rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9674 : [backport] Periodic GC
rev 9682 : [backport] Uncommit heap regions after given delay
rev 9685 : Handle Java heap initialization and expansion failures
rev 9688 : Test bug: test library and flags in TestHeapAlloc
rev 9694 : [backport] Allocation latency tracing
rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
41 lines changed: 40 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/vm_operations_shenandoah.cpp

rev 9672 : [backport] Shortcut concurrent cycle when enough immediate garbage is reclaimed
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9714 : [backport] Add JVMTI notifications to Shenandoah GC pauses.
rev 9726 : [backport] Common pause marker to capture everything before/after pause
36 lines changed: 12 ins; 16 del; 8 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metaspaceCounters.cpp

rev 9708 : [backport] Assorted monitoring support fixes
12 lines changed: 12 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/metaspaceCounters.hpp

rev 9708 : [backport] Assorted monitoring support fixes
2 lines changed: 2 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callGenerator.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
4 lines changed: 0 ins; 4 del; 0 mod; 1299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/callnode.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
4 lines changed: 3 ins; 0 del; 1 mod; 1910 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
1 line changed: 0 ins; 0 del; 1 mod; 4246 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
116 lines changed: 6 ins; 110 del; 0 mod; 4335 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.hpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
2 lines changed: 1 ins; 1 del; 0 mod; 957 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/library_call.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
rev 9728 : add missing UseShenandoahGC checks to C2
30 lines changed: 8 ins; 3 del; 19 mod; 7026 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopnode.cpp

rev 9666 : write barrier pin and expand cleanup
rev 9728 : add missing UseShenandoahGC checks to C2
rev 9729 : missing UseShenandoahGC check to C2
16 lines changed: 10 ins; 1 del; 5 mod; 3846 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopnode.hpp

rev 9666 : write barrier pin and expand cleanup
19 lines changed: 9 ins; 9 del; 1 mod; 1163 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/loopopts.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
2 lines changed: 1 ins; 0 del; 1 mod; 2864 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/machnode.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
1 line changed: 0 ins; 0 del; 1 mod; 829 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/macro.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
2 lines changed: 0 ins; 0 del; 2 mod; 2626 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/matcher.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
1 line changed: 0 ins; 0 del; 1 mod; 2658 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/parse2.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
21 lines changed: 18 ins; 2 del; 1 mod; 2393 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/shenandoahSupport.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
rev 9666 : write barrier pin and expand cleanup
rev 9667 : Remove unused memory_for, fixing the build
rev 9713 : [backport] Region (byte|word) shifts as the replacement for divisions
rev 9723 : [backport] Fix build error: avoid loops with empty bodies
rev 9728 : add missing UseShenandoahGC checks to C2
890 lines changed: 370 ins; 267 del; 253 mod; 3283 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/shenandoahSupport.hpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
rev 9666 : write barrier pin and expand cleanup
20 lines changed: 20 ins; 0 del; 0 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/stringopts.cpp

rev 9664 : missing barriers on constant oops + acmp rework + cas fix + write barrier on constant oop fix
2 lines changed: 2 ins; 0 del; 0 mod; 1662 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/subnode.cpp

rev 9665 : remove useless code following acmp rework
95 lines changed: 0 ins; 92 del; 3 mod; 1643 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/superword.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
19 lines changed: 2 ins; 0 del; 17 mod; 2627 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/type.cpp

rev 9728 : add missing UseShenandoahGC checks to C2
1 line changed: 0 ins; 0 del; 1 mod; 5036 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/arguments.cpp

rev 9682 : [backport] Uncommit heap regions after given delay
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9717 : [backport] Disable biased locking by default
19 lines changed: 15 ins; 4 del; 0 mod; 4457 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memoryService.cpp

rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
22 lines changed: 6 ins; 13 del; 3 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memoryService.hpp

rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
4 lines changed: 0 ins; 4 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/shenandoahMemoryPool.cpp

rev 9682 : [backport] Uncommit heap regions after given delay
rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
15 lines changed: 5 ins; 0 del; 10 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/shenandoahMemoryPool.hpp

rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
18 lines changed: 8 ins; 6 del; 4 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/numberSeq.cpp

rev 9694 : [backport] Allocation latency tracing
62 lines changed: 62 ins; 0 del; 0 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/numberSeq.hpp

rev 9694 : [backport] Allocation latency tracing
18 lines changed: 18 ins; 0 del; 0 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/TEST.groups

rev 9708 : [backport] Assorted monitoring support fixes
rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
rev 9722 : [backport] TestSmallHeap test for Shenandoah
6 lines changed: 6 ins; 0 del; 0 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/TestSystemGC.java

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
2 lines changed: 2 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/arguments/TestAlignmentToUseLargePages.java

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
2 lines changed: 2 ins; 0 del; 0 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/arguments/TestUseCompressedOopsErgo.java

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/logging/TestGCId.java

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
3 lines changed: 3 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/metaspace/TestMetaspacePerfCounters.java

rev 9708 : [backport] Assorted monitoring support fixes
2 lines changed: 1 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/EvilSyncBug.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
2 lines changed: 1 ins; 1 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/MXNotificationsFullGC.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/ShenandoahJNICritical.sh

rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
2 lines changed: 0 ins; 0 del; 2 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/AllocIntArrays.java

rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
24 lines changed: 5 ins; 1 del; 18 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/AllocObjectArrays.java

rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
24 lines changed: 5 ins; 1 del; 18 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/AllocObjects.java

rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
18 lines changed: 3 ins; 1 del; 14 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/ParallelRefprocSanity.java

rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
4 lines changed: 0 ins; 0 del; 4 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/RetainObjects.java

rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
17 lines changed: 1 ins; 6 del; 10 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/acceptance/StringInternCleanup.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
10 lines changed: 1 ins; 0 del; 9 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/compiler/C1VectorizedMismatch.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/compiler/TestReferenceCAS.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
10 lines changed: 0 ins; 0 del; 10 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/options/AlwaysPreTouch.java

rev 9707 : [backport] On-demand commit as heap resizing strategy
3 lines changed: 2 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/options/TestRegionSizeArgs.java

rev 9706 : [backport] Cap heap size for TestRegionSizeArgs test
19 lines changed: 19 ins; 0 del; 0 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/options/TestShenandoahArgumentRanges.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
6 lines changed: 6 ins; 0 del; 0 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/gc/shenandoah/options/TestSingleThreadedShenandoah.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapLock.hpp

rev 9699 : [backport] Refactor ShenandoahHeapLock
90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/HumongousThreshold.java

rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/LotsOfCycles.java

rev 9679 : [backport] Cannot do more than 1000 Full GCs
rev 9680 : [backport] Rehash -XX:-UseTLAB in tests + Rehash allocation tests
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
rev 9721 : [backport] LotsOfCycles test always degrades to Full GC
52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestHeapAlloc.java

rev 9685 : Handle Java heap initialization and expansion failures
rev 9688 : Test bug: test library and flags in TestHeapAlloc
rev 9695 : [backport] Refactor region flags into finite state machine
rev 9707 : [backport] On-demand commit as heap resizing strategy
75 lines changed: 75 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestMemoryMXBeans.java

rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestMemoryPools.java

rev 9716 : [backport] Make sure we have at least one memory pool per memory manager (JMX) + JMX double-counts heap used size
65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestPeriodicGC.java

rev 9674 : [backport] Periodic GC
rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestRegionSampling.java

rev 9681 : [backport] TestRegionSampling test
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestShenandoahWithLogLevel.java

rev 9684 : [Backport] Fixed assertion failures when printing heap region to trace output
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestSmallHeap.java

rev 9722 : [backport] TestSmallHeap test for Shenandoah
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/TestVerifyLevels.java

rev 9720 : [backport] Make sure different Verifier levels work
47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/acceptance/HeapUncommit.java

rev 9682 : [backport] Uncommit heap regions after given delay
rev 9683 : UnlockDiagnosticVMOptions flag is needed for ShenandoahVerify
rev 9689 : Properly unlock ShenandoahVerify
rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestExplicitGC.java

rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestExplicitGCNoConcurrent.java

rev 9718 : [backport] Avoid Full STW GC on System.gc() + related fixes
71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestHeuristicsUnlock.java

rev 9702 : [backport] Mark heuristics diagnostic/experimental
rev 9703 : [backport] "continuous" heuristics
115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestHumongousThresholdArgs.java

rev 9719 : [backport] Selectable humongous threshold + Humongous top() should be correct for iteration
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/shenandoah/options/TestVerboseGC.java

rev 9691 : Make sure -verbose:gc, PrintGC, PrintGCDetails work consistently
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/gc/startup_warnings/TestShenandoah.java

rev 9710 : [backport] Unlock more GC-specific tests for Shenandoah
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).