Code Review for hotspot

Prepared by:rkennke on Mon Sep 17 12:43:42 CEST 2018
Workspace:/home/rkennke/src/openjdk/aarch64-port-jdk8u-shenandoah/hotspot
Compare against: ssh://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot
Compare against version:10492
Summary of changes: 491 lines changed: 175 ins; 245 del; 71 mod; 108743 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/excludeSrc.make

rev 10601 : [backport] Shenandoah/PPC barrier stubs
1 line changed: 1 ins; 0 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/aarch64.ad

rev 10556 : [backport] Remove C2 write-barrier from .ad files
rev 10573 : [backport] Fix aarch64 CAS predicates
34 lines changed: 0 ins; 20 del; 14 mod; 17066 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/c1_MacroAssembler_aarch64.cpp

rev 10524 : [backport] Some trivial-ish cleanups
1 line changed: 0 ins; 1 del; 0 mod; 459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/macroAssembler_aarch64.cpp

rev 10501 : [backport] Check heap stability in C1 WBs
rev 10524 : [backport] Some trivial-ish cleanups
rev 10557 : [backport] Assembler write barriers should consistently check for forwarded objects
29 lines changed: 7 ins; 19 del; 3 mod; 5047 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/aarch64/vm/macroAssembler_aarch64.hpp

rev 10524 : [backport] Some trivial-ish cleanups
3 lines changed: 0 ins; 3 del; 0 mod; 1333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/c1_MacroAssembler_x86.cpp

rev 10524 : [backport] Some trivial-ish cleanups
1 line changed: 0 ins; 1 del; 0 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/macroAssembler_x86.cpp

rev 10501 : [backport] Check heap stability in C1 WBs
rev 10524 : [backport] Some trivial-ish cleanups
rev 10557 : [backport] Assembler write barriers should consistently check for forwarded objects
10 lines changed: 6 ins; 3 del; 1 mod; 8744 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/x86_64.ad

rev 10526 : [backport] Perform gc-state checks with LoadB to fit C2 matchers
rev 10556 : [backport] Remove C2 write-barrier from .ad files
rev 10568 : [backport] Fix CAS-obj predicates and add expected-null-versions for cmpxchg-narrow-oop
50 lines changed: 0 ins; 35 del; 15 mod; 12049 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_LIRGenerator.cpp

rev 10523 : [backport] C1 shenandoah_wb expects obj in a register
rev 10524 : [backport] Some trivial-ish cleanups
17 lines changed: 17 ins; 0 del; 0 mod; 3752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/c1/c1_LIRGenerator.hpp

rev 10523 : [backport] C1 shenandoah_wb expects obj in a register
1 line changed: 1 ins; 0 del; 0 mod; 652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/javaClasses.cpp

rev 10624 : [backport] Allocation path should not touch GC barriers for metadata
1 line changed: 0 ins; 0 del; 1 mod; 3639 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeCache.cpp

rev 10619 : [backport] Move ParallelCodeIterator to ShenandoahCodeRoots
51 lines changed: 0 ins; 51 del; 0 mod; 977 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeCache.hpp

rev 10619 : [backport] Move ParallelCodeIterator to ShenandoahCodeRoots
19 lines changed: 1 ins; 17 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/compiler/compileBroker.cpp

rev 10588 : [backport] Check and ensure that Shenandoah-enabled compilations succeed
* * *
[backport] Filter out not compilable methods to avoid false assertion
rev 10592 : [backport] Fix Minimal and Zero builds
11 lines changed: 11 ins; 0 del; 0 mod; 2417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/ptrQueue.cpp

rev 10535 : [backport] SATB buffer filtering/compaction hides unmarked objects until final-mark
rev 10548 : [backport] Forceful SATB buffer flushes should be time-periodic, not traffic-dependent
0 lines changed: 0 ins; 0 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/ptrQueue.hpp

rev 10535 : [backport] SATB buffer filtering/compaction hides unmarked objects until final-mark
rev 10548 : [backport] Forceful SATB buffer flushes should be time-periodic, not traffic-dependent
0 lines changed: 0 ins; 0 del; 0 mod; 319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/satbQueue.cpp

rev 10535 : [backport] SATB buffer filtering/compaction hides unmarked objects until final-mark
rev 10548 : [backport] Forceful SATB buffer flushes should be time-periodic, not traffic-dependent
16 lines changed: 16 ins; 0 del; 0 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/collectedHeap.inline.hpp

rev 10624 : [backport] Allocation path should not touch GC barriers for metadata
2 lines changed: 0 ins; 0 del; 2 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/gcName.hpp

rev 10539 : [backport] Missing Shenandoah entry in GCNameHelper::to_string
Contributed-by: Joshua Matsuoka <jmatsuok@redhat.com>
1 line changed: 1 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/barrierSet.cpp

rev 10551 : [backport] Remove safe_equals()
9 lines changed: 0 ins; 9 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/barrierSet.hpp

rev 10551 : [backport] Remove safe_equals()
5 lines changed: 0 ins; 5 del; 0 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referenceProcessor.cpp

rev 10551 : [backport] Remove safe_equals()
rev 10593 : Move JNI Weak References workaround to Shenandoah-specific root processor
21 lines changed: 0 ins; 14 del; 7 mod; 1414 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/referenceProcessor.hpp

rev 10551 : [backport] Remove safe_equals()
2 lines changed: 0 ins; 0 del; 2 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/threadLocalAllocBuffer.cpp

rev 10618 : [backport] Only Java and GC worker threads should get GCLABs
3 lines changed: 2 ins; 0 del; 1 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/oop.hpp

rev 10551 : [backport] Remove safe_equals()
rev 10624 : [backport] Allocation path should not touch GC barriers for metadata
21 lines changed: 5 ins; 16 del; 0 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/oops/oop.inline.hpp

rev 10624 : [backport] Allocation path should not touch GC barriers for metadata
3 lines changed: 3 ins; 0 del; 0 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/addnode.cpp

rev 10589 : [backport] Purge support for ShenandoahConcurrentEvacCodeRoots and ShenandoahBarriersForConst
2 lines changed: 0 ins; 0 del; 2 mod; 963 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
3 lines changed: 0 ins; 3 del; 0 mod; 1302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp

rev 10556 : [backport] Remove C2 write-barrier from .ad files
2 lines changed: 0 ins; 0 del; 2 mod; 4271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/ifg.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
1 line changed: 0 ins; 0 del; 1 mod; 825 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/lcm.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
2 lines changed: 0 ins; 1 del; 1 mod; 1196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
13 lines changed: 0 ins; 13 del; 0 mod; 7137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/loopnode.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
1 line changed: 0 ins; 1 del; 0 mod; 3866 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/machnode.cpp

rev 10589 : [backport] Purge support for ShenandoahConcurrentEvacCodeRoots and ShenandoahBarriersForConst
2 lines changed: 0 ins; 0 del; 2 mod; 806 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
1 line changed: 0 ins; 1 del; 0 mod; 2659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/mulnode.cpp

rev 10526 : [backport] Perform gc-state checks with LoadB to fit C2 matchers
11 lines changed: 11 ins; 0 del; 0 mod; 1355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/stringopts.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
1 line changed: 0 ins; 1 del; 0 mod; 1664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.cpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
4 lines changed: 0 ins; 4 del; 0 mod; 5015 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.hpp

rev 10595 : [backport] clean up obsolete c2 code
 - barriers are never added on constant oops
 - write barriers are always expanded to IR
1 line changed: 0 ins; 1 del; 0 mod; 1779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/arguments.cpp

rev 10500 : [backport] Rework ClassUnloading* flags handling
rev 10502 : [backport] ClassUnloadingWithConcurrentMark should be opt-in with Shenandoah
rev 10516 : [backport] Disable UseFastJNIAccessors for Shenandoah
rev 10583 : [backport] TLAB sizing policy should converge faster with Shenandoah
rev 10588 : [backport] Check and ensure that Shenandoah-enabled compilations succeed
* * *
[backport] Filter out not compilable methods to avoid false assertion
rev 10589 : [backport] Purge support for ShenandoahConcurrentEvacCodeRoots and ShenandoahBarriersForConst
rev 10592 : [backport] Fix Minimal and Zero builds
rev 10638 : [backport] Remove NMethodSizeLimit adjustment for Shenandoah
55 lines changed: 36 ins; 19 del; 0 mod; 4515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/safepoint.cpp

rev 10493 : [Backport] Shenandoah string deduplication
2 lines changed: 0 ins; 0 del; 2 mod; 1317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.cpp

rev 10527 : [backport] Move (Java)Thread::_gc_state to lower offset to optimize barrier fast-path encoding
rev 10546 : [backport] Wrap worker id in thread local worker session
rev 10548 : [backport] Forceful SATB buffer flushes should be time-periodic, not traffic-dependent
17 lines changed: 12 ins; 2 del; 3 mod; 4748 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/thread.hpp

rev 10527 : [backport] Move (Java)Thread::_gc_state to lower offset to optimize barrier fast-path encoding
rev 10546 : [backport] Wrap worker id in thread local worker session
rev 10548 : [backport] Forceful SATB buffer flushes should be time-periodic, not traffic-dependent
rev 10618 : [backport] Only Java and GC worker threads should get GCLABs
34 lines changed: 26 ins; 5 del; 3 mod; 2056 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/numberSeq.cpp

rev 10576 : [backport] Trace and report total allocation latency and sizes
7 lines changed: 7 ins; 0 del; 0 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/numberSeq.hpp

rev 10576 : [backport] Trace and report total allocation latency and sizes
2 lines changed: 2 ins; 0 del; 0 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/TEST.groups

rev 10499 : [backport] Rework GC degradation on allocation failure
rev 10513 : [backport] Rearrange Shenandoah tests into 3 tiers
rev 10586 : [backport] Move Shenandoah stress tests to tier3
18 lines changed: 10 ins; 0 del; 8 mod; 273 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).