Code Review for shenandoah-jdk

Prepared by:rkennke on Thu Feb 14 17:39:37 CET 2019
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk/
Compare against version:54570
Summary of changes: 4420 lines changed: 949 ins; 2917 del; 554 mod; 46586 unchg
Changeset: shenandoah-jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/JvmFeatures.gmk

rev 54572 : imported patch lrb.patch
2 lines changed: 0 ins; 2 del; 0 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp

rev 54571 : 8217874: Shenandoah: Clobbered register in ShenandoahBarrierSetAssembler::cmpxchg_oop()
rev 54572 : imported patch lrb.patch
148 lines changed: 25 ins; 69 del; 54 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp

rev 54572 : imported patch lrb.patch
14 lines changed: 0 ins; 5 del; 9 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetC1_aarch64.cpp

rev 54572 : imported patch lrb.patch
1 line changed: 1 ins; 0 del; 0 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/aarch64/gc/shenandoah/shenandoah_aarch64.ad

rev 54572 : imported patch lrb.patch
12 lines changed: 0 ins; 12 del; 0 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.cpp

rev 54572 : imported patch lrb.patch
156 lines changed: 22 ins; 91 del; 43 mod; 862 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp

rev 54572 : imported patch lrb.patch
26 lines changed: 2 ins; 16 del; 8 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetC1_x86.cpp

rev 54572 : imported patch lrb.patch
1 line changed: 1 ins; 0 del; 0 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/gc/shenandoah/shenandoah_x86_64.ad

rev 54572 : imported patch lrb.patch
41 lines changed: 0 ins; 40 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/adlc/formssel.cpp

rev 54572 : imported patch lrb.patch
1 line changed: 1 ins; 0 del; 0 mod; 4301 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp

rev 54572 : imported patch lrb.patch
108 lines changed: 14 ins; 83 del; 11 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp

rev 54572 : imported patch lrb.patch
10 lines changed: 0 ins; 5 del; 5 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp

rev 54572 : imported patch lrb.patch
447 lines changed: 43 ins; 359 del; 45 mod; 1167 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp

rev 54572 : imported patch lrb.patch
36 lines changed: 8 ins; 23 del; 5 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp

rev 54572 : imported patch lrb.patch
2676 lines changed: 643 ins; 1755 del; 278 mod; 2405 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp

rev 54572 : imported patch lrb.patch
209 lines changed: 41 ins; 157 del; 11 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp

rev 54572 : imported patch lrb.patch
5 lines changed: 1 ins; 4 del; 0 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahAggressiveHeuristics.cpp

rev 54572 : imported patch lrb.patch
5 lines changed: 1 ins; 4 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.cpp

rev 54572 : imported patch lrb.patch
5 lines changed: 1 ins; 4 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.cpp

rev 54572 : imported patch lrb.patch
5 lines changed: 1 ins; 4 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.cpp

rev 54572 : imported patch lrb.patch
5 lines changed: 1 ins; 4 del; 0 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/heuristics/shenandoahTraversalHeuristics.cpp

rev 54572 : imported patch lrb.patch
4 lines changed: 0 ins; 3 del; 1 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

rev 54572 : imported patch lrb.patch
13 lines changed: 0 ins; 13 del; 0 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

rev 54572 : imported patch lrb.patch
39 lines changed: 1 ins; 22 del; 16 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

rev 54572 : imported patch lrb.patch
116 lines changed: 1 ins; 96 del; 19 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

rev 54572 : imported patch lrb.patch
107 lines changed: 77 ins; 11 del; 19 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp

rev 54572 : imported patch lrb.patch
42 lines changed: 0 ins; 41 del; 1 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 54572 : imported patch lrb.patch
8 lines changed: 0 ins; 6 del; 2 mod; 2796 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp

rev 54572 : imported patch lrb.patch
33 lines changed: 31 ins; 1 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp

rev 54572 : imported patch lrb.patch
10 lines changed: 7 ins; 0 del; 3 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.cpp

rev 54572 : imported patch lrb.patch
2 lines changed: 0 ins; 0 del; 2 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRuntime.hpp

rev 54572 : imported patch lrb.patch
1 line changed: 0 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

rev 54572 : imported patch lrb.patch
22 lines changed: 3 ins; 19 del; 0 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/block.hpp

rev 54572 : imported patch lrb.patch
6 lines changed: 0 ins; 6 del; 0 mod; 892 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/classes.hpp

rev 54572 : imported patch lrb.patch
3 lines changed: 0 ins; 2 del; 1 mod; 403 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/compile.cpp

rev 54572 : imported patch lrb.patch
1 line changed: 0 ins; 0 del; 1 mod; 4694 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/lcm.cpp

rev 54572 : imported patch lrb.patch
60 lines changed: 17 ins; 37 del; 6 mod; 1376 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/library_call.cpp

rev 54572 : imported patch lrb.patch
4 lines changed: 1 ins; 0 del; 3 mod; 6723 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/loopPredicate.cpp

rev 54572 : imported patch lrb.patch
3 lines changed: 0 ins; 3 del; 0 mod; 1523 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/loopnode.cpp

rev 54572 : imported patch lrb.patch
2 lines changed: 0 ins; 0 del; 2 mod; 4560 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/loopnode.hpp

rev 54572 : imported patch lrb.patch
4 lines changed: 0 ins; 3 del; 1 mod; 1437 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/loopopts.cpp

rev 54572 : imported patch lrb.patch
6 lines changed: 0 ins; 5 del; 1 mod; 3482 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/node.cpp

rev 54572 : imported patch lrb.patch
3 lines changed: 3 ins; 0 del; 0 mod; 2463 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/node.hpp

rev 54572 : imported patch lrb.patch
3 lines changed: 0 ins; 3 del; 0 mod; 1742 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/phasetype.hpp

rev 54572 : imported patch lrb.patch
2 lines changed: 2 ins; 0 del; 0 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestSelectiveBarrierFlags.java

rev 54572 : imported patch lrb.patch
6 lines changed: 0 ins; 4 del; 2 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestWrongBarrierDisable.java

rev 54572 : imported patch lrb.patch
7 lines changed: 0 ins; 5 del; 2 mod; 93 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).