Code Review for hotspot

Prepared by:rkennke on Mon Oct 28 20:27:32 CET 2019
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk8/hotspot
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk8/hotspot
Compare against version:11420
Summary of changes: 975 lines changed: 573 ins; 224 del; 178 mod; 77427 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/macroAssembler_aarch64.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
8 lines changed: 0 ins; 7 del; 1 mod; 4910 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/shenandoahBarrierSetAssembler_aarch64.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
rev 11424 : [backport] 8231583: Shenandoah: Fix register clash in SBSA::resolve_forwarding_pointer() borrowing
Reviewed-by: rkennke
48 lines changed: 34 ins; 9 del; 5 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/aarch64/vm/shenandoahBarrierSetAssembler_aarch64.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/macroAssembler_x86.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
8 lines changed: 0 ins; 7 del; 1 mod; 8613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/shenandoahBarrierSetAssembler_x86.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
rev 11424 : [backport] 8231583: Shenandoah: Fix register clash in SBSA::resolve_forwarding_pointer() borrowing
Reviewed-by: rkennke
52 lines changed: 33 ins; 13 del; 6 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/shenandoahBarrierSetAssembler_x86.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/templateTable_x86_64.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
6 lines changed: 0 ins; 6 del; 0 mod; 3838 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/x86_64.ad

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 1 del; 0 mod; 12013 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/asm/assembler.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
20 lines changed: 0 ins; 19 del; 1 mod; 316 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/c1/c1_LIRGenerator.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 1 del; 0 mod; 3732 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/ci/ciInstanceKlass.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
4 lines changed: 0 ins; 1 del; 3 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahAsserts.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
13 lines changed: 4 ins; 0 del; 9 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 0 del; 2 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.inline.hpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
2 lines changed: 1 ins; 0 del; 1 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSetC1.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahCodeRoots.cpp

rev 11423 : [backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
Reviewed-by: zgu, rkennke
7 lines changed: 5 ins; 0 del; 2 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 1 del; 0 mod; 995 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.inline.hpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 1 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
rev 11423 : [backport] 8231197: Shenandoah: JVMTI heap walking cleanup crashes with NULL forwardee
Reviewed-by: zgu, rkennke
39 lines changed: 15 ins; 17 del; 7 mod; 2595 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
8 lines changed: 0 ins; 8 del; 0 mod; 662 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeap.inline.hpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
34 lines changed: 2 ins; 8 del; 24 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
3 lines changed: 0 ins; 1 del; 2 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahHeuristics.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 1 del; 1 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
78 lines changed: 38 ins; 7 del; 33 mod; 793 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
8 lines changed: 7 ins; 1 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahStringDedup.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 1 del; 0 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahSupport.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
42 lines changed: 21 ins; 3 del; 18 mod; 2996 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahSupport.hpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahVerifier.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
10 lines changed: 1 ins; 1 del; 8 mod; 864 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_interface/collectedHeap.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
16 lines changed: 0 ins; 15 del; 1 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_interface/collectedHeap.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
8 lines changed: 0 ins; 8 del; 0 mod; 693 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_interface/collectedHeap.inline.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 2 del; 0 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/threadLocalAllocBuffer.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
7 lines changed: 0 ins; 6 del; 1 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/memory/threadLocalAllocBuffer.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
7 lines changed: 6 ins; 1 del; 0 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 0 del; 1 mod; 4252 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
1 line changed: 0 ins; 1 del; 0 mod; 4235 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/macro.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
21 lines changed: 0 ins; 19 del; 2 mod; 2616 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/memnode.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 0 del; 2 mod; 4701 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/type.cpp

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
5 lines changed: 0 ins; 3 del; 2 mod; 5013 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiEnv.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
2 lines changed: 0 ins; 0 del; 2 mod; 3442 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/jvmtiExport.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
1 line changed: 0 ins; 0 del; 1 mod; 2493 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/prims/whitebox.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
1 line changed: 0 ins; 0 del; 1 mod; 1201 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/gc_implementation/shenandoah/preservedMarks.cpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/gc_implementation/shenandoah/preservedMarks.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/share/vm/gc_implementation/shenandoah/preservedMarks.inline.hpp

rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahForwarding.hpp (was src/share/vm/gc_implementation/shenandoah/shenandoahBrooksPointer.hpp)

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
69 lines changed: 6 ins; 50 del; 13 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc_implementation/shenandoah/shenandoahForwarding.inline.hpp (was src/share/vm/gc_implementation/shenandoah/shenandoahBrooksPointer.inline.hpp)

rev 11421 : [backport] 8223567: Rename ShenandoahBrooksPointer to ShenandoahForwarding
Reviewed-by: shade
rev 11422 : [backport] 8224584: Shenandoah: Eliminate forwarding pointer word
Reviewed-by: shade, roland
35 lines changed: 9 ins; 5 del; 21 mod; 42 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).