Code Review for shenandoah-jdk

Prepared by:rkennke on Tue Apr 17 22:24:01 CEST 2018
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk/
Compare against version:49793
Summary of changes: 2444 lines changed: 829 ins; 1397 del; 218 mod; 60219 unchg
Changeset: shenandoah-jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/c1_Runtime1_x86.cpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 0 del; 2 mod; 1761 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 49794 : Fold Partial GC into Traversal GC
10 lines changed: 0 ins; 8 del; 2 mod; 11803 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/shenandoahBarrierSet_x86.cpp

rev 49794 : Fold Partial GC into Traversal GC
7 lines changed: 0 ins; 2 del; 5 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

rev 49794 : Fold Partial GC into Traversal GC
1 line changed: 0 ins; 0 del; 1 mod; 5251 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.hpp

rev 49794 : Fold Partial GC into Traversal GC
1 line changed: 0 ins; 0 del; 1 mod; 2490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

rev 49794 : Fold Partial GC into Traversal GC
42 lines changed: 0 ins; 40 del; 2 mod; 4041 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/markBitMap.cpp

rev 49794 : Fold Partial GC into Traversal GC
9 lines changed: 9 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/markBitMap.hpp

rev 49794 : Fold Partial GC into Traversal GC
3 lines changed: 3 ins; 0 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahArguments.cpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp

rev 49794 : Fold Partial GC into Traversal GC
6 lines changed: 6 ins; 0 del; 0 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

rev 49794 : Fold Partial GC into Traversal GC
56 lines changed: 8 ins; 19 del; 29 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

rev 49794 : Fold Partial GC into Traversal GC
3 lines changed: 0 ins; 1 del; 2 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp

rev 49794 : Fold Partial GC into Traversal GC
24 lines changed: 0 ins; 17 del; 7 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.cpp

rev 49794 : Fold Partial GC into Traversal GC
369 lines changed: 156 ins; 174 del; 39 mod; 1423 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.hpp

rev 49794 : Fold Partial GC into Traversal GC
6 lines changed: 0 ins; 5 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

rev 49794 : Fold Partial GC into Traversal GC
3 lines changed: 0 ins; 3 del; 0 mod; 1091 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentThread.cpp

rev 49794 : Fold Partial GC into Traversal GC
44 lines changed: 6 ins; 34 del; 4 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentThread.hpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp

rev 49794 : Fold Partial GC into Traversal GC
4 lines changed: 3 ins; 0 del; 1 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 49794 : Fold Partial GC into Traversal GC
191 lines changed: 86 ins; 91 del; 14 mod; 2787 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

rev 49794 : Fold Partial GC into Traversal GC
40 lines changed: 15 ins; 20 del; 5 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp

rev 49794 : Fold Partial GC into Traversal GC
13 lines changed: 0 ins; 8 del; 5 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp

rev 49794 : Fold Partial GC into Traversal GC
18 lines changed: 14 ins; 2 del; 2 mod; 733 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp

rev 49794 : Fold Partial GC into Traversal GC
9 lines changed: 0 ins; 9 del; 0 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp

rev 49794 : Fold Partial GC into Traversal GC
8 lines changed: 1 ins; 7 del; 0 mod; 891 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp

rev 49794 : Fold Partial GC into Traversal GC
146 lines changed: 120 ins; 17 del; 9 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahOopClosures.inline.hpp

rev 49794 : Fold Partial GC into Traversal GC
8 lines changed: 0 ins; 6 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.cpp

rev 49794 : Fold Partial GC into Traversal GC
41 lines changed: 0 ins; 41 del; 0 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp

rev 49794 : Fold Partial GC into Traversal GC
45 lines changed: 0 ins; 44 del; 1 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

rev 49794 : Fold Partial GC into Traversal GC
249 lines changed: 187 ins; 0 del; 62 mod; 934 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.hpp

rev 49794 : Fold Partial GC into Traversal GC
14 lines changed: 10 ins; 0 del; 4 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp

rev 49794 : Fold Partial GC into Traversal GC
20 lines changed: 14 ins; 1 del; 5 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

rev 49794 : Fold Partial GC into Traversal GC
25 lines changed: 0 ins; 24 del; 1 mod; 861 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp

rev 49794 : Fold Partial GC into Traversal GC
22 lines changed: 0 ins; 22 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.hpp

rev 49794 : Fold Partial GC into Traversal GC
8 lines changed: 0 ins; 8 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

rev 49794 : Fold Partial GC into Traversal GC
13 lines changed: 3 ins; 10 del; 0 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_specialized_oop_closures.hpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp

rev 49794 : Fold Partial GC into Traversal GC
11 lines changed: 0 ins; 11 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.hpp

rev 49794 : Fold Partial GC into Traversal GC
18 lines changed: 0 ins; 18 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/graphKit.cpp

rev 49794 : Fold Partial GC into Traversal GC
42 lines changed: 0 ins; 39 del; 3 mod; 4979 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/library_call.cpp

rev 49794 : Fold Partial GC into Traversal GC
1 line changed: 0 ins; 0 del; 1 mod; 7228 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/shenandoahSupport.cpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 0 del; 2 mod; 4365 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/shenandoahSupport.hpp

rev 49794 : Fold Partial GC into Traversal GC
6 lines changed: 0 ins; 2 del; 4 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_operations.hpp

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 2 del; 0 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/bitMap.cpp

rev 49794 : Fold Partial GC into Traversal GC
22 lines changed: 22 ins; 0 del; 0 mod; 685 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/utilities/bitMap.hpp

rev 49794 : Fold Partial GC into Traversal GC
3 lines changed: 3 ins; 0 del; 0 mod; 437 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestSelectiveBarrierFlags.java

rev 49794 : Fold Partial GC into Traversal GC
2 lines changed: 0 ins; 0 del; 2 mod; 103 unchg

------ ------ ------ ------ --- New ----- Raw test/hotspot/gtest/utilities/test_bitMap_copy.cpp

rev 49794 : Fold Partial GC into Traversal GC
163 lines changed: 163 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/gc/shenandoah/shenandoahPartialGC.cpp

rev 49794 : Fold Partial GC into Traversal GC
573 lines changed: 0 ins; 573 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/gc/shenandoah/shenandoahPartialGC.hpp

rev 49794 : Fold Partial GC into Traversal GC
68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/hotspot/share/gc/shenandoah/shenandoahPartialGC.inline.hpp

rev 49794 : Fold Partial GC into Traversal GC
61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).