Code Review for hotspot

Prepared by:rkennke on Sat Sep 16 11:38:46 CEST 2017
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk10/hotspot
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk10/hotspot
Compare against version:14418
Summary of changes: 517 lines changed: 262 ins; 180 del; 75 mod; 62834 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/c1_Runtime1_x86.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
11 lines changed: 0 ins; 11 del; 0 mod; 1793 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/macroAssembler_x86.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
93 lines changed: 63 ins; 21 del; 9 mod; 11811 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/macroAssembler_x86.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
14 lines changed: 14 ins; 0 del; 0 mod; 1785 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/templateTable_x86.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
8 lines changed: 7 ins; 0 del; 1 mod; 4445 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/c1/c1_LIRGenerator.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
52 lines changed: 45 ins; 0 del; 7 mod; 3962 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/c1/c1_LIRGenerator.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
2 lines changed: 2 ins; 0 del; 0 mod; 670 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahBarrierSet.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
24 lines changed: 15 ins; 1 del; 8 mod; 418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahBarrierSet.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
1 line changed: 1 ins; 0 del; 0 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahHeap.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
6 lines changed: 1 ins; 1 del; 4 mod; 2129 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahHeap.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
9 lines changed: 2 ins; 2 del; 5 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahHeap.inline.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
6 lines changed: 0 ins; 4 del; 2 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahHeapRegionCounters.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
3 lines changed: 0 ins; 0 del; 3 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoahMarkCompact.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
2 lines changed: 0 ins; 0 del; 2 mod; 752 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/gc/shenandoah/shenandoah_globals.hpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
4 lines changed: 0 ins; 4 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/cfgnode.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
1 line changed: 1 ins; 0 del; 0 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/compile.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
2 lines changed: 0 ins; 0 del; 2 mod; 4703 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.cpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
222 lines changed: 62 ins; 133 del; 27 mod; 4824 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/graphKit.hpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
12 lines changed: 10 ins; 0 del; 2 mod; 987 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/ifnode.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
19 lines changed: 19 ins; 0 del; 0 mod; 1859 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/library_call.cpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
8 lines changed: 3 ins; 3 del; 2 mod; 7174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/memnode.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
7 lines changed: 7 ins; 0 del; 0 mod; 1625 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/node.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
2 lines changed: 2 ins; 0 del; 0 mod; 1730 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/parse2.cpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
1 line changed: 1 ins; 0 del; 0 mod; 2442 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/parse3.cpp

rev 14419 : Remove obsolete and unused reduce-storeval-barrier optimization code.
2 lines changed: 2 ins; 0 del; 0 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/opto/shenandoahSupport.cpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
1 line changed: 0 ins; 0 del; 1 mod; 4418 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
1 line changed: 1 ins; 0 del; 0 mod; 2206 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/thread.inline.hpp

rev 14420 : Refactor conc-mark-in-progress/satb-active flags to use gc-phase-in-progress.
4 lines changed: 4 ins; 0 del; 0 mod; 170 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).