Code Review for shenandoah-jdk10

Prepared by:rkennke on Tue Jan 23 21:38:12 CET 2018
Workspace:/home/rkennke/src/openjdk/shenandoah-jdk10
Compare against: ssh://hg.openjdk.java.net/shenandoah/jdk10
Compare against version:47960
Summary of changes: 1921 lines changed: 1848 ins; 10 del; 63 mod; 62035 unchg
Changeset: shenandoah-jdk10.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/hotspot/lib/JvmOverrideFiles.gmk

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 179 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/c1_Runtime1_x86.cpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 1811 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 11881 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/shenandoahBarrierSet_x86.cpp

rev 47961 : [mq]: traversal.patch
22 lines changed: 19 ins; 0 del; 3 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 5423 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 4461 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.hpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 2490 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

rev 47961 : [mq]: traversal.patch
7 lines changed: 3 ins; 0 del; 4 mod; 4025 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/barrierSet.hpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/gcCause.cpp

rev 47961 : [mq]: traversal.patch
3 lines changed: 3 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/gcCause.hpp

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp

rev 47961 : [mq]: traversal.patch
51 lines changed: 28 ins; 0 del; 23 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp

rev 47961 : [mq]: traversal.patch
4 lines changed: 2 ins; 0 del; 2 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.cpp

rev 47961 : [mq]: traversal.patch
105 lines changed: 103 ins; 0 del; 2 mod; 1580 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 1 ins; 1 del; 0 mod; 1090 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentThread.cpp

rev 47961 : [mq]: traversal.patch
29 lines changed: 29 ins; 0 del; 0 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahConcurrentThread.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp

rev 47961 : [mq]: traversal.patch
6 lines changed: 4 ins; 0 del; 2 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 47961 : [mq]: traversal.patch
90 lines changed: 89 ins; 0 del; 1 mod; 2721 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

rev 47961 : [mq]: traversal.patch
20 lines changed: 20 ins; 0 del; 0 mod; 661 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp

rev 47961 : [mq]: traversal.patch
4 lines changed: 4 ins; 0 del; 0 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 0 ins; 0 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp

rev 47961 : [mq]: traversal.patch
24 lines changed: 14 ins; 7 del; 3 mod; 842 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp

rev 47961 : [mq]: traversal.patch
45 lines changed: 45 ins; 0 del; 0 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahOopClosures.inline.hpp

rev 47961 : [mq]: traversal.patch
6 lines changed: 6 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.cpp

rev 47961 : [mq]: traversal.patch
39 lines changed: 39 ins; 0 del; 0 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp

rev 47961 : [mq]: traversal.patch
42 lines changed: 42 ins; 0 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp

rev 47961 : [mq]: traversal.patch
6 lines changed: 1 ins; 2 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp

rev 47961 : [mq]: traversal.patch
24 lines changed: 24 ins; 0 del; 0 mod; 1068 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp

rev 47961 : [mq]: traversal.patch
22 lines changed: 22 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.hpp

rev 47961 : [mq]: traversal.patch
8 lines changed: 8 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp

rev 47961 : [mq]: traversal.patch
6 lines changed: 6 ins; 0 del; 0 mod; 423 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/shenandoah_specialized_oop_closures.hpp

rev 47961 : [mq]: traversal.patch
5 lines changed: 5 ins; 0 del; 0 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.cpp

rev 47961 : [mq]: traversal.patch
11 lines changed: 11 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shenandoah/vm_operations_shenandoah.hpp

rev 47961 : [mq]: traversal.patch
18 lines changed: 18 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/graphKit.cpp

rev 47961 : [mq]: traversal.patch
112 lines changed: 107 ins; 0 del; 5 mod; 4902 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/opto/graphKit.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 990 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/sharedRuntime.cpp

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 3177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.cpp

rev 47961 : [mq]: traversal.patch
11 lines changed: 6 ins; 0 del; 5 mod; 4903 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/thread.hpp

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 2205 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/vm_operations.hpp

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 521 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/LotsOfCycles.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/ShenandoahStrDedupStress.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestGCThreadGroups.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestPeriodicGC.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestRegionSampling.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestSelectiveBarrierFlags.java

rev 47961 : [mq]: traversal.patch
1 line changed: 0 ins; 0 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/TestShenandoahStrDedup.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/AllocHumongousFragment.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/AllocIntArrays.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/AllocObjectArrays.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/AllocObjects.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/HeapUncommit.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/RetainObjects.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/SieveObjects.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/acceptance/StringInternCleanup.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/shenandoah/options/TestHeuristicsUnlock.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithShenandoah.java

rev 47961 : [mq]: traversal.patch
1 line changed: 1 ins; 0 del; 0 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithShenandoah.java

rev 47961 : [mq]: traversal.patch
2 lines changed: 2 ins; 0 del; 0 mod; 56 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp

rev 47961 : [mq]: traversal.patch
842 lines changed: 842 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.hpp

rev 47961 : [mq]: traversal.patch
97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.inline.hpp

rev 47961 : [mq]: traversal.patch
207 lines changed: 207 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).