Code Review for hotspot

Prepared by:roland on Wed Jun 3 18:22:04 CEST 2015
Workspace:/net/mackdrive/export/jrts/work/rw140007/jdk8u-repo/hotspot
Compare against: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot
Compare against version:7390
Summary of changes: 227 lines changed: 160 ins; 1 del; 66 mod; 26030 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/graphKit.cpp

rev 7390 : 8036851: volatile double accesses are not explicitly atomic in C2
Summary: The C2 structure is adapted to distinguish between volatile and non-volatile double accesses.
Reviewed-by: twisti, kvn
Contributed-by: Tobias Hartmann <tobias.hartmann@oracle.com>
rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
4 lines changed: 0 ins; 0 del; 4 mod; 4146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/graphKit.hpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
8 lines changed: 3 ins; 0 del; 5 mod; 941 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/library_call.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
4 lines changed: 2 ins; 0 del; 2 mod; 6628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/loopPredicate.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
7 lines changed: 6 ins; 0 del; 1 mod; 873 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
1 line changed: 0 ins; 0 del; 1 mod; 2622 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/memnode.cpp

rev 7390 : 8036851: volatile double accesses are not explicitly atomic in C2
Summary: The C2 structure is adapted to distinguish between volatile and non-volatile double accesses.
Reviewed-by: twisti, kvn
Contributed-by: Tobias Hartmann <tobias.hartmann@oracle.com>
rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
19 lines changed: 3 ins; 0 del; 16 mod; 4589 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/memnode.hpp

rev 7390 : 8036851: volatile double accesses are not explicitly atomic in C2
Summary: The C2 structure is adapted to distinguish between volatile and non-volatile double accesses.
Reviewed-by: twisti, kvn
Contributed-by: Tobias Hartmann <tobias.hartmann@oracle.com>
rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
58 lines changed: 27 ins; 1 del; 30 mod; 1456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/parse3.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
1 line changed: 0 ins; 0 del; 1 mod; 561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/superword.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
14 lines changed: 13 ins; 0 del; 1 mod; 2606 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/superword.hpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
1 line changed: 1 ins; 0 del; 0 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/vectornode.cpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
3 lines changed: 1 ins; 0 del; 2 mod; 441 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/vectornode.hpp

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
4 lines changed: 1 ins; 0 del; 3 mod; 635 unchg

------ ------ ------ ------ --- New Patch Raw test/compiler/unsafe/TestUnsafeLoadControl.java

rev 7391 : 8077504: Unsafe load can loose control dependency and cause crash
Summary: Node::depends_only_on_test() should return false for Unsafe loads
Reviewed-by: kvn, adinn
103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../c2-inlining/webrev.ksh (vers 23.18-hg-never-dev).