Code Review for open

Prepared by:rpressler on Fri May 18 19:38:55 BST 2018
Workspace:/Users/pron/Projects/loom/open
Compare against: http://hg.openjdk.java.net/loom/loom
Compare against version:50071
Summary of changes: 5715 lines changed: 5616 ins; 13 del; 86 mod; 124186 unchg
Changeset: open.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/hotspot/symbols/symbols-unix

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp

rev 50073 : [mq]: cont
17 lines changed: 17 ins; 0 del; 0 mod; 3999 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp

rev 50073 : [mq]: cont
45 lines changed: 45 ins; 0 del; 0 mod; 1488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/frame_x86.cpp

rev 50073 : [mq]: cont
7 lines changed: 3 ins; 0 del; 4 mod; 701 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/cpu/x86/frame_x86.hpp

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/frame_x86.inline.hpp

rev 50073 : [mq]: cont
2 lines changed: 2 ins; 0 del; 0 mod; 248 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.cpp

rev 50073 : [mq]: cont
58 lines changed: 58 ins; 0 del; 0 mod; 2043 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.hpp

rev 50073 : [mq]: cont
6 lines changed: 5 ins; 0 del; 1 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.cpp

rev 50073 : [mq]: cont
29 lines changed: 29 ins; 0 del; 0 mod; 11006 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

rev 50073 : [mq]: cont
7 lines changed: 7 ins; 0 del; 0 mod; 1752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp

rev 50073 : [mq]: cont
2 lines changed: 2 ins; 0 del; 0 mod; 3931 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

rev 50073 : [mq]: cont
222 lines changed: 216 ins; 2 del; 4 mod; 5149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp

rev 50073 : [mq]: cont
65 lines changed: 63 ins; 0 del; 2 mod; 1882 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateTable_x86.cpp

rev 50073 : [mq]: cont
11 lines changed: 11 ins; 0 del; 0 mod; 4514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/x86_64.ad

rev 50073 : [mq]: cont
14 lines changed: 14 ins; 0 del; 0 mod; 12447 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_Compiler.cpp

rev 50073 : [mq]: cont
6 lines changed: 6 ins; 0 del; 0 mod; 256 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.cpp

rev 50073 : [mq]: cont
12 lines changed: 12 ins; 0 del; 0 mod; 2064 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIR.hpp

rev 50073 : [mq]: cont
4 lines changed: 4 ins; 0 del; 0 mod; 2470 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRAssembler.cpp

rev 50073 : [mq]: cont
9 lines changed: 9 ins; 0 del; 0 mod; 861 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRAssembler.hpp

rev 50073 : [mq]: cont
3 lines changed: 3 ins; 0 del; 0 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.cpp

rev 50073 : [mq]: cont
24 lines changed: 24 ins; 0 del; 0 mod; 3613 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_LIRGenerator.hpp

rev 50073 : [mq]: cont
6 lines changed: 6 ins; 0 del; 0 mod; 677 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/c1/c1_Runtime1.cpp

rev 50073 : [mq]: cont
3 lines changed: 3 ins; 0 del; 0 mod; 1472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

rev 50073 : [mq]: cont
70 lines changed: 69 ins; 0 del; 1 mod; 4579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.hpp

rev 50073 : [mq]: cont
57 lines changed: 57 ins; 0 del; 0 mod; 1556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.inline.hpp

rev 50073 : [mq]: cont
67 lines changed: 67 ins; 0 del; 0 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

rev 50073 : [mq]: cont
4 lines changed: 4 ins; 0 del; 0 mod; 752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

rev 50073 : [mq]: cont
4 lines changed: 4 ins; 0 del; 0 mod; 1052 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

rev 50072 : imported patch loom-fibers
rev 50073 : [mq]: cont
47 lines changed: 44 ins; 0 del; 3 mod; 1629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/oopMap.cpp

rev 50073 : [mq]: cont
6 lines changed: 4 ins; 0 del; 2 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/gc/shared/space.inline.hpp

rev 50073 : [mq]: cont
1 line changed: 0 ins; 0 del; 1 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

rev 50073 : [mq]: cont
6 lines changed: 6 ins; 0 del; 0 mod; 1326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/abstractInterpreter.cpp

rev 50073 : [mq]: cont
18 lines changed: 18 ins; 0 del; 0 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/abstractInterpreter.hpp

rev 50073 : [mq]: cont
5 lines changed: 5 ins; 0 del; 0 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreter.cpp

rev 50073 : [mq]: cont
8 lines changed: 6 ins; 0 del; 2 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreter.hpp

rev 50073 : [mq]: cont
3 lines changed: 3 ins; 0 del; 0 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreterGenerator.cpp

rev 50073 : [mq]: cont
34 lines changed: 34 ins; 0 del; 0 mod; 487 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreterGenerator.hpp

rev 50073 : [mq]: cont
7 lines changed: 7 ins; 0 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/logging/logTag.hpp

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.cpp

rev 50073 : [mq]: cont
2 lines changed: 0 ins; 0 del; 2 mod; 2413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/method.hpp

rev 50073 : [mq]: cont
3 lines changed: 0 ins; 0 del; 3 mod; 1173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/oop.cpp

rev 50073 : [mq]: cont
4 lines changed: 4 ins; 0 del; 0 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

rev 50073 : [mq]: cont
6 lines changed: 6 ins; 0 del; 0 mod; 606 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/classes.hpp

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/intrinsicnode.hpp

rev 50073 : [mq]: cont
10 lines changed: 10 ins; 0 del; 0 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

rev 50073 : [mq]: cont
68 lines changed: 68 ins; 0 del; 0 mod; 7001 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/node.hpp

rev 50073 : [mq]: cont
2 lines changed: 2 ins; 0 del; 0 mod; 1726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

rev 50073 : [mq]: cont
23 lines changed: 23 ins; 0 del; 0 mod; 1667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.hpp

rev 50073 : [mq]: cont
4 lines changed: 4 ins; 0 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp

rev 50073 : [mq]: cont
7 lines changed: 7 ins; 0 del; 0 mod; 3678 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/frame.cpp

rev 50073 : [mq]: cont
15 lines changed: 14 ins; 0 del; 1 mod; 1384 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/frame.hpp

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/init.cpp

rev 50073 : [mq]: cont
2 lines changed: 2 ins; 0 del; 0 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os.cpp

rev 50073 : [mq]: cont
9 lines changed: 7 ins; 1 del; 1 mod; 1863 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/registerMap.hpp

rev 50073 : [mq]: cont
6 lines changed: 4 ins; 0 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

rev 50073 : [mq]: cont
10 lines changed: 10 ins; 0 del; 0 mod; 3155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.hpp

rev 50073 : [mq]: cont
3 lines changed: 3 ins; 0 del; 0 mod; 723 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.cpp

rev 50073 : [mq]: cont
30 lines changed: 26 ins; 1 del; 3 mod; 572 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.hpp

rev 50073 : [mq]: cont
20 lines changed: 19 ins; 0 del; 1 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 4987 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

rev 50073 : [mq]: cont
5 lines changed: 5 ins; 0 del; 0 mod; 2217 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/Object.java

rev 50072 : imported patch loom-fibers
13 lines changed: 12 ins; 0 del; 1 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/System.java

rev 50072 : imported patch loom-fibers
6 lines changed: 6 ins; 0 del; 0 mod; 2163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Thread.java

rev 50072 : imported patch loom-fibers
rev 50073 : [mq]: cont
152 lines changed: 121 ins; 6 del; 25 mod; 2099 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/ThreadLocal.java

rev 50072 : imported patch loom-fibers
15 lines changed: 11 ins; 1 del; 3 mod; 716 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/util/concurrent/locks/LockSupport.java

rev 50072 : imported patch loom-fibers
47 lines changed: 38 ins; 0 del; 9 mod; 422 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/jdk/internal/misc/JavaLangAccess.java

rev 50072 : imported patch loom-fibers
12 lines changed: 12 ins; 0 del; 0 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/Util.java

rev 50072 : imported patch loom-fibers
11 lines changed: 4 ins; 2 del; 5 mod; 515 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/fs/NativeBuffers.java

rev 50072 : imported patch loom-fibers
7 lines changed: 4 ins; 0 del; 3 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/Object.c

rev 50072 : imported patch loom-fibers
1 line changed: 0 ins; 0 del; 1 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/native/libjava/Thread.c

rev 50072 : imported patch loom-fibers
4 lines changed: 0 ins; 0 del; 4 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtx.java

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 3612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/javax/naming/spi/NamingManager.java

rev 50073 : [mq]: cont
2 lines changed: 0 ins; 0 del; 2 mod; 922 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsContext.java

rev 50073 : [mq]: cont
1 line changed: 1 ins; 0 del; 0 mod; 1089 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/continuation.cpp

rev 50073 : [mq]: cont
1751 lines changed: 1751 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/runtime/continuation.hpp

rev 50073 : [mq]: cont
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/Continuation.java

rev 50073 : [mq]: cont
391 lines changed: 391 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/lang/ContinuationScope.java

rev 50073 : [mq]: cont
32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.base/share/classes/java/lang/Fiber.java

rev 50072 : imported patch loom-fibers
717 lines changed: 717 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/native/libjava/Continuation.c

rev 50073 : [mq]: cont
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/java/lang/Fiber/Basic.java

rev 50072 : imported patch loom-fibers
1338 lines changed: 1338 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/pron/Projects/jdk/bin/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).