Code Review for jdk

Prepared by:rriggs on Tue Apr 4 10:27:49 EDT 2017
Workspace:/ws3/jdk9-dev-closed/jdk
Compare against version:-2
Summary of changes: 352 lines changed: 281 ins; 0 del; 71 mod; 67827 unchg
Patch of changes: jdk.patch
Bug id: JDK-8165641 : Deprecate Object.finalize
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/DESKey.java

2 lines changed: 1 ins; 0 del; 1 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/DESedeKey.java

2 lines changed: 1 ins; 0 del; 1 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java

2 lines changed: 1 ins; 0 del; 1 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileInputStream.java

11 lines changed: 10 ins; 0 del; 1 mod; 428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileOutputStream.java

10 lines changed: 9 ins; 0 del; 1 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

1 line changed: 1 ins; 0 del; 0 mod; 2897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Enum.java

2 lines changed: 1 ins; 0 del; 1 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Object.java

44 lines changed: 43 ins; 0 del; 1 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

1 line changed: 1 ins; 0 del; 0 mod; 2132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 777 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketInputStream.java

2 lines changed: 1 ins; 0 del; 1 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketOutputStream.java

2 lines changed: 1 ins; 0 del; 1 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Timer.java

2 lines changed: 1 ins; 0 del; 1 mod; 719 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/Executors.java

1 line changed: 1 ins; 0 del; 0 mod; 749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java

10 lines changed: 10 ins; 0 del; 0 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/Deflater.java

11 lines changed: 10 ins; 0 del; 1 mod; 572 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/Inflater.java

11 lines changed: 10 ins; 0 del; 1 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/ZipFile.java

11 lines changed: 11 ins; 0 del; 0 mod; 1333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java

2 lines changed: 1 ins; 0 del; 1 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/MeteredStream.java

2 lines changed: 1 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/https/DelegateHttpsURLConnection.java

2 lines changed: 1 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 1150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/KeyProtector.java

2 lines changed: 1 ins; 0 del; 1 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 668 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SunJSSE.java

2 lines changed: 1 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/apple/laf/JRSUIControl.java

2 lines changed: 1 ins; 0 del; 1 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java

1 line changed: 1 ins; 0 del; 0 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/font/CFont.java

1 line changed: 1 ins; 0 del; 0 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/font/CStrike.java

2 lines changed: 1 ins; 0 del; 1 mod; 587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CFRetainedResource.java

2 lines changed: 1 ins; 0 del; 1 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java

2 lines changed: 1 ins; 0 del; 1 mod; 812 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/common/SubImageInputStream.java

2 lines changed: 1 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java

3 lines changed: 2 ins; 0 del; 1 mod; 1278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFBaseJPEGCompressor.java

2 lines changed: 1 ins; 0 del; 1 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFJPEGDecompressor.java

2 lines changed: 1 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFOldJPEGDecompressor.java

2 lines changed: 1 ins; 0 del; 1 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/stream/StreamFinalizer.java

2 lines changed: 1 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/AbstractMidiDevice.java

2 lines changed: 1 ins; 0 del; 1 mod; 726 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Graphics.java

11 lines changed: 10 ins; 0 del; 1 mod; 1256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/PrintJob.java

11 lines changed: 10 ins; 0 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/color/ICC_Profile.java

11 lines changed: 10 ins; 0 del; 1 mod; 2076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/image/ColorModel.java

10 lines changed: 10 ins; 0 del; 0 mod; 1954 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/image/IndexColorModel.java

10 lines changed: 10 ins; 0 del; 0 mod; 1632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java

12 lines changed: 11 ins; 0 del; 1 mod; 900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileCacheImageInputStream.java

11 lines changed: 10 ins; 0 del; 1 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileImageInputStream.java

11 lines changed: 10 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileImageOutputStream.java

11 lines changed: 10 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/ImageInputStreamImpl.java

11 lines changed: 10 ins; 0 del; 1 mod; 879 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/MemoryCacheImageInputStream.java

11 lines changed: 10 ins; 0 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/StringContent.java

2 lines changed: 1 ins; 0 del; 1 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/image/BufImgSurfaceData.java

2 lines changed: 1 ins; 0 del; 1 mod; 481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java

2 lines changed: 1 ins; 0 del; 1 mod; 3657 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/pipe/RegionClipSpanIterator.java

2 lines changed: 1 ins; 0 del; 1 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/PeekGraphics.java

2 lines changed: 1 ins; 0 del; 1 mod; 1915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/PrintJob2D.java

2 lines changed: 1 ins; 0 del; 1 mod; 1279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/ProxyGraphics.java

2 lines changed: 1 ins; 0 del; 1 mod; 1156 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/ProxyGraphics2D.java

2 lines changed: 1 ins; 0 del; 1 mod; 1619 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11InputMethod.java

2 lines changed: 1 ins; 0 del; 1 mod; 1095 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WInputMethod.java

2 lines changed: 1 ins; 0 del; 1 mod; 647 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java

2 lines changed: 1 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/LdapClient.java

2 lines changed: 1 ins; 0 del; 1 mod; 1616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtx.java

2 lines changed: 1 ins; 0 del; 1 mod; 3592 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java

2 lines changed: 1 ins; 0 del; 1 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/log/LogInputStream.java

2 lines changed: 1 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java

2 lines changed: 1 ins; 0 del; 1 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCredElement.java

2 lines changed: 1 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSNameElement.java

2 lines changed: 1 ins; 0 del; 1 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/NativeGSSContext.java

2 lines changed: 1 ins; 0 del; 1 mod; 629 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/com/sun/security/sasl/CramMD5Base.java

2 lines changed: 1 ins; 0 del; 1 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/com/sun/security/sasl/PlainClient.java

2 lines changed: 1 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java

2 lines changed: 1 ins; 0 del; 1 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java

2 lines changed: 1 ins; 0 del; 1 mod; 2682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

2 lines changed: 1 ins; 0 del; 1 mod; 1826 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/Key.java

2 lines changed: 1 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.le/share/classes/jdk/internal/jline/console/ConsoleReader.java

1 line changed: 1 ins; 0 del; 0 mod; 4042 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java

2 lines changed: 1 ins; 0 del; 1 mod; 736 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java

4 lines changed: 3 ins; 0 del; 1 mod; 638 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java

2 lines changed: 1 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java

1 line changed: 1 ins; 0 del; 0 mod; 2529 unchg

This code review page was prepared using /home/rriggs/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).