Code Review for jdk

Prepared by:rriggs on Wed Mar 15 10:49:14 EDT 2017
Workspace:/ws3/jdk9-dev-closed/jdk
Compare against version:-2
Summary of changes: 132 lines changed: 132 ins; 0 del; 0 mod; 67823 unchg
Patch of changes: jdk.patch
Bug id: JDK-8165641 : Deprecate Object.finalize
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/DESKey.java

1 line changed: 1 ins; 0 del; 0 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/DESedeKey.java

1 line changed: 1 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java

1 line changed: 1 ins; 0 del; 0 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileInputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileOutputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ClassLoader.java

1 line changed: 1 ins; 0 del; 0 mod; 2897 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Enum.java

1 line changed: 1 ins; 0 del; 0 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Object.java

11 lines changed: 11 ins; 0 del; 0 mod; 570 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

1 line changed: 1 ins; 0 del; 0 mod; 2057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainDatagramSocketImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketInputStream.java

1 line changed: 1 ins; 0 del; 0 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketOutputStream.java

1 line changed: 1 ins; 0 del; 0 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Timer.java

1 line changed: 1 ins; 0 del; 0 mod; 720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/Executors.java

1 line changed: 1 ins; 0 del; 0 mod; 749 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java

3 lines changed: 3 ins; 0 del; 0 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/Deflater.java

3 lines changed: 3 ins; 0 del; 0 mod; 573 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/Inflater.java

3 lines changed: 3 ins; 0 del; 0 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/ZipFile.java

5 lines changed: 5 ins; 0 del; 0 mod; 1333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java

1 line changed: 1 ins; 0 del; 0 mod; 498 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/MeteredStream.java

1 line changed: 1 ins; 0 del; 0 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/https/DelegateHttpsURLConnection.java

1 line changed: 1 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 1151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/KeyProtector.java

1 line changed: 1 ins; 0 del; 0 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/BaseSSLSocketImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 669 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SunJSSE.java

1 line changed: 1 ins; 0 del; 0 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/apple/laf/JRSUIControl.java

1 line changed: 1 ins; 0 del; 0 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java

1 line changed: 1 ins; 0 del; 0 mod; 223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/font/CFont.java

1 line changed: 1 ins; 0 del; 0 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/font/CStrike.java

1 line changed: 1 ins; 0 del; 0 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CFRetainedResource.java

1 line changed: 1 ins; 0 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java

1 line changed: 1 ins; 0 del; 0 mod; 813 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/common/SubImageInputStream.java

1 line changed: 1 ins; 0 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java

2 lines changed: 2 ins; 0 del; 0 mod; 1279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFBaseJPEGCompressor.java

1 line changed: 1 ins; 0 del; 0 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFJPEGDecompressor.java

1 line changed: 1 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFOldJPEGDecompressor.java

1 line changed: 1 ins; 0 del; 0 mod; 617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/imageio/stream/StreamFinalizer.java

1 line changed: 1 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/media/sound/AbstractMidiDevice.java

1 line changed: 1 ins; 0 del; 0 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/Graphics.java

3 lines changed: 3 ins; 0 del; 0 mod; 1257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/PrintJob.java

3 lines changed: 3 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/color/ICC_Profile.java

3 lines changed: 3 ins; 0 del; 0 mod; 2077 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/image/ColorModel.java

3 lines changed: 3 ins; 0 del; 0 mod; 1954 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/image/IndexColorModel.java

3 lines changed: 3 ins; 0 del; 0 mod; 1632 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java

4 lines changed: 4 ins; 0 del; 0 mod; 901 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileCacheImageInputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileImageInputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/FileImageOutputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/ImageInputStreamImpl.java

3 lines changed: 3 ins; 0 del; 0 mod; 880 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/imageio/stream/MemoryCacheImageInputStream.java

3 lines changed: 3 ins; 0 del; 0 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/text/StringContent.java

1 line changed: 1 ins; 0 del; 0 mod; 504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/image/BufImgSurfaceData.java

1 line changed: 1 ins; 0 del; 0 mod; 482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java

1 line changed: 1 ins; 0 del; 0 mod; 3658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/pipe/RegionClipSpanIterator.java

1 line changed: 1 ins; 0 del; 0 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/PeekGraphics.java

1 line changed: 1 ins; 0 del; 0 mod; 1916 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/PrintJob2D.java

1 line changed: 1 ins; 0 del; 0 mod; 1280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/ProxyGraphics.java

1 line changed: 1 ins; 0 del; 0 mod; 1157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/print/ProxyGraphics2D.java

1 line changed: 1 ins; 0 del; 0 mod; 1620 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/X11InputMethod.java

1 line changed: 1 ins; 0 del; 0 mod; 1096 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/windows/classes/sun/awt/windows/WInputMethod.java

1 line changed: 1 ins; 0 del; 0 mod; 648 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java

1 line changed: 1 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/LdapClient.java

1 line changed: 1 ins; 0 del; 0 mod; 1617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtx.java

1 line changed: 1 ins; 0 del; 0 mod; 3593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java

1 line changed: 1 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/log/LogInputStream.java

1 line changed: 1 ins; 0 del; 0 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java

1 line changed: 1 ins; 0 del; 0 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSCredElement.java

1 line changed: 1 ins; 0 del; 0 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/GSSNameElement.java

1 line changed: 1 ins; 0 del; 0 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/wrapper/NativeGSSContext.java

1 line changed: 1 ins; 0 del; 0 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/com/sun/security/sasl/CramMD5Base.java

1 line changed: 1 ins; 0 del; 0 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.sasl/share/classes/com/sun/security/sasl/PlainClient.java

1 line changed: 1 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java

1 line changed: 1 ins; 0 del; 0 mod; 2683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java

1 line changed: 1 ins; 0 del; 0 mod; 1827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/Key.java

1 line changed: 1 ins; 0 del; 0 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.internal.le/share/classes/jdk/internal/jline/console/ConsoleReader.java

1 line changed: 1 ins; 0 del; 0 mod; 4042 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.naming.dns/share/classes/com/sun/jndi/dns/DnsClient.java

1 line changed: 1 ins; 0 del; 0 mod; 737 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java

3 lines changed: 3 ins; 0 del; 0 mod; 639 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java

1 line changed: 1 ins; 0 del; 0 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java

1 line changed: 1 ins; 0 del; 0 mod; 2529 unchg

This code review page was prepared using /home/rriggs/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).