Code Review for open

Prepared by:rriggs on Tue Dec 5 14:59:11 EST 2017
Workspace:/ws3/jdk-dev/open
Compare against version:-2
Summary of changes: 1039 lines changed: 889 ins; 46 del; 104 mod; 6773 unchg
Patch of changes: open.patch
Bug id: JDK-8080225 : FileInput/OutputStream/FileChannel cleanup should be improved
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/mapfile-vers

1 line changed: 0 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileInputStream.java

97 lines changed: 86 ins; 1 del; 10 mod; 428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileOutputStream.java

129 lines changed: 107 ins; 20 del; 2 mod; 446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/RandomAccessFile.java

1 line changed: 1 ins; 0 del; 0 mod; 1194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketInputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/SocketOutputStream.java

1 line changed: 0 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaIOFileDescriptorAccess.java

3 lines changed: 2 ins; 0 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

12 lines changed: 10 ins; 0 del; 2 mod; 1298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/io/FileDescriptor.java

106 lines changed: 103 ins; 0 del; 3 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libjava/FileDescriptor_md.c

10 lines changed: 9 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/native/libjava/io_util_md.c

5 lines changed: 5 ins; 0 del; 0 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/io/FileDescriptor.java

112 lines changed: 105 ins; 2 del; 5 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/FileDispatcherImpl.java

1 line changed: 1 ins; 0 del; 0 mod; 199 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java

3 lines changed: 0 ins; 2 del; 1 mod; 733 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/fs/WindowsChannelFactory.java

3 lines changed: 1 ins; 1 del; 1 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libjava/FileDescriptor_md.c

11 lines changed: 9 ins; 0 del; 2 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c

10 lines changed: 0 ins; 10 del; 0 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/provider/FileInputStreamPool/FileInputStreamPoolTest.java

57 lines changed: 43 ins; 2 del; 12 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/FileInputStream/UnreferencedFISClosesFd.java (was test/jdk/java/io/FileInputStream/FinalizeShdCallClose.java)

193 lines changed: 161 ins; 4 del; 28 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/io/FileOutputStream/UnreferencedFOSClosesFd.java (was test/jdk/java/io/FileOutputStream/FinalizeShdCallClose.java)

187 lines changed: 150 ins; 4 del; 33 mod; 53 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/io/RandomAccessFile/UnreferencedRAFClosesFd.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rriggs/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).