src/java.management/share/classes/javax/management/MBeanPermission.java

rev 52881 : 8214971: Replace use of string.equals("") with isEmpty()
Reviewed-by: jlaskey, prappo, lancea, dfuchs, redestad

@@ -254,11 +254,11 @@
         int mask;
 
         if (actions == null)
             throw new IllegalArgumentException("MBeanPermission: " +
                                                "actions can't be null");
-        if (actions.equals(""))
+        if (actions.isEmpty())
             throw new IllegalArgumentException("MBeanPermission: " +
                                                "actions can't be empty");
 
         mask = getMask(actions);
 

@@ -277,11 +277,11 @@
 
         if (name == null)
             throw new IllegalArgumentException("MBeanPermission name " +
                                                "cannot be null");
 
-        if (name.equals(""))
+        if (name.isEmpty())
             throw new IllegalArgumentException("MBeanPermission name " +
                                                "cannot be empty");
 
         /* The name looks like "class#member[objectname]".  We subtract
            elements from the right as we parse, so after parsing the

@@ -308,11 +308,11 @@
                 try {
                     // If "[]" then ObjectName("*:*")
                     //
                     String on = name.substring(openingBracket + 1,
                                                name.length() - 1);
-                    if (on.equals(""))
+                    if (on.isEmpty())
                         objectName = ObjectName.WILDCARD;
                     else if (on.equals("-"))
                         objectName = null;
                     else
                         objectName = new ObjectName(on);

@@ -357,11 +357,11 @@
 
     private void setClassName(String className) {
         if (className == null || className.equals("-")) {
             classNamePrefix = null;
             classNameExactMatch = false;
-        } else if (className.equals("") || className.equals("*")) {
+        } else if (className.isEmpty() || className.equals("*")) {
             classNamePrefix = "";
             classNameExactMatch = false;
         } else if (className.endsWith(".*")) {
             // Note that we include the "." in the required prefix
             classNamePrefix = className.substring(0, className.length() - 1);

@@ -373,11 +373,11 @@
     }
 
     private void setMember(String member) {
         if (member == null || member.equals("-"))
             this.member = null;
-        else if (member.equals(""))
+        else if (member.isEmpty())
             this.member = "*";
         else
             this.member = member;
     }