Code Review for valhalla

Prepared by:srikanth on Wed Jul 11 15:58:39 IST 2018
Workspace:/home/srikanth/valhalla/valhalla
Branch:lworld
Summary of changes: 723 lines changed: 704 ins; 8 del; 11 mod; 17535 unchg
Patch of changes: valhalla.patch
Bug id: <title>[JDK-8198749] [lworld] Translation of value constructors in classic constructor notation - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

6 lines changed: 6 ins; 0 del; 0 mod; 2193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java

7 lines changed: 6 ins; 0 del; 1 mod; 5315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java

1 line changed: 0 ins; 0 del; 1 mod; 2485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java

6 lines changed: 6 ins; 0 del; 0 mod; 2396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java

3 lines changed: 3 ins; 0 del; 0 mod; 3161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java

25 lines changed: 25 ins; 0 del; 0 mod; 1092 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java

9 lines changed: 9 ins; 0 del; 0 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ConstantPropagationTest.java

8 lines changed: 0 ins; 8 del; 0 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ValueCreationTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ValueTypesAttributeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/WithFieldOfExplicitSelector.java

3 lines changed: 0 ins; 0 del; 3 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/WithFieldOfImplicitThis.java

2 lines changed: 0 ins; 0 del; 2 mod; 98 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/TransValues.java

395 lines changed: 395 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/InnerValueNew.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/LocalValueNew.java

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/QualifiedThisTest.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ValueConstructorRef.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/valhalla/lworld-values/ValueNewReadWrite.java

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/srikanth/bin/webrev (vers 25.7-hg+openjdk.java.net).