Code Review for jmc

Prepared by:sballal on Thu Jul 12 21:41:38 IST 2018
Workspace:/cygdrive/d/clients/jmc_2/jmc
Summary of changes: 5593 lines changed: 518 ins; 403 del; 4672 mod; 60058 unchg
Patch of changes: jmc.patch
Bug id: JMC-5895 : JFR in JDK 11 changed event paths from 'com.oracle.jdk' to 'jdk', and type paths from 'com.oracle.jfr.types' to 'jdk.types'
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/FlightRecordingLoader.java

4 lines changed: 3 ins; 0 del; 1 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java

57 lines changed: 52 ins; 0 del; 5 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkTypeIDs.java

3 lines changed: 0 ins; 0 del; 3 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SettingsTransformer.java

56 lines changed: 19 ins; 1 del; 36 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java

2 lines changed: 1 ins; 0 del; 1 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml

25 lines changed: 0 ins; 0 del; 25 mod; 3504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/java/org/openjdk/jmc/flightrecorder/test/FilteredRecordingTest.java

1 line changed: 0 ins; 0 del; 1 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/7u40.jfr.txt

468 lines changed: 0 ins; 0 del; 468 mod; 3439 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/7u60.jfr.txt

468 lines changed: 0 ins; 0 del; 468 mod; 3406 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/7u76.jfr.txt

469 lines changed: 0 ins; 0 del; 469 mod; 3493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/8u0.jfr.txt

443 lines changed: 0 ins; 0 del; 443 mod; 3322 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/8u20.jfr.txt

506 lines changed: 0 ins; 0 del; 506 mod; 3752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/8u40.jfr.txt

792 lines changed: 0 ins; 0 del; 792 mod; 10579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/8u60.jfr.txt

476 lines changed: 0 ins; 0 del; 476 mod; 4238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw core/tests/org.openjdk.jmc.flightrecorder.test/src/test/resources/printouts/9u0.jfr.txt

978 lines changed: 0 ins; 0 del; 978 mod; 22759 unchg

------ ------ ------ ------ --- New Patch Raw core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java

443 lines changed: 443 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk9.java

402 lines changed: 0 ins; 402 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/d/VM_share/webrev-a6f5faf6bf32/webrev.ksh (vers 25.17-hg+openjdk.java.net).