Code Review for jdk

Prepared by:serb on Mon Aug 21 15:09:49 PDT 2017
Workspace:/Users/sbylokho/moe/ws/jdk/10/work/jdk
Summary of changes: 785 lines changed: 211 ins; 59 del; 515 mod; 11691 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/InvalidMidiDataException.java

4 lines changed: 3 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MetaMessage.java

3 lines changed: 0 ins; 0 del; 3 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiDevice.java

22 lines changed: 5 ins; 0 del; 17 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiDeviceReceiver.java

5 lines changed: 2 ins; 0 del; 3 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiDeviceTransmitter.java

5 lines changed: 2 ins; 0 del; 3 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiFileFormat.java

42 lines changed: 1 ins; 6 del; 35 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiMessage.java

12 lines changed: 0 ins; 0 del; 12 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiSystem.java

114 lines changed: 79 ins; 6 del; 29 mod; 1403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/MidiUnavailableException.java

4 lines changed: 3 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/Receiver.java

2 lines changed: 0 ins; 0 del; 2 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/Sequencer.java

21 lines changed: 3 ins; 0 del; 18 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/ShortMessage.java

4 lines changed: 0 ins; 1 del; 3 mod; 485 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/SoundbankResource.java

19 lines changed: 0 ins; 0 del; 19 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/Synthesizer.java

3 lines changed: 0 ins; 0 del; 3 mod; 385 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/SysexMessage.java

9 lines changed: 2 ins; 0 del; 7 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/Track.java

7 lines changed: 4 ins; 0 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/Transmitter.java

2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/VoiceStatus.java

2 lines changed: 0 ins; 0 del; 2 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/spi/MidiFileReader.java

18 lines changed: 1 ins; 0 del; 17 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/spi/MidiFileWriter.java

3 lines changed: 0 ins; 1 del; 2 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/spi/SoundbankReader.java

7 lines changed: 1 ins; 1 del; 5 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/midi/spi/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/AudioFileFormat.java

47 lines changed: 7 ins; 8 del; 32 mod; 355 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/AudioFormat.java

56 lines changed: 11 ins; 5 del; 40 mod; 602 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/AudioInputStream.java

11 lines changed: 1 ins; 1 del; 9 mod; 526 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/AudioPermission.java

29 lines changed: 3 ins; 4 del; 22 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/AudioSystem.java

93 lines changed: 25 ins; 8 del; 60 mod; 1432 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/BooleanControl.java

3 lines changed: 0 ins; 0 del; 3 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/Clip.java

5 lines changed: 0 ins; 0 del; 5 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/CompoundControl.java

3 lines changed: 0 ins; 1 del; 2 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/Control.java

14 lines changed: 7 ins; 1 del; 6 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/DataLine.java

25 lines changed: 13 ins; 1 del; 11 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/Line.java

12 lines changed: 1 ins; 0 del; 11 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/LineEvent.java

29 lines changed: 12 ins; 2 del; 15 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/LineUnavailableException.java

4 lines changed: 3 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/Mixer.java

21 lines changed: 0 ins; 2 del; 19 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/Port.java

23 lines changed: 16 ins; 0 del; 7 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/ReverbType.java

62 lines changed: 2 ins; 10 del; 50 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/SourceDataLine.java

2 lines changed: 1 ins; 1 del; 0 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/UnsupportedAudioFileException.java

6 lines changed: 3 ins; 0 del; 3 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/spi/AudioFileReader.java

19 lines changed: 0 ins; 0 del; 19 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/spi/AudioFileWriter.java

5 lines changed: 0 ins; 0 del; 5 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/sound/sampled/spi/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

This code review page was prepared using /Users/sbylokho/moe/ws/tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).