# HG changeset patch # User serb # Date 1575631455 28800 # Fri Dec 06 03:24:15 2019 -0800 # Node ID e07a60855a7631b5eac32da1f1e71d72986a2c06 # Parent 221a47a6f6d335560d9dd532a1ac593e316b5954 8234522: [macos] Crash with use of native file dialog Reviewed-by: XXX diff --git a/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m b/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m --- a/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m +++ b/src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2011, 2019, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -50,7 +50,7 @@ * Subtypes of NSApplicationDefined, which are used for custom events. */ enum { - ExecuteBlockEvent, NativeSyncQueueEvent + ExecuteBlockEvent = 777, NativeSyncQueueEvent }; @implementation NSApplicationAWT @@ -366,11 +366,14 @@ { if ([event type] == NSApplicationDefined && TS_EQUAL([event timestamp], dummyEventTimestamp) - && [event subtype] == NativeSyncQueueEvent) { + && (short)[event subtype] == NativeSyncQueueEvent + && [event data1] == NativeSyncQueueEvent + && [event data2] == NativeSyncQueueEvent) { [seenDummyEventLock lockWhenCondition:NO]; [seenDummyEventLock unlockWithCondition:YES]; - - } else if ([event type] == NSApplicationDefined && [event subtype] == ExecuteBlockEvent) { + } else if ([event type] == NSApplicationDefined + && (short)[event subtype] == ExecuteBlockEvent + && [event data1] != 0 && [event data2] == ExecuteBlockEvent) { void (^block)() = (void (^)()) [event data1]; block(); [block release]; @@ -401,7 +404,7 @@ context: nil subtype: ExecuteBlockEvent data1: encode - data2: 0]; + data2: ExecuteBlockEvent]; [NSApp postEvent: event atStart: NO]; [pool drain]; @@ -419,8 +422,8 @@ windowNumber: 0 context: nil subtype: NativeSyncQueueEvent - data1: 0 - data2: 0]; + data1: NativeSyncQueueEvent + data2: NativeSyncQueueEvent]; if (useCocoa) { [NSApp postEvent:event atStart:NO]; } else { diff --git a/test/jdk/java/awt/FileDialog/MacOSGoToFolderCrash.java b/test/jdk/java/awt/FileDialog/MacOSGoToFolderCrash.java new file mode 100644 --- /dev/null +++ b/test/jdk/java/awt/FileDialog/MacOSGoToFolderCrash.java @@ -0,0 +1,62 @@ +/* + * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +import java.awt.EventQueue; +import java.awt.FileDialog; +import java.awt.Frame; +import java.awt.Robot; +import java.awt.event.KeyEvent; + +/** + * @test + * @key headful + * @bug 8234522 + * @requires (os.family == "mac") + */ +public final class MacOSGoToFolderCrash { + + public static void main(final String[] args) throws Exception { + EventQueue.invokeLater(() -> { + FileDialog fd = new FileDialog((Frame) null); + fd.setVisible(true); + }); + Robot robot = new Robot(); + robot.setAutoDelay(400); + robot.waitForIdle(); + // "⌘+Shift+G" – Open "Go To Folder" window + robot.keyPress(KeyEvent.VK_META); + robot.keyPress(KeyEvent.VK_SHIFT); + robot.keyPress(KeyEvent.VK_G); + robot.keyRelease(KeyEvent.VK_G); + robot.keyRelease(KeyEvent.VK_SHIFT); + robot.keyRelease(KeyEvent.VK_META); + // Select something + robot.keyPress(KeyEvent.VK_DOWN); + robot.keyRelease(KeyEvent.VK_DOWN); + robot.keyPress(KeyEvent.VK_ENTER); + robot.keyRelease(KeyEvent.VK_ENTER); + // Close File dialog + robot.keyPress(KeyEvent.VK_ESCAPE); + robot.keyRelease(KeyEvent.VK_ESCAPE); + } +}