Code Review for hotspot

Prepared by:sgehwolf on Mon Nov 2 11:00:25 CET 2015
Workspace:/home/sgehwolf/Documents/openjdk/upstream-sources/openjdk9-hs-rt/hotspot
Compare against: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot
Compare against version:4d7995577f52
Summary of changes: 7 lines changed: 7 ins; 0 del; 0 mod; 1519 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/diagnosticCommand.cpp

@    rev 9199 : 6425769: jmx remote bind address
|\   Summary: Allow for binding to a specific address via custom socket factories.
| \
| |\
| | \
| | |\
| | | \
| | | |\
| | | | \
| | | | |\
| | | | | \
| | | | | |\
| | | | | | \
| | | | | | |\
| | | | | | | \
| | | | | | | |\
| | | | | | | | \
| | | | | | | | |\
| | | | | | | | | \
| | | | | | | | | |\
| | | | | | | | | | \
| | | | | | | | | | |\
| | | | | | | | | | | \
| | | | | | | | | | | |\
| | | | | | | | | | | | \
| | | | | | | | | | | | |\
| | | | | | | | | | | | | \
| | | | | | | | | | | | | |\
| | | | | | | | | | | | | | \
| | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |\
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 9086 : 8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   8042894: runtime: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: goetz, brutisso
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8769 : 8059036: Implement Diagnostic Commands for heap and finalizerinfo
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Summary: Implement Diagnostic Commands for heap and finalizerinfo
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: sla, plevart, mchung
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8696 : 8025692: Log what methods are touched at run-time
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Summary: Added two diagnostic flags, LogTouchedMethods and PrintTouchedMethodsAtExit to list all methods that have been touched at run time. Added new jcmd, VM.print_touched_methods.
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: acorn, iklam
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8550 : 8122937: [JEP 245] Validate JVM Command-Line Flag Arguments.
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Summary: Validate the arguments to all JVM command-line flags so as to avoid crashes, and ensure that appropriate error messages are displayed when they are invalid.
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: ddmitriev, dholmes, kbarrett, drwhite, brutisso, coleenp
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8470 : 8072913: [REDO] GCCause should distinguish jcmd GC.run from System.gc()
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Summary: GCCause which is caused by GC.run diagnostic command should be different from System.gc() .
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: jmasa, jwilhelm
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8410 : 8079792: GC directory structure cleanup
| | | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Reviewed-by: brutisso, stefank, david
| | | | | | | | | | | | | | | | | | | | | | | | | | | | o  rev 8072 : 8023093: Add ManagementAgent.status diagnostic command
| | | | | | | | | | | | | | | | | | | | | | | | | | | |/   Reviewed-by: sla
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8059 : 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'
| | | | | | | | | | | | | | | | | | | | | | | | | | |/   Reviewed-by: sla, fparain, egahlin, ykantser
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7876 : Merge
| | | | | | | | | | | | | | | | | | | | | | | | | |/
| | | | | | | | | | | | | | | | | | | | | | | +---o  rev 7872 : 8072911: Remove includes of oop.inline.hpp from .hpp files
| | | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: brutisso, coleenp, jwilhelm, simonis, dholmes
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7865 : Merge
| | | | | | | | | | | | | | | | | | | | | | | |/|
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7847 : 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy
| | | | | | | | | | | | | | | | | | | | | | | |    Summary: Added the VM.class_hierarhcy DCMD
| | | | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: stefank, miauno
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7818 : 8072693: [BACKOUT] GCCause should distinguish jcmd GC.run from System.gc()
| | | | | | | | | | | | | | | | | | | | | | |/   Reviewed-by: jwilhelm, tschatzl
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7812 : 8068589: GCCause should distinguish jcmd GC.run from System.gc()
| | | | | | | | | | | | | | | | | | | | | |/   Summary: GCCause which is caused by GC.run diagnostic command should be different from System.gc() .
| | | | | | | | | | | | | | | | | | | | | |    Reviewed-by: sla, tamao
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7623 : 8059510: Compact symbol table layout inside shared archive.
| | | | | | | | | | | | | | | | | | | | |/   Summary: Use separate compact table for shared symbols.
| | | | | | | | | | | | | | | | | | | | |    Reviewed-by: iklam, gziemski, shade, sla, jrose
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7010 : 8054889: Compiler team's implementation task
| | | | | | | | | | | | | | | | | | | |/   Summary: Adding three new diagnostic commands for compiler
| | | | | | | | | | | | | | | | | | | |    Reviewed-by: anoll, kvn, drchase
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 6581 : 8044107: Add Diagnostic Command to list all ClassLoaders
| | | | | | | | | | | | | | | | | | |/   Reviewed-by: mgerdin, stefank
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 6412 : 8037816: Fix for 8036122 breaks build with Xcode5/clang
| | | | | | | | | | | | | | | | | |/   Summary: Repaired or selectively disabled offending formats; future-proofed with additional checking
| | | | | | | | | | | | | | | | | |    Reviewed-by: kvn, jrose, stefank
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 6215 : 7090324: gclog rotation via external tool
| | | | | | | | | | | | | | | | |/   Summary: GC log rotation can be set via java command line, but customer sometime need to sync with OS level rotation setting.
| | | | | | | | | | | | | | | | |    Reviewed-by: sla, minqi, ehelin
| | | | | | | | | | | | | | | | |    Contributed-by: suenaga.yasumasa@lab.ntt.co.jp
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 5808 : 8031304: Add dcmd to print all loaded dynamic libraries.
| | | | | | | | | | | | | | | |/   Summary: Adding VM.dynlibs as a dcmd to dump all loaded dynamic libraries.
| | | | | | | | | | | | | | | |    Reviewed-by: sla, fparain, mgronlun, dsamersoff
+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 5578 : Merge
| | | | | | | | | | | | | | |/
+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 5533 : 8026930: In ManagementAgent.start it should be possible to set the jdp.name parameter (hotspot part)
| | | | | | | | | | | | | |    Summary: Pass one more property from Agent to JdpController
| | | | | | | | | | | | | |    Reviewed-by: jbachorik, sla
+-+-+-+-+-+-+-+-+-+-+-+---o  rev 5439 : 8020789: Disable exporting of gc.heap_dump diagnostic command
| | | | | | | | | | | | |/   Reviewed-by: fparain, ahgross
+-+-+-+-+-+-+-+-+-+-+---o  rev 4802 : 8005849: JEP 167: Event-Based JVM Tracing
| | | | | | | | | | | |/   Reviewed-by: acorn, coleenp, sla
| | | | | | | | | | | |    Contributed-by: Karen Kinnear <karen.kinnear@oracle.com>, Bengt Rutisson <bengt.rutisson@oracle.com>, Calvin Cheung <calvin.cheung@oracle.com>, Erik Gahlin <erik.gahlin@oracle.com>, Erik Helin <erik.helin@oracle.com>, Jesper Wilhelmsson <jesper.wilhelmsson@oracle.com>, Keith McGuigan <keith.mcguigan@oracle.com>, Mattias Tobiasson <mattias.tobiasson@oracle.com>, Markus Gronlund <markus.gronlund@oracle.com>, Mikael Auno <mikael.auno@oracle.com>, Nils Eliasson <nils.eliasson@oracle.com>, Nils Loodin <nils.loodin@oracle.com>, Rickard Backman <rickard.backman@oracle.com>, Staffan Larsen <staffan.larsen@oracle.com>, Stefan Karlsson <stefan.karlsson@oracle.com>, Yekaterina Kantserova <yekaterina.kantserova@oracle.com>
+-+-+-+-+-+-+-+-+-+---o  rev 4612 : 8004095: Add support for JMX interface to Diagnostic Framework and Commands
| | | | | | | | | | |/   Reviewed-by: acorn, sla
+-+-+-+-+-+-+-+-+---o  rev 4109 : Merge
| | | | | | | | | |/
+-+-+-+-+-+-+-----o  rev 4107 : 8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
| | | | | | | | |    Summary: Rename INCLUDE_ALTERNATE_GCS to INCLUDE_ALL_GCS and replace SERIALGC with INCLUDE_ALL_GCS.
| | | | | | | | |    Reviewed-by: coleenp, stefank
+-+-+-+-+-+-+---o  rev 4085 : 8002048: Protocol to discovery of manageable Java processes on a network
| | | | | | | |/   Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP
| | | | | | | |    Reviewed-by: sla, dfuchs
+-+-+-+-+-+---o  rev 4062 : 6479360: PrintClassHistogram improvements
| | | | | | |/   Summary: jcmd <pid> GC.class_stats (UnlockDiagnosticVMOptions)
| | | | | | |    Reviewed-by: coleenp, hseigel, sla, acorn
| | | | | | |    Contributed-by: ioi.lam@oracle.com
+-+-+-+-+---o  rev 3732 : Merge
| | | | | |/|
+-+-+-+-+---o  rev 3730 : 7189254: Change makefiles for more flexibility to override defaults
| | | | | |    Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles.
| | | | | |    Reviewed-by: dholmes, coleenp
+-+-+-+---o  rev 3707 : 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass
| | | | |/   Summary: Capitalize these metadata types (and objArrayKlass)
| | | | |    Reviewed-by: stefank, twisti, kvn
+-+-+---o  rev 3602 : 6964458: Reimplement class meta-data storage to use native memory
| | | |/   Summary: Remove PermGen, allocate meta-data in metaspace linked to class loaders, rewrite GC walking, rewrite and rename metadata to be C++ classes
| | | |    Reviewed-by: jmasa, stefank, never, coleenp, kvn, brutisso, mgerdin, dholmes, jrose, twisti, roland
| | | |    Contributed-by: jmasa <jon.masamitsu@oracle.com>, stefank <stefan.karlsson@oracle.com>, mgerdin <mikael.gerdin@oracle.com>, never <tom.rodriguez@oracle.com>
+-+---o  rev 3163 : 7110104: It should be possible to stop and start JMX Agent at runtime
| | |/   Summary: Added a capability to start and stop JMX Agent by jcmd
| | |    Reviewed-by: acorn, mchung
+---o  rev 3043 : 7132515: Add dcmd to manage UnlockingCommercialFeature flag
| |/   Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature flag
| |    Reviewed-by: fparain, rottenha
| o  rev 2967 : 7120511: Add diagnostic commands
|/   Reviewed-by: acorn, phh, dcubed, sspitsyn
o  rev 2894 : 7104647: Adding a diagnostic command framework
|  Reviewed-by: phh, dcubed
6 lines changed: 6 ins; 0 del; 0 mod; 903 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/services/diagnosticCommand.hpp

@    rev 9199 : 6425769: jmx remote bind address
|\   Summary: Allow for binding to a specific address via custom socket factories.
| \
| |\
| | \
| | |\
| | | \
| | | |\
| | | | \
| | | | |\
| | | | | \
| | | | | |\
| | | | | | \
| | | | | | |\
| | | | | | | \
| | | | | | | |\
| | | | | | | | \
| | | | | | | | |\
| | | | | | | | | \
| | | | | | | | | |\
| | | | | | | | | | \
| | | | | | | | | | |\
| | | | | | | | | | | \
| | | | | | | | | | | |\
| | | | | | | | | | | | \
| | | | | | | | | | | | |\
| | | | | | | | | | | | | \
| | | | | | | | | | | | | |\
| | | | | | | | | | | | | | \
| | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | |\
| | | | | | | | | | | | | | | | | | | | \
| | | | | | | | | | | | | | | | | | | | |\
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8769 : 8059036: Implement Diagnostic Commands for heap and finalizerinfo
| | | | | | | | | | | | | | | | | | | | |/   Summary: Implement Diagnostic Commands for heap and finalizerinfo
| | | | | | | | | | | | | | | | | | | | |    Reviewed-by: sla, plevart, mchung
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8696 : 8025692: Log what methods are touched at run-time
| | | | | | | | | | | | | | | | | | | |/   Summary: Added two diagnostic flags, LogTouchedMethods and PrintTouchedMethodsAtExit to list all methods that have been touched at run time. Added new jcmd, VM.print_touched_methods.
| | | | | | | | | | | | | | | | | | | |    Reviewed-by: acorn, iklam
| | | | | | | | | | | | | | | | | | | o  rev 8072 : 8023093: Add ManagementAgent.status diagnostic command
| | | | | | | | | | | | | | | | | | |/   Reviewed-by: sla
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 8059 : 8054890: Serviceability: New diagnostic commands 'VM.set_flag' and 'JVMTI.data_dump'
| | | | | | | | | | | | | | | | | |/   Reviewed-by: sla, fparain, egahlin, ykantser
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7847 : 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy
| | | | | | | | | | | | | | | | |/   Summary: Added the VM.class_hierarhcy DCMD
| | | | | | | | | | | | | | | | |    Reviewed-by: stefank, miauno
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7058 : 8058461: serviceability/dcmd/CodelistTest.java and serviceability/dcmd/CompilerQueueTest.java SIGSEGV
| | | | | | | | | | | | | | | |/   Summary: Print only alive nmethods and add lock to print compile queue
| | | | | | | | | | | | | | | |    Reviewed-by: kvn, anoll
+-+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 7010 : 8054889: Compiler team's implementation task
| | | | | | | | | | | | | | |/   Summary: Adding three new diagnostic commands for compiler
| | | | | | | | | | | | | | |    Reviewed-by: anoll, kvn, drchase
+-+-+-+-+-+-+-+-+-+-+-+-+---o  rev 6768 : 8049325: Introduce and clean up umbrella headers for the files in the cpu subdirectories.
| | | | | | | | | | | | | |/   Summary: Introduce and clean up umbrella headers for the files in the cpu subdirectories.
| | | | | | | | | | | | | |    Reviewed-by: lfoltan, coleenp, dholmes
+-+-+-+-+-+-+-+-+-+-+-+---o  rev 6215 : 7090324: gclog rotation via external tool
| | | | | | | | | | | | |/   Summary: GC log rotation can be set via java command line, but customer sometime need to sync with OS level rotation setting.
| | | | | | | | | | | | |    Reviewed-by: sla, minqi, ehelin
| | | | | | | | | | | | |    Contributed-by: suenaga.yasumasa@lab.ntt.co.jp
+-+-+-+-+-+-+-+-+-+-+---o  rev 5808 : 8031304: Add dcmd to print all loaded dynamic libraries.
| | | | | | | | | | | |/   Summary: Adding VM.dynlibs as a dcmd to dump all loaded dynamic libraries.
| | | | | | | | | | | |    Reviewed-by: sla, fparain, mgronlun, dsamersoff
+-+-+-+-+-+-+-+-+-+---o  rev 5533 : 8026930: In ManagementAgent.start it should be possible to set the jdp.name parameter (hotspot part)
| | | | | | | | | | |/   Summary: Pass one more property from Agent to JdpController
| | | | | | | | | | |    Reviewed-by: jbachorik, sla
+-+-+-+-+-+-+-+-+---o  rev 4612 : 8004095: Add support for JMX interface to Diagnostic Framework and Commands
| | | | | | | | | |/   Reviewed-by: acorn, sla
+-+-+-+-+-+-+-+---o  rev 4109 : Merge
| | | | | | | | |/
+-+-+-+-+-+-----o  rev 4107 : 8005915: Unify SERIALGC and INCLUDE_ALTERNATE_GCS
| | | | | | | |    Summary: Rename INCLUDE_ALTERNATE_GCS to INCLUDE_ALL_GCS and replace SERIALGC with INCLUDE_ALL_GCS.
| | | | | | | |    Reviewed-by: coleenp, stefank
+-+-+-+-+-+---o  rev 4085 : 8002048: Protocol to discovery of manageable Java processes on a network
| | | | | | |/   Summary: Introduce a protocol to discover manageble Java instances across a network subnet, JDP
| | | | | | |    Reviewed-by: sla, dfuchs
+-+-+-+-+---o  rev 4062 : 6479360: PrintClassHistogram improvements
| | | | | |/   Summary: jcmd <pid> GC.class_stats (UnlockDiagnosticVMOptions)
| | | | | |    Reviewed-by: coleenp, hseigel, sla, acorn
| | | | | |    Contributed-by: ioi.lam@oracle.com
+-+-+-+---o  rev 3730 : 7189254: Change makefiles for more flexibility to override defaults
| | | | |/   Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles.
| | | | |    Reviewed-by: dholmes, coleenp
+-+-+---o  rev 3470 : 7178703: Fix handling of quoted arguments and better error messages in dcmd
| | | |/   Reviewed-by: coleenp, mgronlun, rbackman
+-+---o  rev 3163 : 7110104: It should be possible to stop and start JMX Agent at runtime
| | |/   Summary: Added a capability to start and stop JMX Agent by jcmd
| | |    Reviewed-by: acorn, mchung
+---o  rev 3043 : 7132515: Add dcmd to manage UnlockingCommercialFeature flag
| |/   Summary: Added dcmd to unlock or check status of UnlockingCommercialFeature flag
| |    Reviewed-by: fparain, rottenha
| o  rev 2967 : 7120511: Add diagnostic commands
|/   Reviewed-by: acorn, phh, dcubed, sspitsyn
o  rev 2894 : 7104647: Adding a diagnostic command framework
|  Reviewed-by: phh, dcubed
1 line changed: 1 ins; 0 del; 0 mod; 616 unchg

This code review page was prepared using ../../webrev.ksh (vers 25.6-hg+openjdk.java.net).