Code Review for openjdk-head

Prepared by:Severin Gehwolf on Thu Sep 19 13:59:35 CEST 2019
Workspace:/disk/openjdk/upstream-sources/openjdk-head
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:69210f4b2553
Summary of changes: 550 lines changed: 504 ins; 25 del; 21 mod; 4356 unchg
Patch of changes: openjdk-head.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.cpp 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
o  rev 56287 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of os_linux.cpp
~  Reviewed-by: bobv
398 lines changed: 359 ins; 24 del; 15 mod; 653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.hpp 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
o  rev 56287 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of os_linux.cpp
~  Reviewed-by: bobv
71 lines changed: 71 ins; 0 del; 0 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/osContainer_linux.cpp 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
o  rev 56287 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of os_linux.cpp
~  Reviewed-by: bobv
6 lines changed: 6 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/osContainer_linux.hpp 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
o  rev 56287 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of os_linux.cpp
~  Reviewed-by: bobv
2 lines changed: 2 ins; 0 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/whitebox.cpp 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
16 lines changed: 16 ins; 0 del; 0 mod; 2402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/cgroup/PlainRead.java 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/PrintContainerInfo.java 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
5 lines changed: 5 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/TestCPUAwareness.java 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
25 lines changed: 22 ins; 0 del; 3 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/TestMisc.java 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
19 lines changed: 16 ins; 1 del; 2 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/sun/hotspot/WhiteBox.java 

@  rev 56288 : 8230305: Cgroups v2: Container awareness
|  Reviewed-by: bobv
~
7 lines changed: 7 ins; 0 del; 0 mod; 554 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).