Code Review for openjdk-head-2

Prepared by:Severin Gehwolf on Fri Nov 15 17:05:44 CET 2019
Workspace:/disk/openjdk/upstream-sources/openjdk-head-2
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:f72fd14e15fa
Summary of changes: 2817 lines changed: 1707 ins; 831 del; 279 mod; 1818 unchg
Patch of changes: openjdk-head-2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/platform/Metrics.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 0 ins; 2 del; 1 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/cgroup/TestCgroupMetrics.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
8 lines changed: 0 ins; 7 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/docker/MetricsCpuTester.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
5 lines changed: 5 ins; 0 del; 0 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
16 lines changed: 14 ins; 0 del; 2 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
593 lines changed: 7 ins; 557 del; 29 mod; 43 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupInfo.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
233 lines changed: 233 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystem.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
214 lines changed: 214 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1MemorySubSystemController.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java (was src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java)

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
115 lines changed: 8 ins; 6 del; 101 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java (was src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java)

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
192 lines changed: 4 ins; 182 del; 6 mod; 71 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
309 lines changed: 309 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2SubsystemController.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/containers/cgroup/CgroupMetricsTester.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java (was test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java)

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
217 lines changed: 1 ins; 77 del; 139 mod; 413 unchg

------ ------ ------ ------ --- New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java

@  rev 56863 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
473 lines changed: 473 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).