Code Review for openjdk-head-2

Prepared by:Severin Gehwolf on Tue Jan 21 20:26:26 CET 2020
Workspace:/disk/openjdk/upstream-sources/openjdk-head-2
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:1b00a0c2b72d
Summary of changes: 696 lines changed: 292 ins; 350 del; 54 mod; 4432 unchg
Patch of changes: openjdk-head-2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupInfo.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
9 lines changed: 0 ins; 9 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
70 lines changed: 0 ins; 67 del; 3 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystem.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
17 lines changed: 17 ins; 0 del; 0 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
7 lines changed: 0 ins; 0 del; 7 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 0 ins; 0 del; 3 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 0 ins; 0 del; 3 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1SubsystemController.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 1 ins; 1 del; 1 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
71 lines changed: 0 ins; 66 del; 5 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2SubsystemController.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 1 ins; 1 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/platform/Metrics.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
151 lines changed: 0 ins; 151 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/launcher/LauncherHelper.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
24 lines changed: 8 ins; 5 del; 11 mod; 1230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
27 lines changed: 16 ins; 1 del; 10 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/CPUSetsReader.java

@  rev 57734 : Review feedback
|
~
3 lines changed: 1 ins; 1 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
8 lines changed: 1 ins; 0 del; 7 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java

@  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
51 lines changed: 1 ins; 48 del; 2 mod; 467 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java

@  rev 57734 : Review feedback
|
~
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/platform/MetricsCgroupV1.java

@  rev 57734 : Review feedback
|
~
168 lines changed: 168 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).