Code Review for openjdk-head-2

Prepared by:Severin Gehwolf on Tue Feb 18 11:57:40 CET 2020
Workspace:/disk/openjdk/upstream-sources/openjdk-head-2
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:5a3209860d66
Summary of changes: 617 lines changed: 255 ins; 305 del; 57 mod; 4159 unchg
Patch of changes: openjdk-head-2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupMetrics.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
1 line changed: 0 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
40 lines changed: 1 ins; 35 del; 4 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java 

@  rev 57735 : Review feedback 2
:
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
1 line changed: 0 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
~
230 lines changed: 159 ins; 69 del; 2 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
2 lines changed: 0 ins; 0 del; 2 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/cgroupv2/CgroupV2Subsystem.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
45 lines changed: 44 ins; 0 del; 1 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/launcher/LauncherHelper.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
21 lines changed: 2 ins; 8 del; 11 mod; 1216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/cgroup/TestCgroupSubsystemController.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
~
39 lines changed: 20 ins; 19 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
5 lines changed: 0 ins; 0 del; 5 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/CPUSetsReader.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
~
1 line changed: 0 ins; 0 del; 1 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/CgroupMetricsTester.java 

@  rev 57735 : Review feedback 2
:
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
4 lines changed: 0 ins; 2 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java 

@  rev 57735 : Review feedback 2
:
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
5 lines changed: 1 ins; 2 del; 2 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV1.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
8 lines changed: 0 ins; 0 del; 8 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/containers/cgroup/MetricsTesterCgroupV2.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
o  rev 57733 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv, mchung
~
o  rev 56862 : 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy
|  Reviewed-by: bobv
~
3 lines changed: 0 ins; 2 del; 1 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/linux/classes/jdk/internal/platform/CgroupV1MetricsImpl.java (was src/java.base/linux/classes/jdk/internal/platform/CgroupV1Metrics.java) 

@  rev 57735 : Review feedback 2
|
~
44 lines changed: 28 ins; 0 del; 16 mod; 62 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/platform/MetricsCgroupV1.java 

@  rev 57735 : Review feedback 2
|
o  rev 57734 : Review feedback
|
~
168 lines changed: 0 ins; 168 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).