Code Review for openjdk-head-2

Prepared by:Severin Gehwolf on Fri Nov 8 15:01:44 CET 2019
Workspace:/disk/openjdk/upstream-sources/openjdk-head-2
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version:3c2e49d43ba3
Summary of changes: 2034 lines changed: 1400 ins; 602 del; 32 mod; 765 unchg
Patch of changes: openjdk-head-2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/osContainer_linux.cpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
635 lines changed: 5 ins; 601 del; 29 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/osContainer_linux.hpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
1 line changed: 0 ins; 1 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_linux.hpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
1 line changed: 1 ins; 0 del; 0 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/containers/docker/TestCPUAwareness.java 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
16 lines changed: 13 ins; 0 del; 3 mod; 206 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.cpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
421 lines changed: 421 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupSubsystem_linux.hpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
264 lines changed: 264 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
243 lines changed: 243 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
|  Reviewed-by: bobv
o  rev 56860 : 8230848: OSContainer: Refactor container detection code
|  Summary: Move cgroups v1 implementation details out of osContainer_linux.cpp
~  Reviewed-by: bobv
118 lines changed: 118 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
243 lines changed: 243 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp 

@  rev 56862 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
o  rev 56861 : 8230305: Cgroups v2: Container awareness
|  Summary: Implement Cgroups v2 container awareness in hotspot
~  Reviewed-by: bobv
92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../webrev.ksh (vers 25.15-hg+openjdk.java.net).