Code Review for rt

Prepared by:shemnon on Mon Oct 12 12:21:23 MDT 2015
Workspace:/Users/dferrin/hg/openjfx/sandbox-9-jake/rt
Summary of changes: 4647 lines changed: 2816 ins; 1668 del; 163 mod; 15223 unchg
Patch of changes: rt.patch
Bug id: JDK-8080531
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .idea/misc.xml

2 lines changed: 0 ins; 1 del; 1 mod; 9 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .idea/modules.xml

1 line changed: 1 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .idea/vcs.xml

2 lines changed: 0 ins; 2 del; 0 mod; 8 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build.gradle

61 lines changed: 25 ins; 33 del; 3 mod; 3581 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw dependencies/java.base/module-info.java.extra

3 lines changed: 3 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractBundler.java

21 lines changed: 2 ins; 2 del; 17 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractImageBundler.java

51 lines changed: 0 ins; 47 del; 4 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/BasicBundlers.java

33 lines changed: 0 ins; 32 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/StandardBundlerParam.java

45 lines changed: 37 ins; 1 del; 7 mod; 759 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java

213 lines changed: 7 ins; 197 del; 9 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppBundler.java

836 lines changed: 10 ins; 790 del; 36 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppStoreBundler.java

76 lines changed: 1 ins; 72 del; 3 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacBaseInstallerBundler.java

147 lines changed: 0 ins; 143 del; 4 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinAppBundler.java

328 lines changed: 6 ins; 313 del; 9 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Main.java

4 lines changed: 3 ins; 1 del; 0 mod; 580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/PackagerLib.java

59 lines changed: 18 ins; 13 del; 28 mod; 911 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

20 lines changed: 0 ins; 20 del; 0 mod; 570 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/Bundler.java

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Helpers.cpp

40 lines changed: 40 ins; 0 del; 0 mod; 297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Helpers.h

2 lines changed: 2 ins; 0 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/JavaVirtualMachine.cpp

13 lines changed: 11 ins; 0 del; 2 mod; 541 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Package.cpp

9 lines changed: 9 ins; 0 del; 0 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Package.h

2 lines changed: 2 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Platform.cpp

4 lines changed: 4 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Platform.h

148 lines changed: 147 ins; 0 del; 1 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp

92 lines changed: 92 ins; 0 del; 0 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.h

6 lines changed: 6 ins; 0 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.cpp

15 lines changed: 15 ins; 0 del; 0 mod; 797 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.h

3 lines changed: 3 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppBundlerTest.java

14 lines changed: 0 ins; 0 del; 14 mod; 819 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppStoreBundlerTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacDaemonBundlerTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacDmgBundlerTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacPkgBundlerTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 677 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/hello/TestPackager.java

18 lines changed: 17 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw settings.gradle

2 lines changed: 1 ins; 0 del; 1 mod; 49 unchg

------ ------ ------ ------ --- New Patch Raw .idea/fxpackagerServices.iml

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/make/build.properties

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/JLinkBundlerHelper.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/AbstractAppImageBuilder.java

227 lines changed: 227 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/linux/LinuxAppImageBuilder.java

249 lines changed: 249 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/linux/LinuxAppImageBuilderProvider.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/mac/MacAppImageBuilder.java

870 lines changed: 870 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/mac/MacAppImageBuilderProvider.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/windows/WindowsAppImageBuilder.java

356 lines changed: 356 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/windows/WindowsAppImageBuilderProvider.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/module-info/module-info.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/JLinkBundlerHelper.properties

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/mac/Runtime-Info.plist.template

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/jdk/packager/builders/AbstractAppImageBuilder.properties

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/jdk/packager/builders/linux/LinuxAppImageBuilder.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/jdk/packager/builders/mac/MacAppImageBuilder.properties

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/jdk/packager/builders/windows/WindowsAppImageBuilder.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackagerservices/make/build.properties

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/UserJvmOptionsService.java (was modules/fxpackager/src/main/java/jdk/packager/services/UserJvmOptionsService.java)

0 lines changed: 0 ins; 0 del; 0 mod; 100 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/userjvmoptions/LauncherUserJvmOptions.java (was modules/fxpackager/src/main/java/jdk/packager/services/userjvmoptions/LauncherUserJvmOptions.java)

0 lines changed: 0 ins; 0 del; 0 mod; 169 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackagerservices/src/main/java/jdk/packager/services/userjvmoptions/PreferencesUserJvmOptions.java (was modules/fxpackager/src/main/java/jdk/packager/services/userjvmoptions/PreferencesUserJvmOptions.java)

0 lines changed: 0 ins; 0 del; 0 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackagerservices/src/main/module-info/module-info.java

34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dferrin/webrev.ksh (vers 25.1-hg+openjdk.java.net).