Code Review for rt

Prepared by:dferrin on Wed Feb 5 16:09:25 MST 2014
Workspace:/cygdrive/d/hg/jfcsrc/sandbox/javafx/8u/packager/jfx/rt
Compare against version:6329
Summary of changes: 6506 lines changed: 4870 ins; 716 del; 920 mod; 11273 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw .idea/fxpackager.iml

2 lines changed: 2 ins; 0 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build.gradle

22 lines changed: 21 ins; 0 del; 1 mod; 2795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/armv6hf.gradle

0 lines changed: 0 ins; 0 del; 0 mod; 568 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/armv6sf.gradle

0 lines changed: 0 ins; 0 del; 0 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/build.gradle

1 line changed: 0 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/DeployFXTask.java

80 lines changed: 68 ins; 0 del; 12 mod; 562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

43 lines changed: 21 ins; 5 del; 17 mod; 504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Log.java

15 lines changed: 15 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Main.java

113 lines changed: 94 ins; 6 del; 13 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/PackagerLib.java

39 lines changed: 22 ins; 2 del; 15 mod; 1751 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

238 lines changed: 151 ins; 13 del; 74 mod; 521 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/IOUtils.java

2 lines changed: 0 ins; 0 del; 2 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxAppBundler.java

157 lines changed: 77 ins; 21 del; 59 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxDebBundler.java

425 lines changed: 176 ins; 120 del; 129 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxRPMBundler.java

248 lines changed: 94 ins; 52 del; 102 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/MacAppBundler.java

292 lines changed: 176 ins; 50 del; 66 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/MacDMGBundler.java

211 lines changed: 62 ins; 64 del; 85 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/RelativeFileSet.java

8 lines changed: 6 ins; 0 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinAppBundler.java

211 lines changed: 117 ins; 9 del; 85 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinExeBundler.java

268 lines changed: 123 ins; 41 del; 104 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinMsiBundler.java

375 lines changed: 165 ins; 74 del; 136 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/packager/Bundle.properties

10 lines changed: 10 ins; 0 del; 0 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/windows/template.iss

1 line changed: 1 ins; 0 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/windows/template.wxs

3 lines changed: 0 ins; 0 del; 3 mod; 42 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/AbstractBundler.java

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/Bundler.java

87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/BundlerParamInfo.java

155 lines changed: 155 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/Bundlers.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/EnumeratedBundlerParam.java

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/InvalidBundlerParamException.java

11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/StandardBundlerParam.java

520 lines changed: 520 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacAppStoreBundler.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacBaseInstallerBundler.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacPKGBundler.java

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/windows/WindowsBundlerParam.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleType.java

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/ConfigException.java

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/UnsupportedPlatformException.java

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/AbstractBundler.properties

11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/StandardBundlerParam.properties

115 lines changed: 115 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/linux/LinuxAppBundler.properties

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/linux/LinuxDebBundler.properties

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/linux/LinuxRpmBundler.properties

35 lines changed: 35 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WinAppBundler.properties

32 lines changed: 32 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WinExeBundler.properties

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WinMsiBundler.properties

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WindowsBundlerParam.properties

12 lines changed: 12 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/BundlersTest.java

177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxAppBundlerTest.java

133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxDebBundlerTest.java

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxRpmBundlerTest.java

111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacAppBundlerTest.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacDMGBundlerTest.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacPKGBundlerTest.java

121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/RuntimeFlagsParserTest.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinAppBundlerTest.java

131 lines changed: 131 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinEXEBundlerTest.java

114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinMSIBundlerTest.java

114 lines changed: 114 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/ant/FXJarTest.java (was modules/fxpackager/test/main/java/com/sun/javafx/tools/ant/FXJarTest.java)

6 lines changed: 2 ins; 2 del; 2 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/packager/PackagerLibTest.java (was modules/fxpackager/test/main/java/com/sun/javafx/tools/packager/PackagerLibTest.java)

22 lines changed: 10 ins; 7 del; 5 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/packager/bundlers/BundleParamsTest.java (was modules/fxpackager/test/main/java/com/sun/javafx/tools/packager/bundlers/BundleParamsTest.java)

14 lines changed: 4 ins; 3 del; 7 mod; 53 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/packager/bundlers/WinMsiBundlerTest.java (was modules/fxpackager/test/main/java/com/sun/javafx/tools/packager/bundlers/WinMsiBundlerTest.java)

0 lines changed: 0 ins; 0 del; 0 mod; 47 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/hello/HelloRectangle.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/hello/TestPackager.java

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/resources/TestResource.java

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/resources/com/sun/javafx/tools/ant/bundleargs.xml

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/Bundler.java

247 lines changed: 0 ins; 247 del; 0 mod; 0 unchg

This code review page was prepared using /home/dferrin/scripts/webrev.ksh (vers 25.1-hg+openjdk.java.net).