Code Review for rt

Prepared by:shemnon on Thu Mar 13 13:00:36 MDT 2014
Workspace:/Users/dferrin/hg/jfxsrc/javafx/8u/dev/jfx/rt
Summary of changes: 4952 lines changed: 3570 ins; 502 del; 880 mod; 10603 unchg
Patch of changes: rt.patch
Bug id: RT-35635
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/AbstractBundler.java

37 lines changed: 3 ins; 21 del; 13 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/BundlerParamInfo.java

5 lines changed: 1 ins; 0 del; 4 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/Bundlers.java

116 lines changed: 47 ins; 37 del; 32 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/EnumeratedBundlerParam.java

2 lines changed: 1 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/InvalidBundlerParamException.java

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/StandardBundlerParam.java

234 lines changed: 95 ins; 67 del; 72 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacAppStoreBundler.java

339 lines changed: 326 ins; 7 del; 6 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacBaseInstallerBundler.java

88 lines changed: 55 ins; 5 del; 28 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacPKGBundler.java

210 lines changed: 185 ins; 4 del; 21 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/windows/WindowsBundlerParam.java

10 lines changed: 1 ins; 0 del; 9 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

9 lines changed: 9 ins; 0 del; 0 mod; 545 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Log.java

5 lines changed: 4 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Main.java

18 lines changed: 3 ins; 4 del; 11 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/PackagerLib.java

132 lines changed: 10 ins; 64 del; 58 mod; 1682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

241 lines changed: 2 ins; 199 del; 40 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/ConfigException.java

6 lines changed: 5 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxAppBundler.java

58 lines changed: 41 ins; 0 del; 17 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxDebBundler.java

113 lines changed: 47 ins; 12 del; 54 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/LinuxRPMBundler.java

115 lines changed: 74 ins; 0 del; 41 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/MacAppBundler.java

228 lines changed: 134 ins; 22 del; 72 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/MacDMGBundler.java

103 lines changed: 18 ins; 8 del; 77 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinAppBundler.java

103 lines changed: 82 ins; 0 del; 21 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinExeBundler.java

94 lines changed: 40 ins; 7 del; 47 mod; 383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/WinMsiBundler.java

155 lines changed: 76 ins; 6 del; 73 mod; 636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/StandardBundlerParam.properties

103 lines changed: 15 ins; 0 del; 88 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/linux/LinuxDebBundler.properties

1 line changed: 1 ins; 0 del; 0 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/linux/LinuxRpmBundler.properties

1 line changed: 1 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WinExeBundler.properties

1 line changed: 1 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/windows/WinMsiBundler.properties

2 lines changed: 2 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/packager/Bundle.properties

1 line changed: 1 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/linux/template.postinst

19 lines changed: 18 ins; 1 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/linux/template.postrm

9 lines changed: 8 ins; 1 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/linux/template.spec

18 lines changed: 18 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/windows/template.iss

5 lines changed: 4 ins; 0 del; 1 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxAppBundlerTest.java

12 lines changed: 2 ins; 3 del; 7 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxDebBundlerTest.java

20 lines changed: 6 ins; 3 del; 11 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/linux/LinuxRpmBundlerTest.java

21 lines changed: 7 ins; 3 del; 11 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacAppBundlerTest.java

25 lines changed: 9 ins; 8 del; 8 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacDMGBundlerTest.java

23 lines changed: 6 ins; 4 del; 13 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacPKGBundlerTest.java

23 lines changed: 6 ins; 3 del; 14 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinAppBundlerTest.java

12 lines changed: 2 ins; 3 del; 7 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinEXEBundlerTest.java

65 lines changed: 50 ins; 7 del; 8 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/windows/WinMSIBundlerTest.java

102 lines changed: 88 ins; 3 del; 11 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/packager/PackagerLibTest.java

1 line changed: 0 ins; 0 del; 1 mod; 617 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/BasicBundlers.java

145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/JreUtils.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/bundlers/mac/MacDaemonBundler.java

252 lines changed: 252 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/native/launcher/win/WinLauncherSvc.cpp

884 lines changed: 884 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/mac/MacAppBundler.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/mac/MacAppStoreBundler.properties

20 lines changed: 20 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/mac/MacBaseInstallerBundler.properties

26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/mac/MacDaemonBundler.properties

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/bundlers/mac/MacPKGBundler.properties

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/linux/template.deb.init.script

154 lines changed: 154 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/linux/template.rpm.init.script

102 lines changed: 102 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/GenericAppHiDPI.icns

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/GenericAppHiDPI.icns`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/MacAppStore.entitlements

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/MacAppStore_Inherit.entitlements

10 lines changed: 10 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/launchd.plist.template

14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/postinstall.template

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/sun/javafx/tools/resource/mac/preinstall.template

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/oracle/bundlers/mac/MacAppStoreBundlerTest.java

185 lines changed: 185 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/java/com/sun/javafx/tools/packager/CLITest.java

94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dferrin/webrev.ksh (vers 25.1-hg+openjdk.java.net).