Code Review for rt

Prepared by:shemnon on Mon Mar 30 15:12:33 MDT 2015
Workspace:/Users/dferrin/hg/openjfx/8u-dev/rt
Summary of changes: 3932 lines changed: 3070 ins; 268 del; 594 mod; 20406 unchg
Patch of changes: rt.patch
Bug id: RT-39975
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractBundler.java

18 lines changed: 0 ins; 18 del; 0 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/RelativeFileSet.java

6 lines changed: 5 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/StandardBundlerParam.java

31 lines changed: 31 ins; 0 del; 0 mod; 702 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java

18 lines changed: 10 ins; 0 del; 8 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxDebBundler.java

11 lines changed: 11 ins; 0 del; 0 mod; 925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxRpmBundler.java

11 lines changed: 11 ins; 0 del; 0 mod; 739 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppBundler.java

143 lines changed: 129 ins; 5 del; 9 mod; 1038 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinAppBundler.java

27 lines changed: 14 ins; 3 del; 10 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinExeBundler.java

3 lines changed: 3 ins; 0 del; 0 mod; 711 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinMsiBundler.java

18 lines changed: 18 ins; 0 del; 0 mod; 1076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

88 lines changed: 38 ins; 9 del; 41 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Exports.cpp

43 lines changed: 13 ins; 13 del; 17 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/FilePath.cpp

450 lines changed: 436 ins; 4 del; 10 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/FilePath.h

75 lines changed: 72 ins; 0 del; 3 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/GenericPlatform.cpp

27 lines changed: 13 ins; 3 del; 11 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/GenericPlatform.h

3 lines changed: 0 ins; 0 del; 3 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Helpers.cpp

174 lines changed: 113 ins; 10 del; 51 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Helpers.h

53 lines changed: 7 ins; 35 del; 11 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Java.cpp

53 lines changed: 0 ins; 23 del; 30 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Java.h

7 lines changed: 0 ins; 3 del; 4 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/JavaUserPreferences.cpp

1 line changed: 0 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/JavaUserPreferences.h

3 lines changed: 0 ins; 0 del; 3 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/JavaVirtualMachine.cpp

91 lines changed: 46 ins; 20 del; 25 mod; 462 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/JavaVirtualMachine.h

2 lines changed: 2 ins; 0 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/LinuxPlatform.cpp

38 lines changed: 12 ins; 5 del; 21 mod; 1082 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/LinuxPlatform.h

2 lines changed: 0 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Lock.h

1 line changed: 0 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/MacPlatform.h

4 lines changed: 0 ins; 0 del; 4 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/MacPlatform.mm

201 lines changed: 96 ins; 27 del; 78 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Macros.cpp

7 lines changed: 4 ins; 0 del; 3 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Messages.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Messages.h

1 line changed: 1 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Package.cpp

329 lines changed: 190 ins; 52 del; 87 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Package.h

31 lines changed: 11 ins; 1 del; 19 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Platform.cpp

1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/Platform.h

148 lines changed: 121 ins; 7 del; 20 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PlatformString.cpp

11 lines changed: 1 ins; 0 del; 10 mod; 393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PlatformString.h

10 lines changed: 0 ins; 0 del; 10 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.cpp

198 lines changed: 193 ins; 0 del; 5 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PosixPlatform.h

29 lines changed: 29 ins; 0 del; 0 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PropertyFile.cpp

55 lines changed: 21 ins; 10 del; 24 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/PropertyFile.h

16 lines changed: 7 ins; 4 del; 5 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.cpp

200 lines changed: 168 ins; 6 del; 26 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/WindowsPlatform.h

44 lines changed: 42 ins; 0 del; 2 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/main.cpp

117 lines changed: 87 ins; 7 del; 23 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/tests/linux/library/packager/nbproject/Makefile-Debug.mk

6 lines changed: 6 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/tests/linux/library/packager/nbproject/Makefile-Release.mk

6 lines changed: 6 ins; 0 del; 0 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/tests/linux/library/packager/nbproject/configurations.xml

33 lines changed: 33 ins; 0 del; 0 mod; 499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/tests/mac/library/packager/libpackager.xcodeproj/project.pbxproj

16 lines changed: 12 ins; 0 del; 4 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/tests/win/library/library.vcxproj

4 lines changed: 3 ins; 0 del; 1 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/AbstractBundler.properties

3 lines changed: 0 ins; 3 del; 0 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/StandardBundlerParam.properties

9 lines changed: 9 ins; 0 del; 0 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/LinuxAppBundler.properties

1 line changed: 0 ins; 0 del; 1 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.postinst

1 line changed: 1 ins; 0 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/linux/template.spec

1 line changed: 1 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/mac/MacAppBundler.properties

5 lines changed: 3 ins; 0 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/windows/WinAppBundler.properties

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/windows/template.iss

1 line changed: 1 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/windows/template.wxs

1 line changed: 1 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/CLITest.java

1 line changed: 1 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxAppBundlerTest.java

1 line changed: 1 ins; 0 del; 0 mod; 379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxDebBundlerTest.java

38 lines changed: 38 ins; 0 del; 0 mod; 589 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/linux/LinuxRpmBundlerTest.java

38 lines changed: 38 ins; 0 del; 0 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppBundlerTest.java

32 lines changed: 32 ins; 0 del; 0 mod; 801 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/mac/MacAppStoreBundlerTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinAppBundlerTest.java

33 lines changed: 32 ins; 0 del; 1 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinExeBundlerTest.java

37 lines changed: 37 ins; 0 del; 0 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/com/oracle/tools/packager/windows/WinMsiBundlerTest.java

37 lines changed: 37 ins; 0 del; 0 mod; 543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/test/java/hello/TestPackager.java

6 lines changed: 5 ins; 0 del; 1 mod; 176 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/AbstractImageBundler.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/native/library/common/IniFile.cpp

273 lines changed: 273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/native/library/common/IniFile.h

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/native/library/common/OrderedMap.h

227 lines changed: 227 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/AbstractImageBundler.properties

7 lines changed: 7 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/mac/Info-lite.plist.template

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/dferrin/webrev.ksh (vers 25.1-hg+openjdk.java.net).