Code Review for jdk

Prepared by:sherman on Mon Feb 16 10:41:57 PST 2015
Workspace:/export/sherman/Workspace/jdk9_dev0/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 4920 lines changed: 3043 ins; 1782 del; 95 mod; 7433 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/Gensrc-jdk.charsets.gmk

20 lines changed: 9 ins; 7 del; 4 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/GensrcCharsetMapping.gmk

103 lines changed: 7 ins; 92 del; 4 mod; 40 unchg

------ ------ ------ ------ --- New Patch Raw make/data/charsetmapping/charsets

1818 lines changed: 1818 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/data/charsetmapping/stdcs-linux

19 lines changed: 19 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/data/charsetmapping/stdcs-solaris

23 lines changed: 23 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/data/charsetmapping/stdcs-windows

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/data/charsetmapping/list_old

149 lines changed: 149 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- make/data/charsetmapping/dbcs

36 lines changed: 0 ins; 36 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- make/data/charsetmapping/extsbcs

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- make/data/charsetmapping/sbcs

28 lines changed: 0 ins; 28 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- make/data/charsetmapping/standard-charsets

337 lines changed: 0 ins; 337 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/charsetmapping/DoubleByte-X.java.template

2 lines changed: 1 ins; 0 del; 1 mod; 99 unchg

------ ------ ------ ------ --- New Patch Raw make/src/classes/build/tools/charsetmapping/Charset.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/src/classes/build/tools/charsetmapping/Hasher.java

265 lines changed: 265 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/src/classes/build/tools/charsetmapping/SPI.java

141 lines changed: 141 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/src/classes/build/tools/charsetmapping/SRC.java

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/DBCS.java

63 lines changed: 10 ins; 49 del; 4 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/HKSCS.java

32 lines changed: 16 ins; 0 del; 16 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/Main.java

179 lines changed: 168 ins; 0 del; 11 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/charsetmapping/SBCS.java

132 lines changed: 52 ins; 76 del; 4 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template

178 lines changed: 171 ins; 3 del; 4 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/AbstractCharsetProvider.java

6 lines changed: 6 ins; 0 del; 0 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/DelegatableDecoder.java (was src/jdk.charsets/share/classes/sun/nio/cs/ext/DelegatableDecoder.java)

2 lines changed: 0 ins; 0 del; 2 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/DoubleByte.java (was src/jdk.charsets/share/classes/sun/nio/cs/ext/DoubleByte.java)

17 lines changed: 0 ins; 0 del; 17 mod; 912 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/cs/HKSCS.java (was src/jdk.charsets/share/classes/sun/nio/cs/ext/HKSCS.java)

4 lines changed: 1 ins; 0 del; 3 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ExtendedCharsets.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/ExtendedCharsets.java)

1086 lines changed: 6 ins; 1076 del; 4 mod; 246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_HKSCS_2001.java

2 lines changed: 2 ins; 0 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM834.java

1 line changed: 1 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM942C.java

1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM943C.java

1 line changed: 1 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM949C.java

1 line changed: 1 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_CN.java

2 lines changed: 2 ins; 0 del; 0 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_CN_GB.java

1 line changed: 1 ins; 0 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_JP.java

3 lines changed: 3 ins; 0 del; 0 mod; 762 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_JP_2.java

2 lines changed: 2 ins; 0 del; 0 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/ISO2022_KR.java

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/JISAutoDetect.java

2 lines changed: 2 ins; 0 del; 0 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MS50220.java

2 lines changed: 2 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MS50221.java

1 line changed: 1 ins; 0 del; 0 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MS932_0213.java

2 lines changed: 2 ins; 0 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MS950_HKSCS.java

1 line changed: 1 ins; 0 del; 0 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MSISO2022JP.java

1 line changed: 1 ins; 0 del; 0 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/SJIS_0213.java

1 line changed: 1 ins; 0 del; 0 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_HKSCS.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_HKSCS.java)

5 lines changed: 2 ins; 0 del; 3 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_Solaris.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/Big5_Solaris.java)

3 lines changed: 1 ins; 0 del; 2 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java)

5 lines changed: 3 ins; 0 del; 2 mod; 409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP_LINUX.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP_LINUX.java)

4 lines changed: 1 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP_Open.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP_Open.java)

5 lines changed: 2 ins; 0 del; 3 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.charsets/share/classes/sun/nio/cs/ext/MS950_HKSCS_XP.java.template (was src/jdk.charsets/share/classes/sun/nio/cs/ext/MS950_HKSCS_XP.java)

4 lines changed: 2 ins; 0 del; 2 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/HKSCS.java

12 lines changed: 10 ins; 0 del; 2 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11GB2312.java

1 line changed: 1 ins; 0 del; 0 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11GBK.java

1 line changed: 1 ins; 0 del; 0 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11JIS0201.java

1 line changed: 0 ins; 0 del; 1 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11JIS0208.java

2 lines changed: 1 ins; 0 del; 1 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11JIS0212.java

2 lines changed: 1 ins; 0 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/unix/classes/sun/awt/motif/X11KSC5601.java

1 line changed: 1 ins; 0 del; 0 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java

10 lines changed: 8 ins; 2 del; 0 mod; 213 unchg

This code review page was prepared using /java/jdk/bin/webrev (vers 23.18-hg).