Code Review for v3

Prepared by:shurailine on Fri Dec 22 12:37:13 PST 2017
Workspace:/Users/shura/JDK/hg/jemmy/v3
Compare against: http://hg.openjdk.java.net/code-tools/jemmy/v3/
Compare against version:0
Summary of changes: 8712 lines changed: 8712 ins; 0 del; 0 mod; 0 unchg
Changeset: v3.changeset
Legend: Modified file
Deleted file
New file

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/build.xml

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/AWTImage.java

217 lines changed: 217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/AWTRobotCapturer.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/AverageDistanceImageComparator.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/BufferedImageComparator.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/ClasspathImageLoader.java

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/DiffDialog.form

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/DiffDialog.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
393 lines changed: 393 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/FilesystemImageLoader.java

58 lines changed: 58 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/ImageFinder.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/ImageTool.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
231 lines changed: 231 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/NaturalImageComparator.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/PNGDecoder.java

269 lines changed: 269 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/PNGEncoder.java

264 lines changed: 264 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/PNGImageLoader.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/PNGImageSaver.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/ResizeImageComparator.java

214 lines changed: 214 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/RoughImageComparator.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/RoughImageFinder.java

100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/StrictImageComparator.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/StrictImageFinder.java

94 lines changed: 94 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/Utils.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/image/package.html

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/AWTMap.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
216 lines changed: 216 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/AWTRobotInputFactory.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
155 lines changed: 155 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/ClassReference.java

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/DragImpl.java

144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/KeyboardImpl.java

206 lines changed: 206 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/MouseImpl.java

273 lines changed: 273 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/RobotDriver.java

334 lines changed: 334 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/RobotExecutor.java

601 lines changed: 601 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/Version.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/input/jemmy.properties

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/src/org/jemmy/operators/AWTScreen.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/TEST.ROOT

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/AreaChart_a.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/AreaChart_a.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/AreaChart_a_res.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/AreaChart_a_res.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/AverageDistanceImageComparatorTest.java

315 lines changed: 315 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/CheckBox_a_start.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/CheckBox_a_start.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/CheckBox_a_start_res.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/CheckBox_a_start_res.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/EnvTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/ImageResizerTest.java

216 lines changed: 216 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/InitTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/NaturalImageComparatorTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
310 lines changed: 310 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/SaveLoadTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/ScreenAreaImageTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/ScreenImageTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
127 lines changed: 127 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/ComparatorTest.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-averagedistance.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-averagedistance.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-hyperlink.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-hyperlink.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-strict.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/actual-strict.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-averagedistance.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-averagedistance.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-hyperlink.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-hyperlink.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-strict.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/comparator/golden-strict.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/image1.jpg

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/image1.jpg`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/image2.jpg

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/image2.jpg`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/image3.jpg

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/image3.jpg`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/test_image.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/test_image.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/fail.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/fail.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/mess.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/mess.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/missed.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/missed.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/pass.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/golden/pass.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/fail.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/fail.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/mess.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/mess.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/new.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/new.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/pass.png

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
Unexpected Error occurred reading `diff -e /dev/null new/core/JemmyAWTInput/test/org/jemmy/image/tool/data/results/pass.png`: $?=0, err= 1

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/input/AWTMapTest.java

213 lines changed: 213 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/input/RobotDriver2Test.java

rev 1 : 7902086: Add JemmyAWTInput to jemmy/v3
626 lines changed: 626 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/input/RobotDriverTest.java

484 lines changed: 484 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/input/RobotExecutorTest.java

389 lines changed: 389 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/input/SmoothMoveTest.java

392 lines changed: 392 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw core/JemmyAWTInput/test/org/jemmy/operators/ScreenTest.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../../bin/webrev.ksh (vers 25.7-hg+openjdk.java.net).