Code Review for jdk

Prepared by:Alexandre (Shura) Iline on Mon Oct 26 20:05:01 MSK 2015
Workspace:/Users/shura/JDK/hg/jake-dev/jdk
Compare against: http://hg.openjdk.java.net/jigsaw/jake/jdk
Summary of changes: 120 lines changed: 64 ins; 47 del; 9 mod; 14720 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/GetModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Package/annotation/PackageInfoTest.java

6 lines changed: 6 ins; 0 del; 0 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/ProcessHandle/TEST.properties

1 line changed: 0 ins; 0 del; 1 mod; 3 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/annotation/AnnotationType/AnnotationTypeDeadlockTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/AddTransformerTest.java

1 line changed: 0 ins; 1 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/AppendToBootstrapClassPathTest.java

1 line changed: 0 ins; 1 del; 0 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/AppendToClassPathTest.java

1 line changed: 0 ins; 1 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/BootClassPath/BootClassPathTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/FromShutdownHook.java

1 line changed: 0 ins; 1 del; 0 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/GetAllLoadedClassesTest.java

1 line changed: 0 ins; 1 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/GetInitiatedClassesTest.java

1 line changed: 0 ins; 1 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/GetObjectSizeTest.java

1 line changed: 0 ins; 1 del; 0 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/IsModifiableClassAgent.java

1 line changed: 0 ins; 1 del; 0 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ManifestTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NativeMethodPrefixAgent.java

2 lines changed: 2 ins; 0 del; 0 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NoTransformerAddedTest.java

1 line changed: 0 ins; 1 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NullGetObjectSizeTest.java

1 line changed: 0 ins; 1 del; 0 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NullRedefineClassesTests.java

1 line changed: 0 ins; 1 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NullTransformerAddTest.java

1 line changed: 0 ins; 1 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/NullTransformerRemoveTest.java

1 line changed: 0 ins; 1 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/ParallelTransformerLoader.sh

1 line changed: 0 ins; 1 del; 0 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent0010.java

1 line changed: 0 ins; 1 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent0011.java

1 line changed: 0 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent0110.java

1 line changed: 0 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent0111.java

1 line changed: 0 ins; 1 del; 0 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1000.java

1 line changed: 0 ins; 1 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1001.java

1 line changed: 0 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1010.java

1 line changed: 0 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1011.java

1 line changed: 0 ins; 1 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1100.java

1 line changed: 0 ins; 1 del; 0 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1101.java

1 line changed: 0 ins; 1 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1110.java

1 line changed: 0 ins; 1 del; 0 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/PremainClass/InheritAgent1111.java

1 line changed: 0 ins; 1 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineBigClass.sh

1 line changed: 1 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineClassWithNativeMethod.sh

1 line changed: 0 ins; 1 del; 0 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineClassesDisabledTest.java

1 line changed: 0 ins; 1 del; 0 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineClassesTests.java

1 line changed: 0 ins; 1 del; 0 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineMethodAddInvoke.sh

1 line changed: 0 ins; 1 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineMethodDelInvoke.sh

1 line changed: 0 ins; 1 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineMethodInBacktrace.sh

1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineMethodWithAnnotations.sh

1 line changed: 0 ins; 1 del; 0 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RedefineSubclassWithTwoInterfaces.sh

1 line changed: 0 ins; 1 del; 0 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RemoveAbsentTransformerTest.java

1 line changed: 0 ins; 1 del; 0 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RemoveTransformerTest.java

1 line changed: 0 ins; 1 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/RetransformBigClass.sh

1 line changed: 1 ins; 0 del; 0 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/SingleTransformerTest.java

1 line changed: 0 ins; 1 del; 0 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/StressGetObjectSizeTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/TransformMethodTest.java

1 line changed: 0 ins; 1 del; 0 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/TransformerManagementThreadAddTests.java

1 line changed: 0 ins; 1 del; 0 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/TransformerManagementThreadRemoveTests.java

1 line changed: 0 ins; 1 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh

1 line changed: 0 ins; 1 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh

1 line changed: 0 ins; 1 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

1 line changed: 1 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/lambda/LambdaAccessControlDoPrivilegedTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/lambda/LambdaAccessControlTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/lambda/LambdaAsm.java

2 lines changed: 1 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/invoke/lambda/LambdaStackTrace.java

1 line changed: 1 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/etc/resources/ResourcesTest.java

1 line changed: 1 ins; 0 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/invoke/access/ModuleAccessControlTest.java

1 line changed: 1 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/addexports/AddExportsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/addmods/AddModsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/addreads/AddReadsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/basic/BasicTest.java

1 line changed: 1 ins; 0 del; 0 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/limitmods/LimitModsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/patch/PatchTest.java

1 line changed: 1 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/launcher/upgrademodulepath/UpgradeModulePathTest.java

1 line changed: 1 ins; 0 del; 0 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/module/ModuleReader/ModuleReaderTest.java

1 line changed: 1 ins; 0 del; 0 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/reflect/Module/BasicModuleTest.java

1 line changed: 1 ins; 0 del; 0 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/reflect/Module/access/AccessTest.java

1 line changed: 1 ins; 0 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/reflect/Proxy/ProxyClassAccessTest.java

1 line changed: 1 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/reflect/Proxy/ProxyLayerTest.java

1 line changed: 1 ins; 0 del; 0 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/reflect/Proxy/ProxyTest.java

1 line changed: 1 ins; 0 del; 0 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/scenarios/automaticmodules/RunWithAutomaticModules.java

1 line changed: 1 ins; 0 del; 0 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/scenarios/container/ContainerTest.java

1 line changed: 1 ins; 0 del; 0 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/scenarios/overlappingpackages/OverlappingPackagesTest.java

1 line changed: 1 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jimage/JImageTest.java

1 line changed: 1 ins; 0 del; 0 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/CustomImageBuilderTest.java

1 line changed: 1 ins; 0 del; 0 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/CustomPluginTest.java

1 line changed: 1 ins; 0 del; 0 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/DefaultProviderTest.java

1 line changed: 1 ins; 0 del; 0 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/IntegrationTest.java

1 line changed: 1 ins; 0 del; 0 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLink2Test.java

1 line changed: 1 ins; 0 del; 0 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkNegativeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkOptimTest.java

1 line changed: 1 ins; 0 del; 0 mod; 424 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkOptionsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkPluginsTest.java

1 line changed: 1 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkPostProcessingTest.java

1 line changed: 1 ins; 0 del; 0 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/JLinkTest.java

1 line changed: 1 ins; 0 del; 0 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/NativeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/basic/BasicTest.java

1 line changed: 1 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/hashes/HashesTest.java

1 line changed: 1 ins; 0 del; 0 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/plugins/PluginOrderTest.java

1 line changed: 1 ins; 0 del; 0 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/plugins/StringSharingPluginTest.java

1 line changed: 1 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jlink/plugins/StripDebugPluginTest.java

1 line changed: 1 ins; 0 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jmod/JmodNegativeTest.java

1 line changed: 1 ins; 0 del; 0 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/tools/jmod/JmodTest.java

3 lines changed: 2 ins; 1 del; 0 mod; 460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jigsaw/util/ServiceLoader/ServicesTest.java

2 lines changed: 2 ins; 0 del; 0 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/lambda/TEST.properties

1 line changed: 1 ins; 0 del; 0 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/misc/JarIndex/metaInfFilenames/Basic.java

3 lines changed: 2 ins; 0 del; 1 mod; 402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java

2 lines changed: 1 ins; 0 del; 1 mod; 70 unchg

------ ------ ------ ------ --- New Patch Raw test/java/lang/instrument/TEST.properties

1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../../bin/webrev.ksh (vers 25.7-hg+openjdk.java.net).